GNU bug report logs -
#76745
31.0.50; ?d action in save-some-buffers-action-alist to view diff does not work
Previous Next
Reported by: StrawberryTea <look <at> strawberrytea.xyz>
Date: Tue, 4 Mar 2025 18:49:03 UTC
Severity: normal
Fixed in version 31.0.50
Done: Juri Linkov <juri <at> linkov.net>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
> From: StrawberryTea <look <at> strawberrytea.xyz>
> Date: Tue, 04 Mar 2025 13:47:39 -0500
>
>
> Hello. I have found that the fix from #75993 breaks the ?d action in
> save-some-buffers-action-alist. The reason is that since we are not
> entering view-mode after #75993, when we type ?q to quit the diff
> window, we are not calling exit-recursive-edit to return to the
> save-some-buffers queries.
>
> So on one hand, we want to scroll through the diff easily to decide
> whether to save the buffer or not. But on the other hand, we want to
> navigate by the diff sections and copy hunks. To me, this is a model
> editing situation. The user should exit view mode to perform diff
> commands instead of disabling view-mode for diffs altogether like in
> #75993.
>
> But anyway, I propose that we revert #75993.
Adding Juri to the discussion.
This bug report was last modified 100 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.