GNU bug report logs - #76744
[PATCH] etags test doesn't pass

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76744: closed ([PATCH] etags test doesn't pass)
Date: Mon, 10 Mar 2025 21:11:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 10 Mar 2025 14:10:17 -0700
with message-id <CADwFkmk3+83_v-A5MhU6AnyZ2MG4Vf24NetquWXTBWy8yzRaNA <at> mail.gmail.com>
and subject line Re: bug#76744: [PATCH] etags test doesn't pass
has caused the debbugs.gnu.org bug report #76744,
regarding [PATCH] etags test doesn't pass
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76744: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76744
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vladimir Gorsunov <gorsunov <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] etags test doesn't pass
Date: Tue, 4 Mar 2025 18:54:08 +0200

[Message part 3 (text/plain, inline)]

  Test for etags fails since commit 4da38c63 when update-copyrights script
inserted new lines into some of the test files. Including a patch that
reverts added lines and adds a check to the script

-- 
Mit Respekt, Vladimir Gorsunov

[Message part 4 (text/html, inline)]

[0001-Fix-test-manual-etags.patch (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: gorsunov <at> gmail.com, 76744-done <at> debbugs.gnu.org,
 Paul Eggert <eggert <at> cs.ucla.edu>
Subject: Re: bug#76744: [PATCH] etags test doesn't pass
Date: Mon, 10 Mar 2025 14:10:17 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: Vladimir Gorsunov <gorsunov <at> gmail.com>, 76744 <at> debbugs.gnu.org
>> Date: Tue, 4 Mar 2025 13:48:51 -0800
>> From: Paul Eggert <eggert <at> cs.ucla.edu>
>>
>> On 3/4/25 11:22, Stefan Kangas wrote:
>> >> * build-aux/update-copyright: Added check to not change test data
>> > This script is maintained in Gnulib, so I'm not sure where to put this,
>> > as it's only relevant to Emacs.
>>
>> Yes, changes like this should be put into admin/update-copyright, not
>> build-aux/update-copyright.
>>
>> However, this kind of change is heading in the wrong direction, as the
>> test files in question mutate from time to time, e.g., commit
>> d0be0965ca344caab7879b2ac2373a68025c9ba2. Instead, either the tests
>> should be redone to be robust in the presence of line number changes, or
>> (probably easier) admin/update-copyright should be taught not to change
>> the number of lines when it updates a copyright date.
>
> For now, I simply updated the expected-results files in
> test/manual/etags/.  This is what we've been doing this since these
> tests were added.  If someone wants to modify the update-copyright
> scripts to skip those files, feel free, but TBH I'm not sure we are
> allowed not to update the copyright of test files.

I'd tend to agree.  I'm therefore closing this bug report.

Thanks Vladimir for the patches, nevertheless.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.