GNU bug report logs - #7661
docs: typo in documentation about python extension modules?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7661 in the body.
You can then email your comments to 7661 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: bug-automake <at> gnu.org
Subject: docs: typo in documentation about python extension modules?
Date: Fri, 17 Dec 2010 14:51:12 +0100

In the section "10.5 Python" of the manual, there is this example,
which seems wrong (but I'm not sure, that's why I'm asking):

  pyexecdir
      This is the directory where Python extension modules (shared
      libraries) should be installed. An extension module written in
      C could be declared as follows to Automake:

          pyexec_LTLIBRARIES = quaternion.la
          quaternion_SOURCES = quaternion.c support.c support.h
          quaternion_la_LDFLAGS = -avoid-version -module

      ...

Shouldn't `quaternion_la_SOURCES' be used instead of `quaternion_SOURCES'?

Regards,
  Stefano

Message #8 received at 7661 <at> debbugs.gnu.org (full text, mbox):

From: Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 7661 <at> debbugs.gnu.org
Subject: Re: bug#7661: docs: typo in documentation about python extension
	modules?
Date: Sat, 18 Dec 2010 07:09:38 +0100

* Stefano Lattarini wrote on Fri, Dec 17, 2010 at 02:51:12PM CET:
>           pyexec_LTLIBRARIES = quaternion.la
>           quaternion_SOURCES = quaternion.c support.c support.h
>           quaternion_la_LDFLAGS = -avoid-version -module

> Shouldn't `quaternion_la_SOURCES' be used instead of `quaternion_SOURCES'?

Yep.  Fix is preapproved.

Thanks,
Ralf

Message #13 received at 7661-done <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: automake-patches <at> gnu.org
Cc: Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de>, 7661-done <at> debbugs.gnu.org
Subject: [PATCH] {maint} docs: fix blunder in example about python extension
	modules (was: Re: bug#7661: docs: typo in documentation about
	python extension modules?)
Date: Sat, 18 Dec 2010 12:20:20 +0100

On Saturday 18 December 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Fri, Dec 17, 2010 at 02:51:12PM CET:
> >           pyexec_LTLIBRARIES = quaternion.la
> >           quaternion_SOURCES = quaternion.c support.c support.h
> >           quaternion_la_LDFLAGS = -avoid-version -module
> 
> > Shouldn't `quaternion_la_SOURCES' be used instead of `quaternion_SOURCES'?
> 
> Yep.  Fix is preapproved.
> 
> Thanks,
> Ralf
> 

Below is what I pushed.

Thanks,
  Stefano

-*-*-*-

docs: fix blunder in example about python extension modules

* doc/automake.texi (Python): Use `quaternion_la_SOURCES',
not `quaternion_SOURCES', to declare the sources of python
extension module `quaternion.la'.
---
 ChangeLog         |    7 +++++++
 doc/automake.texi |    2 +-
 2 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 3eee3a7..69286c9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2010-12-18  Stefano Lattarini  <stefano.lattarini <at> gmail.com>
+
+	docs: fix blunder in example about python extension modules
+	* doc/automake.texi (Python): Use `quaternion_la_SOURCES',
+	not `quaternion_SOURCES', to declare the sources of python
+	extension module `quaternion.la'.
+
 2010-12-16  Stefano Lattarini  <stefano.lattarini <at> gmail.com>
 
 	docs: list LTLIBRARIES among Automake primaries
diff --git a/doc/automake.texi b/doc/automake.texi
index 227b1ba..9c2074b 100644
--- a/doc/automake.texi
+++ b/doc/automake.texi
@@ -7632,7 +7632,7 @@ as follows to Automake:
 
 @example
 pyexec_LTLIBRARIES = quaternion.la
-quaternion_SOURCES = quaternion.c support.c support.h
+quaternion_la_SOURCES = quaternion.c support.c support.h
 quaternion_la_LDFLAGS = -avoid-version -module
 @end example
 
-- 
1.7.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.