GNU bug report logs - #76448
[PATCH] automake: add missing AC_MSG_RESULT calls to AM_SANITY_CHECK

Previous Next

Package: automake-patches;

Reported by: Richard Hansen <rhansen <at> rhansen.org>

Date: Thu, 20 Feb 2025 23:30:03 UTC

Severity: normal

Tags: patch

Done: Karl Berry <karl <at> freefriends.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Karl Berry <karl <at> freefriends.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76448: closed ([PATCH] automake: add missing AC_MSG_RESULT
 calls to AM_SANITY_CHECK)
Date: Thu, 20 Feb 2025 23:45:03 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 20 Feb 2025 16:44:06 -0700
with message-id <202502202344.51KNi62J706103 <at> freefriends.org>
and subject line Re: [bug#76448] [PATCH] automake: add missing AC_MSG_RESULT calls to AM_SANITY_CHECK
has caused the debbugs.gnu.org bug report #76448,
regarding [PATCH] automake: add missing AC_MSG_RESULT calls to AM_SANITY_CHECK
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76448: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76448
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Richard Hansen <rhansen <at> rhansen.org>
To: automake-patches <at> gnu.org
Subject: [PATCH] automake: add missing AC_MSG_RESULT calls to AM_SANITY_CHECK
Date: Thu, 20 Feb 2025 18:27:02 -0500
* m4/sanity.m4 (AM_SANITY_CHECK): Call AC_MSG_RESULT before erroring
out so that a complete line is printed to stdout before the error
message is written to stderr.
---
 m4/sanity.m4 | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/m4/sanity.m4 b/m4/sanity.m4
index 53538a873..be4b16113 100644
--- a/m4/sanity.m4
+++ b/m4/sanity.m4
@@ -169,10 +169,12 @@ am_lf='
 '
 case `pwd` in
   *[[\\\"\#\$\&\'\`$am_lf]]*)
+    AC_MSG_RESULT([no])
     AC_MSG_ERROR([unsafe absolute working directory name]);;
 esac
 case $srcdir in
   *[[\\\"\#\$\&\'\`$am_lf\ \	]]*)
+    AC_MSG_RESULT([no])
     AC_MSG_ERROR([unsafe srcdir value: '$srcdir']);;
 esac
 
-- 
2.48.1



[Message part 3 (message/rfc822, inline)]
From: Karl Berry <karl <at> freefriends.org>
To: rhansen <at> rhansen.org
Cc: 76448 <at> debbugs.gnu.org
Subject: Re: [bug#76448] [PATCH] automake: add missing AC_MSG_RESULT calls to
 AM_SANITY_CHECK
Date: Thu, 20 Feb 2025 16:44:06 -0700
    * m4/sanity.m4 (AM_SANITY_CHECK): Call AC_MSG_RESULT before erroring
    out so that a complete line is printed to stdout before the error
    message is written to stderr.

I pushed this. (surprisingly, no tests failed for me. :)
Thanks Richard.


This bug report was last modified 90 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.