GNU bug report logs - #76448
[PATCH] automake: add missing AC_MSG_RESULT calls to AM_SANITY_CHECK

Previous Next

Package: automake-patches;

Reported by: Richard Hansen <rhansen <at> rhansen.org>

Date: Thu, 20 Feb 2025 23:30:03 UTC

Severity: normal

Tags: patch

Done: Karl Berry <karl <at> freefriends.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76448 in the body.
You can then email your comments to 76448 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to automake-patches <at> gnu.org:
bug#76448; Package automake-patches. (Thu, 20 Feb 2025 23:30:04 GMT) Full text and rfc822 format available.
Acknowledgement sent to Richard Hansen <rhansen <at> rhansen.org>:
New bug report received and forwarded. Copy sent to automake-patches <at> gnu.org. (Thu, 20 Feb 2025 23:30:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Hansen <rhansen <at> rhansen.org>
To: automake-patches <at> gnu.org
Subject: [PATCH] automake: add missing AC_MSG_RESULT calls to AM_SANITY_CHECK
Date: Thu, 20 Feb 2025 18:27:02 -0500

* m4/sanity.m4 (AM_SANITY_CHECK): Call AC_MSG_RESULT before erroring
out so that a complete line is printed to stdout before the error
message is written to stderr.
---
 m4/sanity.m4 | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/m4/sanity.m4 b/m4/sanity.m4
index 53538a873..be4b16113 100644
--- a/m4/sanity.m4
+++ b/m4/sanity.m4
@@ -169,10 +169,12 @@ am_lf='
 '
 case `pwd` in
   *[[\\\"\#\$\&\'\`$am_lf]]*)
+    AC_MSG_RESULT([no])
     AC_MSG_ERROR([unsafe absolute working directory name]);;
 esac
 case $srcdir in
   *[[\\\"\#\$\&\'\`$am_lf\ \	]]*)
+    AC_MSG_RESULT([no])
     AC_MSG_ERROR([unsafe srcdir value: '$srcdir']);;
 esac
 
-- 
2.48.1
Information forwarded to automake-patches <at> gnu.org:
bug#76448; Package automake-patches. (Thu, 20 Feb 2025 23:45:02 GMT) Full text and rfc822 format available.

Message #8 received at 76448 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: rhansen <at> rhansen.org
Cc: 76448 <at> debbugs.gnu.org
Subject: Re: [bug#76448] [PATCH] automake: add missing AC_MSG_RESULT calls to
 AM_SANITY_CHECK
Date: Thu, 20 Feb 2025 16:44:06 -0700

    * m4/sanity.m4 (AM_SANITY_CHECK): Call AC_MSG_RESULT before erroring
    out so that a complete line is printed to stdout before the error
    message is written to stderr.

I pushed this. (surprisingly, no tests failed for me. :)
Thanks Richard.
Reply sent to Karl Berry <karl <at> freefriends.org>:
You have taken responsibility. (Thu, 20 Feb 2025 23:45:03 GMT) Full text and rfc822 format available.
Notification sent to Richard Hansen <rhansen <at> rhansen.org>:
bug acknowledged by developer. (Thu, 20 Feb 2025 23:45:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 21 Mar 2025 11:24:16 GMT) Full text and rfc822 format available.
This bug report was last modified 90 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.