GNU bug report logs - #76439
[PATCH] Specify 'tab-bar-history-mode' in 'winner-mode' docstring

Previous Next

Full log

Message #68 received at 76439 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 76439 <at> debbugs.gnu.org, juri <at> linkov.net, visuweshm <at> gmail.com
Subject: Re: bug#76439: [PATCH] Specify 'tab-bar-history-mode' in
 'winner-mode' docstring
Date: Fri, 21 Feb 2025 13:41:37 +0200

> From: Robert Pluim <rpluim <at> gmail.com>
> Cc: Visuwesh <visuweshm <at> gmail.com>,  76439 <at> debbugs.gnu.org,  juri <at> linkov.net
> Date: Fri, 21 Feb 2025 10:26:46 +0100
> 
> >>>>> On Fri, 21 Feb 2025 09:43:58 +0200, Eli Zaretskii <eliz <at> gnu.org> said:
>     >> 
>     >> If you indent to use `tab-bar-mode' with `winner-mode', we recommend
>     >> to use `tab-bar-history-mode' instead which provides tab-specific
>     >> window configuration history and is better behaved when
>     >> `tab-bar-mode' is turned on.
>     >> 
>     >> ?
> 
>     Eli> SGTM, thanks.
> 
> Grammar/gerund alert:
> 
>     If you indent to use `tab-bar-mode' with `winner-mode', we recommend
>     using `tab-bar-history-mode' instead, which provides tab-specific
>     window configuration history, and is better behaved when
>     `tab-bar-mode' is turned on.
> 
> (Iʼd even be tempted to use ';' instead of the second ',', and replace
> 'which' with 'it')

OK for the addition of commas, but I don't think we should use the
second proposal: the sentence reads better and more logically in its
above form.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.