GNU bug report logs - #76439
[PATCH] Specify 'tab-bar-history-mode' in 'winner-mode' docstring

Previous Next

Full log

Message #65 received at 76439 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Stephen Berman <stephen.berman <at> gmx.net>,
 76439 <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#76439: [PATCH] Specify 'tab-bar-history-mode' in
 'winner-mode' docstring
Date: Fri, 21 Feb 2025 16:35:07 +0530

[Message part 1 (text/plain, inline)]

[வெள்ளி பிப்ரவரி 21, 2025] Robert Pluim wrote:

Thanks for thoroughly checking.

>>>>>> On Fri, 21 Feb 2025 16:05:03 +0530, Visuwesh <visuweshm <at> gmail.com> said:
>     Visuwesh> -deletes the button."
>     Visuwesh> +deletes the button.
>     Visuwesh> +
>     Visuwesh> +If you intend to use `tab-bar-mode' with `winner-mode', we recommend to
>     Visuwesh> +use `tab-bar-history-mode' instead, since it provides tab-specific
>     Visuwesh> +window configuration history, and is better behaved when `tab-bar-mode'
>     Visuwesh> +is turned on."
>
> "we recommend using"
>
>     Visuwesh>    :global t
>     Visuwesh>    ;; It's defined in C/cus-start, this stops the d-m-m macro defining it again.
>     Visuwesh>    :variable tab-bar-mode
>     Visuwesh> diff --git a/lisp/winner.el b/lisp/winner.el
>     Visuwesh> index e56ddf92965..e56e7268727 100644
>     Visuwesh> --- a/lisp/winner.el
>     Visuwesh> +++ b/lisp/winner.el
>     Visuwesh> @@ -345,7 +345,13 @@ winner-mode
>     Visuwesh>  into windows) so that the changes can be \"undone\" using the
>     Visuwesh>  command `winner-undo'.  By default this one is bound to the key
>     Visuwesh>  sequence \\`C-c <left>'.  If you change your mind (while undoing),
>     Visuwesh> -you can press \\`C-c <right>' (calling `winner-redo')."
>     Visuwesh> +you can press \\`C-c <right>' (calling `winner-redo').
>     Visuwesh> +
>     Visuwesh> +If you use `tab-bar-mode', consider using `tab-bar-history-mode' as
>
> and here we could put a comma before "as"

I've left this part out since I feel the sentence has a different
meaning with this comma.

[0001-Recommend-tab-bar-history-mode-over-winner-mode.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.