GNU bug report logs - #76439
[PATCH] Specify 'tab-bar-history-mode' in 'winner-mode' docstring

Previous Next

Package: emacs;

Reported by: Visuwesh <visuweshm <at> gmail.com>

Date: Thu, 20 Feb 2025 14:52:03 UTC

Severity: normal

Tags: patch

Fixed in version 31.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log

Message #41 received at 76439 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Visuwesh <visuweshm <at> gmail.com>,
 76439 <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#76439: [PATCH] Specify 'tab-bar-history-mode' in
 'winner-mode' docstring
Date: Fri, 21 Feb 2025 10:53:23 +0100

>>>>> On Fri, 21 Feb 2025 10:41:23 +0100, Stephen Berman <stephen.berman <at> gmx.net> said:

    Stephen> On Fri, 21 Feb 2025 10:26:46 +0100 Robert Pluim <rpluim <at> gmail.com> wrote:
    >>>>>>> On Fri, 21 Feb 2025 09:43:58 +0200, Eli Zaretskii <eliz <at> gnu.org> said:
    >> >> 
    >> >> If you indent to use `tab-bar-mode' with `winner-mode', we recommend
    >> >> to use `tab-bar-history-mode' instead which provides tab-specific
    >> >> window configuration history and is better behaved when
    >> >> `tab-bar-mode' is turned on.
    >> >> 
    >> >> ?
    >> 
    Eli> SGTM, thanks.
    >> 
    >> Grammar/gerund alert:
    >> 
    >> If you indent to use `tab-bar-mode' with `winner-mode', we recommend

    Stephen> s/indent/intend/

The golden rule of grammar discussion is that there will be spelling
mistakes (and vice-versa) 😉

    >> using `tab-bar-history-mode' instead, which provides tab-specific
    >> window configuration history, and is better behaved when
    >> `tab-bar-mode' is turned on.
    >> 
    >> (Iʼd even be tempted to use ';' instead of the second ',', and replace
    >> 'which' with 'it')

    Stephen> Or "instead, since it provides", since it's a justification of the
    Stephen> recommendation.

That works as well. Iʼm told that using ';' is falling out of favour,
since allegedly the youth of today donʼt understand it.

Robert
--
This bug report was last modified 84 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.