Package: guix-patches;
Reported by: Sughosha <sughosha <at> disroot.org>
Date: Tue, 18 Feb 2025 17:52:03 UTC
Severity: normal
Tags: patch
Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Bug is archived. No further changes may be made.
Message #32 received at 76400 <at> debbugs.gnu.org (full text, mbox):
From: Liliana Marie Prikler <liliana.prikler <at> gmail.com> To: Sughosha <sughosha <at> disroot.org>, 76400 <at> debbugs.gnu.org Subject: Re: [PATCH v2 4/4] gnu: plasma: Re-order propageated-inputs. Date: Sun, 23 Mar 2025 18:17:17 +0100
Am Sonntag, dem 23.02.2025 um 08:22 +0530 schrieb Sughosha: > * gnu/packages/kde-plasma.scm (plasma)[propagated-inputs]: Re-order. > > Change-Id: I809649e6e68f29307c8261d14dbb2838c8916e19 > --- > gnu/packages/kde-plasma.scm | 74 ++++++++++++++++++----------------- > -- > 1 file changed, 37 insertions(+), 37 deletions(-) > > diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde- > plasma.scm > index 40f2fce510..3f28957f80 100644 > --- a/gnu/packages/kde-plasma.scm > +++ b/gnu/packages/kde-plasma.scm > @@ -1693,53 +1693,64 @@ (define-public plasma > (list #:builder #~(begin > (mkdir #$output)))) > ;; TODO: cleanup, check what is no need > - (propagated-inputs (list kdeclarative ;; require by sddm breeze > theme > - plasma5support ;; require by sddm > breeze theme > - qt5compat ;; require by sddm breeze > theme > - kiconthemes ;; require by sddm breeze > theme > - ksvg ;; require by sddm breeze theme > - qqc2-desktop-style ; qtquickcontrols2 > theme > - ocean-sound-theme > - qtdeclarative > - qtsvg ;; for svg support > - qtbase ;; why? > - baloo > - breeze-icons ; default mouse icon > + (propagated-inputs (list baloo > + bluedevil > breeze > breeze-gtk > - layer-shell-qt > + breeze-icons ; default mouse icon > + discover > drkonqi > kactivitymanagerd ; require this run > dbus > + kdeclarative ;; require by sddm breeze > theme Note: it's "required". Also, single semicolons are preferable for line comments. If you use emacs, M-; should do what you mean :) > kde-cli-tools > kdecoration > + kde-gtk-config > kdeplasma-addons > + kglobalaccel > + kglobalacceld > + kiconthemes ;; require by sddm breeze > theme Likewise… and so on for the rest. > + kinfocenter > + kmenuedit > kpmcore > - ktexteditor > - kscreen > - libkscreen > krdp > + kscreen > + kscreenlocker > + ksshaskpass > + ksvg ;; require by sddm breeze theme > ksystemstats > + ktexteditor > kwallet > kwalletmanager > kwallet-pam > kwin > - plasma-workspace-wallpapers > + layer-shell-qt > + libkscreen > libksysguard > milou > + ocean-sound-theme > oxygen-sounds > - qqc2-breeze-style > - kde-gtk-config > - kinfocenter > - kscreenlocker > - ksshaskpass > - discover > - kmenuedit > partitionmanager > - plasma-welcome > + plasma5support ;; require by sddm > breeze theme > plasma-browser-integration > plasma-desktop > plasma-disks > + plasma-firewall > + plasma-integration > + plasma-nm > + plasma-pa > + plasma-systemmonitor > + plasma-vault > + plasma-welcome > + plasma-workspace > + plasma-workspace-wallpapers > polkit-kde-agent > + powerdevil > + qqc2-breeze-style > + qqc2-desktop-style ; qtquickcontrols2 > theme > + qt5compat ;; require by sddm breeze > theme > + qtbase ;; why? > + qtdeclarative > + qtsvg ;; for svg support > system-settings > xdg-desktop-portal-kde > ;; module cyclic referencing > @@ -1754,19 +1765,8 @@ (define-public plasma > (module-ref > (resolve-interface > '(gnu packages kde-systemtools)) > - 'spectacle) > - plasma-firewall > - plasma-integration > - plasma-nm > - plasma-pa > - plasma-systemmonitor > - bluedevil > + 'spectacle))) > ;; plasma-thunderbolt ;; waiting for > bolt > - kglobalaccel > - kglobalacceld > - plasma-vault > - plasma-workspace > - powerdevil)) > (synopsis "The KDE Plasma desktop environment") > (home-page "https://kde.org/plasma-desktop/") > (description Other than that LGTM. Since you're soloing kde-team at the moment, feel free to push. Cheers
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.