GNU bug report logs - #76399
[PATCH] Change 'fullscreen' references to 'maximized'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76399 in the body.
You can then email your comments to 76399 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Change 'fullscreen' references to 'maximized'
Date: Tue, 18 Feb 2025 12:48:46 -0500

[Message part 1 (text/plain, inline)]

In frame.el's toggle-frame-fullscreen and toggle-frame-maximized, these
look like either typos, or vestigial references.  The frame-parameter
fullscreen is never set to 'fullscreen nor is the value 'fullscreen used in
other places in Emacs.  It is an undocumented value, appearing nowhere.
Unless I missed something.

I reviewed below sources and relevant headers:

android.c
androidfns.c
androidterm.c
emacs.c
frame.c
gtkutil.c
haikufns.c
haikuterm.c
pgtkfns.c
pgtkterm.c
term.c
w32fns.c
w32term.c
xfns.c
xmenu.c
xterm.c
nsfns.m
nsterm.m

-Stephane

[Message part 2 (text/html, inline)]

[0001-Change-fullscreen-references-to-maximized.patch (application/octet-stream, attachment)]

Message #8 received at 76399 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: 76399 <at> debbugs.gnu.org
Subject: Re: bug#76399: [PATCH] Change 'fullscreen' references to 'maximized'
Date: Tue, 18 Feb 2025 14:37:38 -0500

[Message part 1 (text/plain, inline)]

I did just find two references to 'fullscreen used as an alias to
'fullboth, but it's not documented and not implemented in all front ends
so its use is not portable.  I suggest we remove these or we document it
and correct all the front ends.  It looks like copy pasta, rather than by
intent.

pgtkfns.c:

static Lisp_Object
frame_geometry (Lisp_Object frame, Lisp_Object attribute)
{
  struct frame *f = decode_live_frame (frame);
  Lisp_Object fullscreen_symbol = Fframe_parameter (frame, Qfullscreen);
  bool fullscreen = (EQ (fullscreen_symbol, Qfullboth)
    || EQ (fullscreen_symbol, Qfullscreen));

nsfns.m:

static Lisp_Object
frame_geometry (Lisp_Object frame, Lisp_Object attribute)
{
  struct frame *f = decode_live_frame (frame);
  Lisp_Object fullscreen_symbol = Fframe_parameter (frame, Qfullscreen);
  bool fullscreen = (EQ (fullscreen_symbol, Qfullboth)
    || EQ (fullscreen_symbol, Qfullscreen));

On Tue, Feb 18, 2025 at 12:50 PM Ship Mints <shipmints <at> gmail.com> wrote:

> In frame.el's toggle-frame-fullscreen and toggle-frame-maximized, these
> look like either typos, or vestigial references.  The frame-parameter
> fullscreen is never set to 'fullscreen nor is the value 'fullscreen used in
> other places in Emacs.  It is an undocumented value, appearing nowhere.
> Unless I missed something.
>
> I reviewed below sources and relevant headers:
>
> android.c
> androidfns.c
> androidterm.c
> emacs.c
> frame.c
> gtkutil.c
> haikufns.c
> haikuterm.c
> pgtkfns.c
> pgtkterm.c
> term.c
> w32fns.c
> w32term.c
> xfns.c
> xmenu.c
> xterm.c
> nsfns.m
> nsterm.m
>
> -Stephane
>

[Message part 2 (text/html, inline)]

Message #13 received at 76399 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ship Mints <shipmints <at> gmail.com>,
 martin rudalics <rudalics <at> gmx.at>
Cc: 76399 <at> debbugs.gnu.org
Subject: Re: bug#76399: [PATCH] Change 'fullscreen' references to 'maximized'
Date: Wed, 19 Feb 2025 13:52:38 +0200

> From: Ship Mints <shipmints <at> gmail.com>
> Date: Tue, 18 Feb 2025 12:48:46 -0500
> 
> In frame.el's toggle-frame-fullscreen and toggle-frame-maximized, these look like either typos, or vestigial
> references.  The frame-parameter fullscreen is never set to 'fullscreen nor is the value 'fullscreen used in
> other places in Emacs.  It is an undocumented value, appearing nowhere.  Unless I missed something.
> 
> I reviewed below sources and relevant headers:
> 
> android.c
> androidfns.c
> androidterm.c
> emacs.c
> frame.c
> gtkutil.c
> haikufns.c
> haikuterm.c
> pgtkfns.c
> pgtkterm.c
> term.c
> w32fns.c
> w32term.c
> xfns.c
> xmenu.c
> xterm.c
> nsfns.m
> nsterm.m

Martin, any comments?

Message #16 received at 76399 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Eli Zaretskii <eliz <at> gnu.org>, Ship Mints <shipmints <at> gmail.com>
Cc: 76399 <at> debbugs.gnu.org
Subject: Re: bug#76399: [PATCH] Change 'fullscreen' references to 'maximized'
Date: Wed, 19 Feb 2025 18:28:47 +0100

>> In frame.el's toggle-frame-fullscreen and toggle-frame-maximized, these look like either typos, or vestigial
>> references.  The frame-parameter fullscreen is never set to 'fullscreen nor is the value 'fullscreen used in
>> other places in Emacs.  It is an undocumented value, appearing nowhere.  Unless I missed something.
[---]
> Martin, any comments?

I can only speculate.  Jan changed the semantics in 2009 so the previous
'fullscreen' became 'maximized' or 'fullboth' - I don't remember which.
For compatibility sake, he kept 'fullscreen' around since people might
have had (and maybe still have) it in their init files.  It's no more
documented to avoid that people start using it.

In either case 'fullscreen' still is a valid substitute for 'fullboth'.
Try with

(set-frame-parameter nil 'fullscreen 'fullscreen)

martin

Message #19 received at 76399 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76399 <at> debbugs.gnu.org
Subject: Re: bug#76399: [PATCH] Change 'fullscreen' references to 'maximized'
Date: Wed, 19 Feb 2025 12:32:06 -0500

[Message part 1 (text/plain, inline)]

I tried to tease out the history and I'm glad you have a good memory.

If the fullscreen alias is to be maintained, should we correct the rest of
the code that doesn't support it?

On Wed, Feb 19, 2025 at 12:29 PM martin rudalics <rudalics <at> gmx.at> wrote:

>  >> In frame.el's toggle-frame-fullscreen and toggle-frame-maximized,
> these look like either typos, or vestigial
>  >> references.  The frame-parameter fullscreen is never set to
> 'fullscreen nor is the value 'fullscreen used in
>  >> other places in Emacs.  It is an undocumented value, appearing
> nowhere.  Unless I missed something.
> [---]
>  > Martin, any comments?
>
> I can only speculate.  Jan changed the semantics in 2009 so the previous
> 'fullscreen' became 'maximized' or 'fullboth' - I don't remember which.
> For compatibility sake, he kept 'fullscreen' around since people might
> have had (and maybe still have) it in their init files.  It's no more
> documented to avoid that people start using it.
>
> In either case 'fullscreen' still is a valid substitute for 'fullboth'.
> Try with
>
> (set-frame-parameter nil 'fullscreen 'fullscreen)
>
> martin
>

[Message part 2 (text/html, inline)]

Message #22 received at 76399 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Ship Mints <shipmints <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76399 <at> debbugs.gnu.org
Subject: Re: bug#76399: [PATCH] Change 'fullscreen' references to 'maximized'
Date: Wed, 19 Feb 2025 19:15:11 +0100

> If the fullscreen alias is to be maintained, should we correct the rest of
> the code that doesn't support it?

What would you like to correct, for example?  AFAICT we didn't have any
bug reports in this area so I'd rather let sleeping dogs lie.

martin

Message #25 received at 76399 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76399 <at> debbugs.gnu.org
Subject: Re: bug#76399: [PATCH] Change 'fullscreen' references to 'maximized'
Date: Wed, 19 Feb 2025 13:17:22 -0500

[Message part 1 (text/plain, inline)]

For the sake of completeness.  We can address this if a dog barks.  There's
now a bug reference for it.

On Wed, Feb 19, 2025 at 1:15 PM martin rudalics <rudalics <at> gmx.at> wrote:

>  > If the fullscreen alias is to be maintained, should we correct the rest
> of
>  > the code that doesn't support it?
>
> What would you like to correct, for example?  AFAICT we didn't have any
> bug reports in this area so I'd rather let sleeping dogs lie.
>
> martin
>

[Message part 2 (text/html, inline)]

Message #28 received at 76399 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Ship Mints <shipmints <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76399 <at> debbugs.gnu.org
Subject: Re: bug#76399: [PATCH] Change 'fullscreen' references to 'maximized'
Date: Wed, 19 Feb 2025 19:35:12 +0100

> For the sake of completeness.  We can address this if a dog barks.  There's
> now a bug reference for it.

Sorry, I missed your patch till now.  Renaming 'fullscreen' to
'maximized' is wrong.  'fullscreen' is an alias for 'fullboth'.  In
gui_set_fullscreen we have

  else if (EQ (new_value, Qfullboth) || EQ (new_value, Qfullscreen))
    f->want_fullscreen = FULLSCREEN_BOTH;

martin

Message #31 received at 76399 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76399 <at> debbugs.gnu.org
Subject: Re: bug#76399: [PATCH] Change 'fullscreen' references to 'maximized'
Date: Wed, 19 Feb 2025 13:47:08 -0500

[Message part 1 (text/plain, inline)]

I misread things.  Thanks to your better eyes.

On Wed, Feb 19, 2025 at 1:35 PM martin rudalics <rudalics <at> gmx.at> wrote:

>  > For the sake of completeness.  We can address this if a dog barks.
> There's
>  > now a bug reference for it.
>
> Sorry, I missed your patch till now.  Renaming 'fullscreen' to
> 'maximized' is wrong.  'fullscreen' is an alias for 'fullboth'.  In
> gui_set_fullscreen we have
>
>    else if (EQ (new_value, Qfullboth) || EQ (new_value, Qfullscreen))
>      f->want_fullscreen = FULLSCREEN_BOTH;
>
> martin
>

[Message part 2 (text/html, inline)]

Message #34 received at 76399 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76399 <at> debbugs.gnu.org
Subject: Re: bug#76399: [PATCH] Change 'fullscreen' references to 'maximized'
Date: Wed, 19 Feb 2025 14:39:00 -0500

[Message part 1 (text/plain, inline)]

Please close this bug.

On Wed, Feb 19, 2025 at 1:47 PM Ship Mints <shipmints <at> gmail.com> wrote:

> I misread things.  Thanks to your better eyes.
>
> On Wed, Feb 19, 2025 at 1:35 PM martin rudalics <rudalics <at> gmx.at> wrote:
>
>>  > For the sake of completeness.  We can address this if a dog barks.
>> There's
>>  > now a bug reference for it.
>>
>> Sorry, I missed your patch till now.  Renaming 'fullscreen' to
>> 'maximized' is wrong.  'fullscreen' is an alias for 'fullboth'.  In
>> gui_set_fullscreen we have
>>
>>    else if (EQ (new_value, Qfullboth) || EQ (new_value, Qfullscreen))
>>      f->want_fullscreen = FULLSCREEN_BOTH;
>>
>> martin
>>
>

[Message part 2 (text/html, inline)]

Message #39 received at 76399-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Ship Mints <shipmints <at> gmail.com>, martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76399-done <at> debbugs.gnu.org
Subject: Re: bug#76399: [PATCH] Change 'fullscreen' references to 'maximized'
Date: Thu, 20 Feb 2025 00:21:45 +0000

Ship Mints <shipmints <at> gmail.com> writes:

> Please close this bug.

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.