GNU bug report logs - #76372
31.0.50; False () in ert-font-lock macro signatures

Previous Next

Full log

Message #19 received at control <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <basil <at> contovou.net>
To: Vladimir Kazanov <vekazanov <at> gmail.com>
Cc: 76372 <at> debbugs.gnu.org
Subject: Re: bug#76372: 31.0.50; False () in ert-font-lock macro signatures
Date: Thu, 20 Feb 2025 10:53:28 +0100

[Message part 1 (text/plain, inline)]

found 76372 30.0.93
quit

Vladimir Kazanov [2025-02-20 08:23 +0000] wrote:

> Feel free to push,

I was about to, but then it occurred to me that ert-font-lock is new in
Emacs 30.

Perhaps the docstring fixes at least should go to emacs-30 instead of
master?

If Eli/Stefan/Andrea agree, I propose the first patch for emacs-30, and
the second for master (they just separate the documentation/test changes
from those to code).

To recap, the main issue in this report is that the arglist of
ert-font-lock-deftest and ert-font-lock-deftest-file is misrepresented
in their documentation and declare specs, which can lead to minor
confusion, misindentation, and misfontification.

> Thanks for looking into this!

Thank *you* for the neat feature and review!
-- 
Basil

[0001-Fix-ert-font-lock-macro-signatures.patch (text/x-diff, attachment)]

[0002-Clean-up-ert-font-lock-error-messages.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.