GNU bug report logs - #76372
31.0.50; False () in ert-font-lock macro signatures

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76372 in the body.
You can then email your comments to 76372 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <basil <at> contovou.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; False () in ert-font-lock macro signatures
Date: Mon, 17 Feb 2025 21:37:06 +0100

[Message part 1 (text/plain, inline)]

0. emacs -Q
1. C-h f ert-font-lock-deftest RET

*Help* now reports the macro's calling convention as:

  (ert-font-lock-deftest NAME () [DOCSTRING] ...)

but the second () argument is not actually supported by the macro, whose
arglist reads:

  (name &rest docstring-keys-mode-and-str)

Here, ert-font-lock--parse-macro-args expects
docstring-keys-mode-and-str to start with an (optional) string,
not the empty arglist '().

The symptom of this mismatch is that calls to ert-font-lock-deftest are
misindented (malindented? :) and misfontified.  For example, in
ert-font-lock-tests.el:

  (ert-font-lock-deftest test-macro-test--correct-highlighting
      emacs-lisp-mode
    "
  (defun fun ())
  ;; ^ font-lock-keyword-face
  ;;      ^ font-lock-function-name-face")

Here, the string literal has font-lock-doc-face instead of
font-lock-string-face.

  (ert-font-lock-deftest test-macro-test--docstring
      "A test with a docstring."
    emacs-lisp-mode
    "
  (defun fun ())
  ;; ^ font-lock-keyword-face"
    )

Here, both strings have font-lock-string-face, whereas the first should
have font-lock-doc-face.

Finally, if a test actually followed ert-font-lock-deftest's docstring
in including an empty arglist (), then ert-describe-test would claim
that it is not documented.

The attached patch tries to address these issues.
WDYT?

Thanks,
-- 
Basil

[0001-Fix-ert-font-lock-macro-signatures.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.18.2, Xaw3d scroll bars) of 2025-02-16 built on tais
Repository revision: fc189cb83cf7284344a737e75b3ee56487b1c386
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101015
System Description: Debian GNU/Linux trixie/sid

Configured using:
 'configure 'CFLAGS=-Og -ggdb3' -C --prefix=/home/blc/.local
 --enable-checking=structs --without-native-compilation
 --with-file-notification --with-x-toolkit=lucid --with-x'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINERAMA XINPUT2
XPM XRANDR LUCID ZLIB

Important settings:
  value of $LANG: en_IE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils cl-extra shortdoc
text-property-search comp-common rx ert-font-lock pcase ert-x subr-x ert
map pp ewoc debug backtrace find-func thingatpt help-fns byte-opt gv
bytecomp byte-compile radix-tree help-mode cl-loaddefs cl-lib rmc
iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt
fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode
register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting cairo x-toolkit xinput2 x multi-tty move-toolbar
make-network-process tty-child-frames emacs)

Memory information:
((conses 16 75191 9165) (symbols 48 7566 0) (strings 32 22214 1377)
 (string-bytes 1 522717) (vectors 16 13949)
 (vector-slots 8 148704 7756) (floats 8 87 2) (intervals 56 318 7)
 (buffers 992 11))

Message #8 received at 76372 <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Kazanov <vekazanov <at> gmail.com>
To: "Basil L. Contovounesios" <basil <at> contovou.net>
Cc: 76372 <at> debbugs.gnu.org
Subject: Re: bug#76372: 31.0.50; False () in ert-font-lock macro signatures
Date: Tue, 18 Feb 2025 19:41:08 +0000

Hi Basil,

Thanks for taking a look at ert-font-lock! I am on vacation right now
so only have time for a brief review of the patch.

So here are a couple of comments/questions for the patch:

-      (when (not (listp actual-face))
-        (setq actual-face (list actual-face)))
-      (when (not (listp expected-face))
-        (setq expected-face (list expected-face)))
+      (setq actual-face (ensure-list actual-face))
+      (setq expected-face (ensure-list expected-face))

This is cool!

-     (insert ,str)
      (,mode)
+     (insert ,str)

Not saying this is wrong but looks like something that might change
things subtly. Do tests pass?

> -  (skip-unless (featurep 'php-mode))
> +  (skip-unless (fboundp 'php-mode))

What difference does it make? featurep vs fboundp?

> -    "Test reading correct assertions from a file"
> +  "Test reading correct assertions from a file"

Similar to other docstrings, this asks for a period in the end.

Otherwise, great to see my rusty Elisp and non-native English cleaned up a bit.

Thanks
Vlad

On Mon, 17 Feb 2025 at 20:38, Basil L. Contovounesios
<basil <at> contovou.net> wrote:
>
> 0. emacs -Q
> 1. C-h f ert-font-lock-deftest RET
>
> *Help* now reports the macro's calling convention as:
>
>   (ert-font-lock-deftest NAME () [DOCSTRING] ...)
>
> but the second () argument is not actually supported by the macro, whose
> arglist reads:
>
>   (name &rest docstring-keys-mode-and-str)
>
> Here, ert-font-lock--parse-macro-args expects
> docstring-keys-mode-and-str to start with an (optional) string,
> not the empty arglist '().
>
> The symptom of this mismatch is that calls to ert-font-lock-deftest are
> misindented (malindented? :) and misfontified.  For example, in
> ert-font-lock-tests.el:
>
>   (ert-font-lock-deftest test-macro-test--correct-highlighting
>       emacs-lisp-mode
>     "
>   (defun fun ())
>   ;; ^ font-lock-keyword-face
>   ;;      ^ font-lock-function-name-face")
>
> Here, the string literal has font-lock-doc-face instead of
> font-lock-string-face.
>
>   (ert-font-lock-deftest test-macro-test--docstring
>       "A test with a docstring."
>     emacs-lisp-mode
>     "
>   (defun fun ())
>   ;; ^ font-lock-keyword-face"
>     )
>
> Here, both strings have font-lock-string-face, whereas the first should
> have font-lock-doc-face.
>
> Finally, if a test actually followed ert-font-lock-deftest's docstring
> in including an empty arglist (), then ert-describe-test would claim
> that it is not documented.
>
> The attached patch tries to address these issues.
> WDYT?
>
> Thanks,
> --
> Basil
>
>
> In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
>  version 1.18.2, Xaw3d scroll bars) of 2025-02-16 built on tais
> Repository revision: fc189cb83cf7284344a737e75b3ee56487b1c386
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.12101015
> System Description: Debian GNU/Linux trixie/sid
>
> Configured using:
>  'configure 'CFLAGS=-Og -ggdb3' -C --prefix=/home/blc/.local
>  --enable-checking=structs --without-native-compilation
>  --with-file-notification --with-x-toolkit=lucid --with-x'
>
> Configured features:
> ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
> LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
> INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
> TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINERAMA XINPUT2
> XPM XRANDR LUCID ZLIB
>
> Important settings:
>   value of $LANG: en_IE.UTF-8
>   locale-coding-system: utf-8-unix
>
> Major mode: Lisp Interaction
>
> Minor modes in effect:
>   tooltip-mode: t
>   global-eldoc-mode: t
>   eldoc-mode: t
>   show-paren-mode: t
>   electric-indent-mode: t
>   mouse-wheel-mode: t
>   tool-bar-mode: t
>   menu-bar-mode: t
>   file-name-shadow-mode: t
>   global-font-lock-mode: t
>   font-lock-mode: t
>   blink-cursor-mode: t
>   minibuffer-regexp-mode: t
>   line-number-mode: t
>   indent-tabs-mode: t
>   transient-mark-mode: t
>   auto-composition-mode: t
>   auto-encryption-mode: t
>   auto-compression-mode: t
>
> Load-path shadows:
> None found.
>
> Features:
> (shadow sort mail-extr emacsbug message mailcap yank-media puny dired
> dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
> epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse
> rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
> ietf-drums mm-util mail-prsvr mail-utils cl-extra shortdoc
> text-property-search comp-common rx ert-font-lock pcase ert-x subr-x ert
> map pp ewoc debug backtrace find-func thingatpt help-fns byte-opt gv
> bytecomp byte-compile radix-tree help-mode cl-loaddefs cl-lib rmc
> iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
> vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
> term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt
> fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode
> register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
> scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
> frame minibuffer nadvice seq simple cl-generic indonesian philippine
> cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
> korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
> european ethiopic indian cyrillic chinese composite emoji-zwj charscript
> charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
> cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
> files window text-properties overlay sha1 md5 base64 format env
> code-pages mule custom widget keymap hashtable-print-readable backquote
> threads dbusbind inotify lcms2 dynamic-setting system-font-setting
> font-render-setting cairo x-toolkit xinput2 x multi-tty move-toolbar
> make-network-process tty-child-frames emacs)
>
> Memory information:
> ((conses 16 75191 9165) (symbols 48 7566 0) (strings 32 22214 1377)
>  (string-bytes 1 522717) (vectors 16 13949)
>  (vector-slots 8 148704 7756) (floats 8 87 2) (intervals 56 318 7)
>  (buffers 992 11))



-- 
Regards,

Vladimir Kazanov

Message #11 received at 76372 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <basil <at> contovou.net>
To: Vladimir Kazanov <vekazanov <at> gmail.com>
Cc: 76372 <at> debbugs.gnu.org
Subject: Re: bug#76372: 31.0.50; False () in ert-font-lock macro signatures
Date: Wed, 19 Feb 2025 21:15:50 +0100

Vladimir Kazanov [2025-02-18 19:41 +0000] wrote:

> Thanks for taking a look at ert-font-lock! I am on vacation right now
> so only have time for a brief review of the patch.

No worries.
I hope you have a nice vacation, and thanks for taking a look anyway.

> -     (insert ,str)
>       (,mode)
> +     (insert ,str)
>
> Not saying this is wrong but looks like something that might change
> things subtly. Do tests pass?

Yes, tests still pass (modulo those that were already failing):

$ make check
$ make TEST_LOAD_EL=no \
       test/{autoconf,{go,lua,rust}-ts-mode,ert{,-x,-font-lock}}-tests

If this were a general-purpose macro required to be robust, I would have
used e.g. macroexp-let2 to ensure the correct argument evaluation order.

Since this is a convenience used only in tests, I thought I could get
away with being lazy, but you caught me ;).

>> -  (skip-unless (featurep 'php-mode))
>> +  (skip-unless (fboundp 'php-mode))
>
> What difference does it make? featurep vs fboundp?

featurep returns non-nil if the file php-mode.el has already been
loaded, whereas fboundp returns non-nil if the function php-mode is
defined (even as an autoload).

During 'make check' it doesn't make a difference, since php-mode is not
even installed, let alone defined as a function or feature.

But if someone has php-mode.el installed via package-install, then the
function php-mode is automatically autoloaded.  If the test tries to
call the function php-mode, Emacs will know which file to load in order
to find the function's real definition.  So it is not necessary to have
php-mode.el already loaded (which involves an extra step by the user);
it suffices to have the php-mode package installed properly in order to
run the test.

Regardless of these details, fboundp is a more accurate test-skip
condition because all the test is doing is calling a function called
php-mode; it does not care about where that function is defined, and
specifically whether it's defined by a feature called php-mode.

>> -    "Test reading correct assertions from a file"
>> +  "Test reading correct assertions from a file"
>
> Similar to other docstrings, this asks for a period in the end.

Well spotted, thanks.

I've updated the patch locally, and am ready to apply further feedback,
or push it if there are no further comments.

-- 
Basil

Message #14 received at 76372 <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Kazanov <vekazanov <at> gmail.com>
To: "Basil L. Contovounesios" <basil <at> contovou.net>
Cc: 76372 <at> debbugs.gnu.org
Subject: Re: bug#76372: 31.0.50; False () in ert-font-lock macro signatures
Date: Thu, 20 Feb 2025 08:23:41 +0000

Feel free to push,

Thanks for looking into this!

On Wed, 19 Feb 2025 at 20:15, Basil L. Contovounesios
<basil <at> contovou.net> wrote:
>
> Vladimir Kazanov [2025-02-18 19:41 +0000] wrote:
>
> > Thanks for taking a look at ert-font-lock! I am on vacation right now
> > so only have time for a brief review of the patch.
>
> No worries.
> I hope you have a nice vacation, and thanks for taking a look anyway.
>
> > -     (insert ,str)
> >       (,mode)
> > +     (insert ,str)
> >
> > Not saying this is wrong but looks like something that might change
> > things subtly. Do tests pass?
>
> Yes, tests still pass (modulo those that were already failing):
>
> $ make check
> $ make TEST_LOAD_EL=no \
>        test/{autoconf,{go,lua,rust}-ts-mode,ert{,-x,-font-lock}}-tests
>
> If this were a general-purpose macro required to be robust, I would have
> used e.g. macroexp-let2 to ensure the correct argument evaluation order.
>
> Since this is a convenience used only in tests, I thought I could get
> away with being lazy, but you caught me ;).
>
> >> -  (skip-unless (featurep 'php-mode))
> >> +  (skip-unless (fboundp 'php-mode))
> >
> > What difference does it make? featurep vs fboundp?
>
> featurep returns non-nil if the file php-mode.el has already been
> loaded, whereas fboundp returns non-nil if the function php-mode is
> defined (even as an autoload).
>
> During 'make check' it doesn't make a difference, since php-mode is not
> even installed, let alone defined as a function or feature.
>
> But if someone has php-mode.el installed via package-install, then the
> function php-mode is automatically autoloaded.  If the test tries to
> call the function php-mode, Emacs will know which file to load in order
> to find the function's real definition.  So it is not necessary to have
> php-mode.el already loaded (which involves an extra step by the user);
> it suffices to have the php-mode package installed properly in order to
> run the test.
>
> Regardless of these details, fboundp is a more accurate test-skip
> condition because all the test is doing is calling a function called
> php-mode; it does not care about where that function is defined, and
> specifically whether it's defined by a feature called php-mode.
>
> >> -    "Test reading correct assertions from a file"
> >> +  "Test reading correct assertions from a file"
> >
> > Similar to other docstrings, this asks for a period in the end.
>
> Well spotted, thanks.
>
> I've updated the patch locally, and am ready to apply further feedback,
> or push it if there are no further comments.
>
> --
> Basil



-- 
Regards,

Vladimir Kazanov

Message #17 received at 76372 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <basil <at> contovou.net>
To: Vladimir Kazanov <vekazanov <at> gmail.com>
Cc: 76372 <at> debbugs.gnu.org
Subject: Re: bug#76372: 31.0.50; False () in ert-font-lock macro signatures
Date: Thu, 20 Feb 2025 10:53:28 +0100

[Message part 1 (text/plain, inline)]

found 76372 30.0.93
quit

Vladimir Kazanov [2025-02-20 08:23 +0000] wrote:

> Feel free to push,

I was about to, but then it occurred to me that ert-font-lock is new in
Emacs 30.

Perhaps the docstring fixes at least should go to emacs-30 instead of
master?

If Eli/Stefan/Andrea agree, I propose the first patch for emacs-30, and
the second for master (they just separate the documentation/test changes
from those to code).

To recap, the main issue in this report is that the arglist of
ert-font-lock-deftest and ert-font-lock-deftest-file is misrepresented
in their documentation and declare specs, which can lead to minor
confusion, misindentation, and misfontification.

> Thanks for looking into this!

Thank *you* for the neat feature and review!
-- 
Basil

[0001-Fix-ert-font-lock-macro-signatures.patch (text/x-diff, attachment)]

[0002-Clean-up-ert-font-lock-error-messages.patch (text/x-diff, attachment)]

Message #22 received at 76372 <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Kazanov <vekazanov <at> gmail.com>
To: "Basil L. Contovounesios" <basil <at> contovou.net>
Cc: 76372 <at> debbugs.gnu.org
Subject: Re: bug#76372: 31.0.50; False () in ert-font-lock macro signatures
Date: Mon, 24 Feb 2025 09:25:26 +0000

Hi Basil,

I guess we're not making it in time for emacs-30. So master it is. The
problem is inconvenient but not deal breaking for users.

On Thu, 20 Feb 2025 at 09:53, Basil L. Contovounesios
<basil <at> contovou.net> wrote:
>
> found 76372 30.0.93
> quit
>
> Vladimir Kazanov [2025-02-20 08:23 +0000] wrote:
>
> > Feel free to push,
>
> I was about to, but then it occurred to me that ert-font-lock is new in
> Emacs 30.
>
> Perhaps the docstring fixes at least should go to emacs-30 instead of
> master?
>
> If Eli/Stefan/Andrea agree, I propose the first patch for emacs-30, and
> the second for master (they just separate the documentation/test changes
> from those to code).
>
> To recap, the main issue in this report is that the arglist of
> ert-font-lock-deftest and ert-font-lock-deftest-file is misrepresented
> in their documentation and declare specs, which can lead to minor
> confusion, misindentation, and misfontification.
>
> > Thanks for looking into this!
>
> Thank *you* for the neat feature and review!
> --
> Basil
>


-- 
Regards,

Vladimir Kazanov

Message #25 received at 76372 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <basil <at> contovou.net>
To: Vladimir Kazanov <vekazanov <at> gmail.com>
Cc: 76372 <at> debbugs.gnu.org
Subject: Re: bug#76372: 31.0.50; False () in ert-font-lock macro signatures
Date: Mon, 24 Feb 2025 14:56:59 +0100

Vladimir Kazanov [2025-02-24 09:25 +0000] wrote:

> I guess we're not making it in time for emacs-30. So master it is. The
> problem is inconvenient but not deal breaking for users.

Not in time for 30.1, but still in time for 30.2, assuming the
maintainers agree.

> On Thu, 20 Feb 2025 at 09:53, Basil L. Contovounesios
> <basil <at> contovou.net> wrote:
>>
>> found 76372 30.0.93
>> quit
>>
>> Vladimir Kazanov [2025-02-20 08:23 +0000] wrote:
>>
>> > Feel free to push,
>>
>> I was about to, but then it occurred to me that ert-font-lock is new in
>> Emacs 30.
>>
>> Perhaps the docstring fixes at least should go to emacs-30 instead of
>> master?
>>
>> If Eli/Stefan/Andrea agree, I propose the first patch for emacs-30, and
>> the second for master (they just separate the documentation/test changes
>> from those to code).
>>
>> To recap, the main issue in this report is that the arglist of
>> ert-font-lock-deftest and ert-font-lock-deftest-file is misrepresented
>> in their documentation and declare specs, which can lead to minor
>> confusion, misindentation, and misfontification.

Thanks,
-- 
Basil

Message #28 received at 76372 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: "Basil L. Contovounesios" <basil <at> contovou.net>,
 Vladimir Kazanov <vekazanov <at> gmail.com>
Cc: 76372 <at> debbugs.gnu.org
Subject: Re: bug#76372: 31.0.50; False () in ert-font-lock macro signatures
Date: Mon, 24 Feb 2025 17:33:25 +0000

"Basil L. Contovounesios" <basil <at> contovou.net> writes:

> Vladimir Kazanov [2025-02-24 09:25 +0000] wrote:
>
>> I guess we're not making it in time for emacs-30. So master it is. The
>> problem is inconvenient but not deal breaking for users.
>
> Not in time for 30.1, but still in time for 30.2, assuming the
> maintainers agree.

No objection from me.

Message #31 received at 76372 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <basil <at> contovou.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Vladimir Kazanov <vekazanov <at> gmail.com>, 76372 <at> debbugs.gnu.org
Subject: Re: bug#76372: 31.0.50; False () in ert-font-lock macro signatures
Date: Tue, 25 Feb 2025 12:12:47 +0100

Stefan Kangas [2025-02-24 17:33 +0000] wrote:
> "Basil L. Contovounesios" <basil <at> contovou.net> writes:
>> Vladimir Kazanov [2025-02-24 09:25 +0000] wrote:
>>> I guess we're not making it in time for emacs-30. So master it is. The
>>> problem is inconvenient but not deal breaking for users.
>> Not in time for 30.1, but still in time for 30.2, assuming the
>> maintainers agree.
>
> No objection from me.

Thanks, pushed the first patch to emacs-30:

  Fix ert-font-lock macro signatures
  02c830ba22b 2025-02-25 11:02:55 +0100
  https://git.sv.gnu.org/cgit/emacs.git/commit/?id=02c830ba22b

I'll wait until that's merged to master before applying the second one.

-- 
Basil

Message #34 received at 76372 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: "Basil L. Contovounesios" <basil <at> contovou.net>
Cc: Vladimir Kazanov <vekazanov <at> gmail.com>, 76372 <at> debbugs.gnu.org
Subject: Re: bug#76372: 31.0.50; False () in ert-font-lock macro signatures
Date: Tue, 4 Mar 2025 02:40:21 +0000

"Basil L. Contovounesios" <basil <at> contovou.net> writes:

> Stefan Kangas [2025-02-24 17:33 +0000] wrote:
>> "Basil L. Contovounesios" <basil <at> contovou.net> writes:
>>> Vladimir Kazanov [2025-02-24 09:25 +0000] wrote:
>>>> I guess we're not making it in time for emacs-30. So master it is. The
>>>> problem is inconvenient but not deal breaking for users.
>>> Not in time for 30.1, but still in time for 30.2, assuming the
>>> maintainers agree.
>>
>> No objection from me.
>
> Thanks, pushed the first patch to emacs-30:
>
>   Fix ert-font-lock macro signatures
>   02c830ba22b 2025-02-25 11:02:55 +0100
>   https://git.sv.gnu.org/cgit/emacs.git/commit/?id=02c830ba22b
>
> I'll wait until that's merged to master before applying the second one.

It's merged now.

Message #41 received at 76372-done <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <basil <at> contovou.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Vladimir Kazanov <vekazanov <at> gmail.com>, 76372-done <at> debbugs.gnu.org
Subject: Re: bug#76372: 31.0.50; False () in ert-font-lock macro signatures
Date: Fri, 07 Mar 2025 16:14:21 +0100

close 76372 31.1
quit

Stefan Kangas [2025-03-04 02:40 +0000] wrote:
> "Basil L. Contovounesios" <basil <at> contovou.net> writes:
>> Thanks, pushed the first patch to emacs-30:
>>
>>   Fix ert-font-lock macro signatures
>>   02c830ba22b 2025-02-25 11:02:55 +0100
>>   https://git.sv.gnu.org/cgit/emacs.git/commit/?id=02c830ba22b
>>
>> I'll wait until that's merged to master before applying the second one.
>
> It's merged now.

Thank you.  Pushed the second patch, and closing.

  Clean up ert-font-lock error messages
  e62e7aa8990 2025-03-07 15:58:08 +0100
  https://git.sv.gnu.org/cgit/emacs.git/commit/?id=e62e7aa8990

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.