GNU bug report logs - #76351
[PATCH] gnu: Add emacs-nushell-mode.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76351 in the body.
You can then email your comments to 76351 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Skylar Hill <stellarskylark <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Skylar Hill <stellarskylark <at> posteo.net>
Subject: [PATCH] gnu: Add emacs-nushell-mode.
Date: Sun, 16 Feb 2025 20:06:17 +0000

* gnu/packages/emacs-xyz.scm (emacs-nushell-mode): New variable.

Change-Id: I216d8a9f7e7f89e379174a5d93020ff44c69d51f
---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c006f1d912..d2bdd7b52d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -35629,6 +35629,27 @@ (define-public emacs-ntlm
 implementation of Windows NT and LanManager compatible password encryption.")
     (license license:gpl3+)))
 
+(define-public emacs-nushell-mode
+  (package
+    (name "emacs-nushell-mode")
+    (version "20231204.1233")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/mrkkrp/nushell-mode.git")
+             (commit "c179c3cf573b2cc9421dc08bf47e2d619c7791ee")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "08kx31h22szvmccswwmhyj615c9fqln45darlfkj7q84dmc2fd3n"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/mrkkrp/nushell-mode")
+    (synopsis "Major mode for Nushell scripts")
+    (description
+     "This package provides a very basic version of major mode for Nushell shell
+scripts.")
+    (license license:gpl3+)))
+
 (define-public emacs-nadvice
   (package
     (name "emacs-nadvice")

base-commit: 6dde0ee30e5e030c2535514e9e39aa50518a5d20
prerequisite-patch-id: cc459efaf23197e58e97a6f0ad62058f71178746
prerequisite-patch-id: 492a9743436eae7679c7d9002f5b2d175eff9f1b
-- 
2.48.1

Message #8 received at 76351 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Skylar Hill <stellarskylark <at> posteo.net>
Cc: 76351 <at> debbugs.gnu.org
Subject: Re: [bug#76351] [PATCH] gnu: Add emacs-nushell-mode.
Date: Mon, 17 Feb 2025 10:14:07 -0800

Hi Skylar,

Skylar Hill <stellarskylark <at> posteo.net> writes:

> * gnu/packages/emacs-xyz.scm (emacs-nushell-mode): New variable.
>
> Change-Id: I216d8a9f7e7f89e379174a5d93020ff44c69d51f
> ---
>  gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm 
> b/gnu/packages/emacs-xyz.scm
> index c006f1d912..d2bdd7b52d 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -35629,6 +35629,27 @@ (define-public emacs-ntlm
>  implementation of Windows NT and LanManager compatible password 
>  encryption.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-nushell-mode
> +  (package
> +    (name "emacs-nushell-mode")
> +    (version "20231204.1233")

This needs to use `git-version'.  While the package has no tagged 
releases, nushell-mode.el has 0.1.0 declared as its version[1], so 
using that is preferable to using a date.

You can look at other package in emacs-xyz.scm if you need an 
example of how to version a package built off a Git snapshot; 
emacs-0x0 is one that does.

Thanks,

 -- Ian


[1]: 
https://github.com/mrkkrp/nushell-mode/blob/c179c3cf573b2cc9421dc08bf47e2d619c7791ee/nushell-mode.el#L10

Message #11 received at 76351 <at> debbugs.gnu.org (full text, mbox):

From: Skylar Hill <stellarskylark <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Skylar Hill <stellarskylark <at> posteo.net>, 76351 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add emacs-nushell-mode.
Date: Mon, 17 Feb 2025 19:47:28 +0000

* gnu/packages/emacs-xyz.scm (emacs-nushell-mode): New variable.

Change-Id: I216d8a9f7e7f89e379174a5d93020ff44c69d51f
---

Ian,

Ian Eure <ian <at> retrospec.tv> writes:

> This needs to use `git-version'.  While the package has no tagged
> releases, nushell-mode.el has 0.1.0 declared as its version[1], so
> using that is preferable to using a date.

Good catch, thanks! Here is my corrected patch.

Thanks,
Skylar

 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c006f1d912..0fd8498d7a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -35629,6 +35629,29 @@ (define-public emacs-ntlm
 implementation of Windows NT and LanManager compatible password encryption.")
     (license license:gpl3+)))
 
+(define-public emacs-nushell-mode
+  (let ((commit "c179c3cf573b2cc9421dc08bf47e2d619c7791ee")
+        (revision "0"))
+    (package
+      (name "emacs-nushell-mode")
+      (version (git-version "0.1.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/mrkkrp/nushell-mode.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "08kx31h22szvmccswwmhyj615c9fqln45darlfkj7q84dmc2fd3n"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/mrkkrp/nushell-mode")
+      (synopsis "Major mode for Nushell scripts")
+      (description
+       "This package provides a very basic version of major mode for Nushell shell
+scripts.")
+      (license license:gpl3+))))
+
 (define-public emacs-nadvice
   (package
     (name "emacs-nadvice")

base-commit: 6dde0ee30e5e030c2535514e9e39aa50518a5d20
prerequisite-patch-id: cc459efaf23197e58e97a6f0ad62058f71178746
prerequisite-patch-id: 492a9743436eae7679c7d9002f5b2d175eff9f1b
-- 
2.48.1

Message #18 received at 76351 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Skylar Hill <stellarskylark <at> posteo.net>
Cc: 76370 <at> debbugs.gnu.org, 76351 <at> debbugs.gnu.org
Date: Mon, 17 Feb 2025 13:57:49 -0800

Hi Skylar,

Thanks for the fix, pushed as 2b94ea3880.

I have no idea how this caused a new bug to be opened & assigned 
to me.

 -- Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.