GNU bug report logs - #76330
31.0.50; Faulty fontification in go-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76330: closed (31.0.50; Faulty fontification in go-ts-mode)
Date: Sat, 01 Mar 2025 12:14:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 01 Mar 2025 14:13:40 +0200
with message-id <86o6ylosnf.fsf <at> gnu.org>
and subject line Re: bug#76330: 31.0.50; Faulty fontification in go-ts-mode
has caused the debbugs.gnu.org bug report #76330,
regarding 31.0.50; Faulty fontification in go-ts-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76330: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76330
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Utkarsh Singh <utkarsh190601 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; Faulty fontification in go-ts-mode
Date: Sun, 16 Feb 2025 14:44:31 +0530

Hi Emacs Maintainers,

I have recently started learning Go using The Go Programming Language
(GOPL) book, and I'm using go-ts-mode for editing Go files.

Everything is working perfectly, but I have noticed a minor
fontification error in the following code:

const (
    width, height = 600, 320            // canvas size in pixels
    cells         = 100                 // number of grid cells
    xyrange       = 30.0                // axis ranges (-xyrange..+xyrange)
    xyscale       = width / 2 / xyrange // pixels per x or y unit
    zscale        = height * 0.4        // pixels per z unit
    angle         = math.Pi / 6         // angle of x, y axes (=30°)
)

Every constant except `height` is using `font-lock-constant-face`.

Could you please check if you can reproduce this issue?

Thank you,
Utkarsh Singh
-- 
Utkarsh Singh
https://utkarshsingh.xyz/

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 76330-done <at> debbugs.gnu.org, casouri <at> gmail.com, utkarsh190601 <at> gmail.com
Subject: Re: bug#76330: 31.0.50; Faulty fontification in go-ts-mode
Date: Sat, 01 Mar 2025 14:13:40 +0200

> Date: Sun, 16 Feb 2025 21:03:29 +0000
> From: Randy Taylor <dev <at> rjt.dev>
> Cc: Eli Zaretskii <eliz <at> gnu.org>, Yuan Fu <casouri <at> gmail.com>, 76330 <at> debbugs.gnu.org
> 
> On Sunday, February 16th, 2025 at 04:52, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> > 
> > > Cc: Randy Taylor dev <at> rjt.dev
> > 
> > > From: Utkarsh Singh utkarsh190601 <at> gmail.com
> > > Date: Sun, 16 Feb 2025 14:44:31 +0530
> > > 
> > > I have recently started learning Go using The Go Programming Language
> > > (GOPL) book, and I'm using go-ts-mode for editing Go files.
> > > 
> > > Everything is working perfectly, but I have noticed a minor
> > > fontification error in the following code:
> > > 
> > > const (
> > > width, height = 600, 320 // canvas size in pixels
> > > cells = 100 // number of grid cells
> > > xyrange = 30.0 // axis ranges (-xyrange..+xyrange)
> > > xyscale = width / 2 / xyrange // pixels per x or y unit
> > > zscale = height * 0.4 // pixels per z unit
> > > angle = math.Pi / 6 // angle of x, y axes (=30°)
> > > )
> > > 
> > > Every constant except `height` is using `font-lock-constant-face`.
> > > 
> > > Could you please check if you can reproduce this issue?
> > 
> > 
> > Randy and Yuan, could you please look into this?
> > 
> > Thanks.
> 
> Thanks for the report Utkarsh.
> 
> I've attached a patch (against emacs-30) that fixes it for me.

Thanks, installed on the emacs-30 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.