GNU bug report logs - #76330
31.0.50; Faulty fontification in go-ts-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76330 in the body.
You can then email your comments to 76330 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Utkarsh Singh <utkarsh190601 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; Faulty fontification in go-ts-mode
Date: Sun, 16 Feb 2025 14:44:31 +0530

Hi Emacs Maintainers,

I have recently started learning Go using The Go Programming Language
(GOPL) book, and I'm using go-ts-mode for editing Go files.

Everything is working perfectly, but I have noticed a minor
fontification error in the following code:

const (
    width, height = 600, 320            // canvas size in pixels
    cells         = 100                 // number of grid cells
    xyrange       = 30.0                // axis ranges (-xyrange..+xyrange)
    xyscale       = width / 2 / xyrange // pixels per x or y unit
    zscale        = height * 0.4        // pixels per z unit
    angle         = math.Pi / 6         // angle of x, y axes (=30°)
)

Every constant except `height` is using `font-lock-constant-face`.

Could you please check if you can reproduce this issue?

Thank you,
Utkarsh Singh
-- 
Utkarsh Singh
https://utkarshsingh.xyz/

Message #8 received at 76330 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Utkarsh Singh <utkarsh190601 <at> gmail.com>, dev <at> rjt.dev,
 Yuan Fu <casouri <at> gmail.com>
Cc: 76330 <at> debbugs.gnu.org
Subject: Re: bug#76330: 31.0.50; Faulty fontification in go-ts-mode
Date: Sun, 16 Feb 2025 11:52:38 +0200

> Cc: Randy Taylor <dev <at> rjt.dev>
> From: Utkarsh Singh <utkarsh190601 <at> gmail.com>
> Date: Sun, 16 Feb 2025 14:44:31 +0530
> 
> I have recently started learning Go using The Go Programming Language
> (GOPL) book, and I'm using go-ts-mode for editing Go files.
> 
> Everything is working perfectly, but I have noticed a minor
> fontification error in the following code:
> 
> const (
>     width, height = 600, 320            // canvas size in pixels
>     cells         = 100                 // number of grid cells
>     xyrange       = 30.0                // axis ranges (-xyrange..+xyrange)
>     xyscale       = width / 2 / xyrange // pixels per x or y unit
>     zscale        = height * 0.4        // pixels per z unit
>     angle         = math.Pi / 6         // angle of x, y axes (=30°)
> )
> 
> Every constant except `height` is using `font-lock-constant-face`.
> 
> Could you please check if you can reproduce this issue?

Randy and Yuan, could you please look into this?

Thanks.

Message #11 received at 76330 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Utkarsh Singh <utkarsh190601 <at> gmail.com>
Cc: 76330 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Yuan Fu <casouri <at> gmail.com>
Subject: Re: bug#76330: 31.0.50; Faulty fontification in go-ts-mode
Date: Sun, 16 Feb 2025 21:03:29 +0000

[Message part 1 (text/plain, inline)]

On Sunday, February 16th, 2025 at 04:52, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> 
> > Cc: Randy Taylor dev <at> rjt.dev
> 
> > From: Utkarsh Singh utkarsh190601 <at> gmail.com
> > Date: Sun, 16 Feb 2025 14:44:31 +0530
> > 
> > I have recently started learning Go using The Go Programming Language
> > (GOPL) book, and I'm using go-ts-mode for editing Go files.
> > 
> > Everything is working perfectly, but I have noticed a minor
> > fontification error in the following code:
> > 
> > const (
> > width, height = 600, 320 // canvas size in pixels
> > cells = 100 // number of grid cells
> > xyrange = 30.0 // axis ranges (-xyrange..+xyrange)
> > xyscale = width / 2 / xyrange // pixels per x or y unit
> > zscale = height * 0.4 // pixels per z unit
> > angle = math.Pi / 6 // angle of x, y axes (=30°)
> > )
> > 
> > Every constant except `height` is using `font-lock-constant-face`.
> > 
> > Could you please check if you can reproduce this issue?
> 
> 
> Randy and Yuan, could you please look into this?
> 
> Thanks.

Thanks for the report Utkarsh.

I've attached a patch (against emacs-30) that fixes it for me.

[0001-Fix-go-ts-mode-const_spec-highlighting-Bug-76330.patch (text/x-patch, attachment)]

Message #14 received at 76330 <at> debbugs.gnu.org (full text, mbox):

From: Utkarsh Singh <utkarsh190601 <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 76330 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Yuan Fu <casouri <at> gmail.com>
Subject: Re: bug#76330: 31.0.50; Faulty fontification in go-ts-mode
Date: Mon, 17 Feb 2025 06:51:37 +0530

On 2025-02-16, 21:03 +0000, Randy Taylor <dev <at> rjt.dev> wrote:

> Thanks for the report Utkarsh.

Thanks for the quick response as well.

> I've attached a patch (against emacs-30) that fixes it for me.

I can confirm that the patch fixes the bug for me.

-- 
Utkarsh Singh
https://utkarshsingh.xyz/

Message #21 received at 76330-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 76330-done <at> debbugs.gnu.org, casouri <at> gmail.com, utkarsh190601 <at> gmail.com
Subject: Re: bug#76330: 31.0.50; Faulty fontification in go-ts-mode
Date: Sat, 01 Mar 2025 14:13:40 +0200

> Date: Sun, 16 Feb 2025 21:03:29 +0000
> From: Randy Taylor <dev <at> rjt.dev>
> Cc: Eli Zaretskii <eliz <at> gnu.org>, Yuan Fu <casouri <at> gmail.com>, 76330 <at> debbugs.gnu.org
> 
> On Sunday, February 16th, 2025 at 04:52, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> > 
> > > Cc: Randy Taylor dev <at> rjt.dev
> > 
> > > From: Utkarsh Singh utkarsh190601 <at> gmail.com
> > > Date: Sun, 16 Feb 2025 14:44:31 +0530
> > > 
> > > I have recently started learning Go using The Go Programming Language
> > > (GOPL) book, and I'm using go-ts-mode for editing Go files.
> > > 
> > > Everything is working perfectly, but I have noticed a minor
> > > fontification error in the following code:
> > > 
> > > const (
> > > width, height = 600, 320 // canvas size in pixels
> > > cells = 100 // number of grid cells
> > > xyrange = 30.0 // axis ranges (-xyrange..+xyrange)
> > > xyscale = width / 2 / xyrange // pixels per x or y unit
> > > zscale = height * 0.4 // pixels per z unit
> > > angle = math.Pi / 6 // angle of x, y axes (=30°)
> > > )
> > > 
> > > Every constant except `height` is using `font-lock-constant-face`.
> > > 
> > > Could you please check if you can reproduce this issue?
> > 
> > 
> > Randy and Yuan, could you please look into this?
> > 
> > Thanks.
> 
> Thanks for the report Utkarsh.
> 
> I've attached a patch (against emacs-30) that fixes it for me.

Thanks, installed on the emacs-30 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.