GNU bug report logs - #76248
[Feature Request] user-option for killing buffer in `quit-window'.

Previous Next

To reply to this bug, email your comments to 76248 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Perez <eg642616 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [Feature Request] user-option for killing buffer in `quit-window'.
Date: Wed, 12 Feb 2025 22:44:34 -0600

Hello, i would like to know why there is not an user-option for the
`quit-window' function to kill windows instead burying them.

I find this useful in buffers like `help-mode' to avoid filling
list-buffers with unnecessary buffers.

I'm currently using an `advice' to achieve this:

  (advice-add #'quit-window :around
              (lambda (orig-fn _ &rest window)
                (funcall orig-fn 't window)))


and honestly I would prefer an option like: "quit-window-kill-buffer"
(set to `nil' by default).

-- 
                                                   - E.G via GNU Emacs.

Message #8 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Elijah Gabe Perez <eg642616 <at> gmail.com>
Cc: 76248 <at> debbugs.gnu.org, martin rudalics <rudalics <at> gmx.at>
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Thu, 13 Feb 2025 09:10:53 +0200

> Hello, i would like to know why there is not an user-option for the
> `quit-window' function to kill windows instead burying them.
>
> I find this useful in buffers like `help-mode' to avoid filling
> list-buffers with unnecessary buffers.
>
> I'm currently using an `advice' to achieve this:
>
>   (advice-add #'quit-window :around
>               (lambda (orig-fn _ &rest window)
>                 (funcall orig-fn 't window)))
>
> and honestly I would prefer an option like: "quit-window-kill-buffer"
> (set to `nil' by default).

I completely agree.  The lack of this option causes so much trouble.
For example, I needed to define in the init file:

  (defun quit-window-kill-buffer ()
    "Quit WINDOW and kill its buffer."
    (interactive)
    (quit-window 1))

and then update each and every keymap to override 'quit-window'
with 'quit-window-kill-buffer':

  (define-key archive-mode-map "q" 'quit-window-kill-buffer)
  (define-key tar-mode-map "q" 'quit-window-kill-buffer)
  (define-key dired-mode-map "q" 'quit-window-kill-buffer)
  ...

Message #11 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>, Elijah Gabe Perez <eg642616 <at> gmail.com>
Cc: 76248 <at> debbugs.gnu.org, martin rudalics <rudalics <at> gmx.at>
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Wed, 12 Feb 2025 23:25:56 -0800

Juri Linkov <juri <at> linkov.net> writes:

>> Hello, i would like to know why there is not an user-option for the
>> `quit-window' function to kill windows instead burying them.
>>
>> I find this useful in buffers like `help-mode' to avoid filling
>> list-buffers with unnecessary buffers.
>>
>> I'm currently using an `advice' to achieve this:
>>
>>   (advice-add #'quit-window :around
>>               (lambda (orig-fn _ &rest window)
>>                 (funcall orig-fn 't window)))
>>
>> and honestly I would prefer an option like: "quit-window-kill-buffer"
>> (set to `nil' by default).
>
> I completely agree.  The lack of this option causes so much trouble.

Sounds useful, agreed.  Why not have the option.

> For example, I needed to define in the init file:
>
>   (defun quit-window-kill-buffer ()
>     "Quit WINDOW and kill its buffer."
>     (interactive)
>     (quit-window 1))
>
> and then update each and every keymap to override 'quit-window'
> with 'quit-window-kill-buffer':
>
>   (define-key archive-mode-map "q" 'quit-window-kill-buffer)
>   (define-key tar-mode-map "q" 'quit-window-kill-buffer)
>   (define-key dired-mode-map "q" 'quit-window-kill-buffer)
>   ...

(Maybe an advice could work for this?)

Message #14 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 76248 <at> debbugs.gnu.org, martin rudalics <rudalics <at> gmx.at>,
 Elijah Gabe Perez <eg642616 <at> gmail.com>
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Thu, 13 Feb 2025 09:53:56 +0200

>>> and honestly I would prefer an option like: "quit-window-kill-buffer"
>>> (set to `nil' by default).
>>
>> I completely agree.  The lack of this option causes so much trouble.
>
> Sounds useful, agreed.  Why not have the option.
>
>> For example, I needed to define in the init file:
>>
>>   (defun quit-window-kill-buffer ()
>>     "Quit WINDOW and kill its buffer."
>>     (interactive)
>>     (quit-window 1))
>>
>> and then update each and every keymap to override 'quit-window'
>> with 'quit-window-kill-buffer':
>>
>>   (define-key archive-mode-map "q" 'quit-window-kill-buffer)
>>   (define-key tar-mode-map "q" 'quit-window-kill-buffer)
>>   (define-key dired-mode-map "q" 'quit-window-kill-buffer)
>>   ...
>
> (Maybe an advice could work for this?)

An advice has too wide coverage.  Of course, it's possible
to check for major-mode in an advice.  But it would be more clean
to set a buffer-local value of the new option either to non-nil
in modes where 'q' should kill the buffer, or to nil in some modes
when the user customized the new option to non-nil for all modes.

Message #17 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> linkov.net>, Elijah Gabe Perez <eg642616 <at> gmail.com>
Cc: 76248 <at> debbugs.gnu.org
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Thu, 13 Feb 2025 10:33:58 +0100

[Message part 1 (text/plain, inline)]

>> Hello, i would like to know why there is not an user-option for the
>> `quit-window' function to kill windows instead burying them.
                                  ^^^^^^^
				  buffers

>> I find this useful in buffers like `help-mode' to avoid filling
>> list-buffers with unnecessary buffers.
>>
>> I'm currently using an `advice' to achieve this:
>>
>>    (advice-add #'quit-window :around
>>                (lambda (orig-fn _ &rest window)
>>                  (funcall orig-fn 't window)))
>>
>> and honestly I would prefer an option like: "quit-window-kill-buffer"
>> (set to `nil' by default).
>
> I completely agree.  The lack of this option causes so much trouble.
> For example, I needed to define in the init file:
>
>    (defun quit-window-kill-buffer ()
>      "Quit WINDOW and kill its buffer."
>      (interactive)
>      (quit-window 1))
>
> and then update each and every keymap to override 'quit-window'
> with 'quit-window-kill-buffer':
>
>    (define-key archive-mode-map "q" 'quit-window-kill-buffer)
>    (define-key tar-mode-map "q" 'quit-window-kill-buffer)
>    (define-key dired-mode-map "q" 'quit-window-kill-buffer)
>    ...

I attach a patch that could simplify that.

martin

[quit-window-kill-buffer.diff (text/x-patch, attachment)]

Message #20 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>, Juri Linkov <juri <at> linkov.net>, 
 Elijah Gabe Perez <eg642616 <at> gmail.com>
Cc: 76248 <at> debbugs.gnu.org
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Thu, 13 Feb 2025 02:31:38 -0800

martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> I attach a patch that could simplify that.

LGTM, but it needs a NEWS item.

Maybe an addition to the manual as well?

Message #23 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Kangas <stefankangas <at> gmail.com>, Juri Linkov <juri <at> linkov.net>,
 Elijah Gabe Perez <eg642616 <at> gmail.com>
Cc: 76248 <at> debbugs.gnu.org
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Thu, 13 Feb 2025 11:59:43 +0100

> LGTM, but it needs a NEWS item.
>
> Maybe an addition to the manual as well?

Both.  But first let's see what the others think about it.  Maybe its
handling should go to 'quit-restore-window' itself.  Or we should have
'quit-windows-on' handle it too.  Then what about 'delete-windows-on'?

martin

Message #26 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 76248 <at> debbugs.gnu.org, Elijah Gabe Perez <eg642616 <at> gmail.com>,
 Stefan Kangas <stefankangas <at> gmail.com>, Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Thu, 13 Feb 2025 06:05:03 -0500

[Message part 1 (text/plain, inline)]

I think symmetry in delete-window would be nice. I've wrapped it to achieve
something similar.

On Thu, Feb 13, 2025 at 6:00 AM martin rudalics via Bug reports for GNU
Emacs, the Swiss army knife of text editors <bug-gnu-emacs <at> gnu.org> wrote:

>  > LGTM, but it needs a NEWS item.
>  >
>  > Maybe an addition to the manual as well?
>
> Both.  But first let's see what the others think about it.  Maybe its
> handling should go to 'quit-restore-window' itself.  Or we should have
> 'quit-windows-on' handle it too.  Then what about 'delete-windows-on'?
>
> martin
>
>
>
>

[Message part 2 (text/html, inline)]

Message #29 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: martin rudalics <rudalics <at> gmx.at>, Stefan Kangas <stefankangas <at> gmail.com>, 
 Juri Linkov <juri <at> linkov.net>, Elijah Gabe Perez <eg642616 <at> gmail.com>
Cc: "76248 <at> debbugs.gnu.org" <76248 <at> debbugs.gnu.org>
Subject: RE: [External] : bug#76248: [Feature Request] user-option for killing
 buffer in `quit-window'.
Date: Thu, 13 Feb 2025 16:44:55 +0000

FWIW, I want to bury the buffer of a quit window, not kill it.
I remap bindings of `quit-window' to this, which I got from
Martin 10 years ago:

(defun quit-window-delete (&optional kill window)
  "Quit WINDOW, deleting it, and bury its buffer.
WINDOW must be a live window and defaults to the selected one.
With prefix argument KILL non-nil, kill the buffer instead of
burying it.

This is similar to the version of `quit-window' that Emacs had before
the introduction of `quit-restore-window'.  It ignores the information
stored in WINDOW's `quit-restore' window parameter.

It deletes the WINDOW more often, rather than switching to another
buffer in it.  If WINDOW is alone in its frame then the frame is
deleted or iconified, according to option `frame-auto-hide-function'."
  (interactive "P")
  (set-window-parameter window
                        'quit-restore
                        `(frame frame nil ,(current-buffer)))
  (quit-restore-window window (if kill 'kill 'bury))))

Message #32 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 76248 <at> debbugs.gnu.org, Elijah Gabe Perez <eg642616 <at> gmail.com>
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Thu, 13 Feb 2025 19:47:03 +0200

> I attach a patch that could simplify that.

Thanks.

> +(defcustom quit-window-kill-buffer-modes nil
> +  "List of major modes telling `quit-window' to kill WINDOW's buffer.
> +If non-nil, this should be a list of major modes.  `quit-window' will
> +kill the buffer of its WINDOW argument when that buffer's major mode is
> +a member of this list regardless of the value of the KILL argument."
> +  :type '(repeat (symbol :tag "Major mode"))
> +  :version "31.1"
> +  :group 'windows)

It would be nice to support the value t as a shortcut that means all modes.
Then the name could be just 'quit-window-kill-buffer' for symmetry with
'kill-buffer-quit-windows'.

> +  (let (kill-from-mode)
> +    (with-current-buffer (window-buffer (window-normalize-window window))
> +      (run-hooks 'quit-window-hook)
> +
> +      (setq kill-from-mode (memq major-mode quit-window-kill-buffer-modes)))
> +
> +    (quit-restore-window
> +     window (if (or kill kill-from-mode) 'kill 'bury))))

Wouldn't it be better to check for derived modes with 'derived-mode-p'?
Then it's possible to detect all modes inheriting from special-mode,
e.g. (derived-mode-p '(special-mode)).

> Maybe its handling should go to 'quit-restore-window' itself.
> Or we should have 'quit-windows-on' handle it too.
> Then what about 'delete-windows-on'?

Not sure about other functions.

Message #35 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 76248 <at> debbugs.gnu.org, Elijah Gabe Perez <eg642616 <at> gmail.com>,
 Stefan Kangas <stefankangas <at> gmail.com>, Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Fri, 14 Feb 2025 11:23:45 +0100

> I think symmetry in delete-window would be nice. I've wrapped it to achieve
> something similar.

Which condition did you use?

martin

Message #38 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> linkov.net>
Cc: 76248 <at> debbugs.gnu.org, Elijah Gabe Perez <eg642616 <at> gmail.com>
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Fri, 14 Feb 2025 11:24:49 +0100

[Message part 1 (text/plain, inline)]

> It would be nice to support the value t as a shortcut that means all modes.

OK.

> Then the name could be just 'quit-window-kill-buffer' for symmetry with
> 'kill-buffer-quit-windows'.

Hmm...  What about people who eventually expect buffer names or regexps
to match the name of the window's buffer?

> Wouldn't it be better to check for derived modes with 'derived-mode-p'?
> Then it's possible to detect all modes inheriting from special-mode,
> e.g. (derived-mode-p '(special-mode)).

OK.

>> Maybe its handling should go to 'quit-restore-window' itself.
>> Or we should have 'quit-windows-on' handle it too.
>> Then what about 'delete-windows-on'?
>
> Not sure about other functions.

Me neither.  Maybe your original statement that it really is the "q" we
want to handle could be done via an additional condition like

(eq (key-binding "q") 'quit-window)

New patch attached.

martin

[quit-window-kill-buffer.diff (text/x-patch, attachment)]

Message #41 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Perez <eg642616 <at> gmail.com>
To: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of
 text editors" <bug-gnu-emacs <at> gnu.org>
Cc: 76248 <at> debbugs.gnu.org, martin rudalics <rudalics <at> gmx.at>,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Fri, 14 Feb 2025 23:33:25 -0600

martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> +either a member of this list or is derived from a member of this list.
> +In either case it will kill the buffer regardless of the value of the
> +KILL argument."
> +  :type '(repeat (symbol :tag "Major mode"))
> +  :version "31.1"
> +  :group 'windows)

Shouldn't it be something like this?

+  :type '(choice (repeat (symbol :tag "Major mode")) boolean)
+  :version "31.1"
+  :group 'windows)

Otherwise it would give a warning due type.

> +  (let (kill-from-mode)
> +    (with-current-buffer (window-buffer (window-normalize-window window))
> +      ;; Run the hook from the buffer implied to get any buffer-local
> +      ;; values.
> +      (run-hooks 'quit-window-hook)
> +
> +      (setq kill-from-mode
> +	    (or (eq quit-window-kill-buffer-modes t)
> +		(and (listp quit-window-kill-buffer-modes)
> +		     (derived-mode-p quit-window-kill-buffer-modes)))))

Wouldn't it be more convenient to put this into the let varlist?

+  (let ((kill-from-mode
+         (or (eq quit-window-kill-buffer-modes t)
+		      (and (listp quit-window-kill-buffer-modes)
+		           (derived-mode-p quit-window-kill-buffer-modes)))))


... or is there something i'm missing?

-- 
                                                   - E.G via GNU Emacs.

Message #47 received at submit <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Elijah Gabe Perez <eg642616 <at> gmail.com>,
 martin rudalics via Bug reports for GNU "Emacs, " the Swiss army knife of text
 editors <bug-gnu-emacs <at> gnu.org>
Cc: 76248 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Sat, 15 Feb 2025 11:35:32 +0100

[Message part 1 (text/plain, inline)]

> Shouldn't it be something like this?
>
> +  :type '(choice (repeat (symbol :tag "Major mode")) boolean)
> +  :version "31.1"
> +  :group 'windows)
>
> Otherwise it would give a warning due type.

Right.

>> +  (let (kill-from-mode)
>> +    (with-current-buffer (window-buffer (window-normalize-window window))
>> +      ;; Run the hook from the buffer implied to get any buffer-local
>> +      ;; values.
>> +      (run-hooks 'quit-window-hook)
>> +
>> +      (setq kill-from-mode
>> +	    (or (eq quit-window-kill-buffer-modes t)
>> +		(and (listp quit-window-kill-buffer-modes)
>> +		     (derived-mode-p quit-window-kill-buffer-modes)))))
>
> Wouldn't it be more convenient to put this into the let varlist?

It would be more convenient ...

> +  (let ((kill-from-mode
> +         (or (eq quit-window-kill-buffer-modes t)
> +		      (and (listp quit-window-kill-buffer-modes)
> +		           (derived-mode-p quit-window-kill-buffer-modes)))))
>
>
> ... or is there something i'm missing?

... but 'derived-mode-p' says to

 "Return non-nil if the current major mode is derived from one of MODES.

so I have to make the buffer current first via 'with-current-buffer' and
only then I can call 'derived-mode-p'.

martin

[quit-window-kill-buffer.diff (text/x-patch, attachment)]

Message #53 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 76248 <at> debbugs.gnu.org, Elijah Gabe Perez <eg642616 <at> gmail.com>
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Sat, 15 Feb 2025 20:11:44 +0200

>> Then the name could be just 'quit-window-kill-buffer' for symmetry with
>> 'kill-buffer-quit-windows'.
>
> Hmm...  What about people who eventually expect buffer names or regexps
> to match the name of the window's buffer?

A shorter name 'quit-window-kill-buffer' gives more freedom
for possible future extensions, e.g. for a list of regexps
or buffer names as strings in addition to mode names as symbols.

Message #56 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Perez <eg642616 <at> gmail.com>
To: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of
 text editors" <bug-gnu-emacs <at> gnu.org>
Cc: 76248 <at> debbugs.gnu.org, martin rudalics <rudalics <at> gmx.at>, juri <at> linkov.net
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Sat, 15 Feb 2025 13:18:32 -0600

martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

>> Wouldn't it be more convenient to put this into the let varlist?
>
> It would be more convenient ...
>
>> +  (let ((kill-from-mode
>> +         (or (eq quit-window-kill-buffer-modes t)
>> +		      (and (listp quit-window-kill-buffer-modes)
>> +		           (derived-mode-p quit-window-kill-buffer-modes)))))
>>
>>
>> ... or is there something i'm missing?
>
> ... but 'derived-mode-p' says to
>
>  "Return non-nil if the current major mode is derived from one of MODES.
>
> so I have to make the buffer current first via 'with-current-buffer' and
> only then I can call 'derived-mode-p'.

I see, thanks for the clarification.

-- 
                                                   - E.G via GNU Emacs.

Message #62 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> linkov.net>
Cc: 76248 <at> debbugs.gnu.org, Elijah Gabe Perez <eg642616 <at> gmail.com>
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Sun, 16 Feb 2025 09:59:31 +0100

> A shorter name 'quit-window-kill-buffer' gives more freedom
> for possible future extensions, e.g. for a list of regexps
> or buffer names as strings in addition to mode names as symbols.

OK.  We now already have t as possible value anyway.

martin

Message #65 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of
 text editors" <bug-gnu-emacs <at> gnu.org>
Cc: 76248 <at> debbugs.gnu.org, martin rudalics <rudalics <at> gmx.at>,
 Stefan Kangas <stefankangas <at> gmail.com>, juri <at> linkov.net
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Sun, 16 Feb 2025 16:28:22 -0600

I've tested the patch and the implementation works like a charm.

However, I would prefer this line to be added.

  :type '(choice (const :tag "All major modes" t)
+                (const :tag "Bury, don't kill" nil)
		         (repeat (symbol :tag "Major mode")))
  :version "31.1"
  :group 'windows)

-- 
                                                   - E.G via GNU Emacs.

Message #71 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>,
 "76248 <at> debbugs.gnu.org" <76248 <at> debbugs.gnu.org>
Cc: "rudalics <at> gmx.at" <rudalics <at> gmx.at>,
 "stefankangas <at> gmail.com" <stefankangas <at> gmail.com>,
 "juri <at> linkov.net" <juri <at> linkov.net>
Subject: RE: [External] : bug#76248: [Feature Request] user-option for killing
 buffer in `quit-window'.
Date: Mon, 17 Feb 2025 01:14:44 +0000

> I would prefer this line to be added.
> 
>   :type '(choice (const :tag "All major modes" t)
> +                (const :tag "Bury, don't kill" nil)
> 		         (repeat (symbol :tag "Major mode")))
>   :version "31.1"
>   :group 'windows)

+1 for allowing a bury-buffer choice.

That's what I was hinting at when I posted
that I use a function `quit-window-delete'
that buries the buffer rather than killing it.

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76248#29
___

And as I indicated there:

  This is similar to the version of `quit-window'
  that Emacs had before the introduction of
  `quit-restore-window'.  It ignores the
  information stored in WINDOW's `quit-restore'
  window parameter.

  It deletes the WINDOW more often, rather than
  switching to another buffer in it.  If WINDOW
  is alone in its frame then the frame is deleted
  or iconified, according to option
  `frame-auto-hide-function'.

However, the way the enhancement seems to be
getting implemented so far, your addition of a
bury-it option in the way you propose doesn't
seem right - it appears to be just bolted on as
an after-thought. 

Burying as an option should be at the same level
of choice as killing as an option - it's parallel
to that choice.  It's not parallel with a choice
of all modes versus specific modes - it's not an
alternative to mode choices.

Message #74 received at submit <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>,
 martin rudalics via Bug reports for GNU "Emacs, " the Swiss army knife of text
 editors <bug-gnu-emacs <at> gnu.org>
Cc: 76248 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>,
 juri <at> linkov.net
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Mon, 17 Feb 2025 10:20:23 +0100

[Message part 1 (text/plain, inline)]

> I've tested the patch and the implementation works like a charm.
>
> However, I would prefer this line to be added.
>
>    :type '(choice (const :tag "All major modes" t)
> +                (const :tag "Bury, don't kill" nil)
> 		         (repeat (symbol :tag "Major mode")))
>    :version "31.1"
>    :group 'windows)

Then maybe the attached would fit you better.  The text "Bury, don't
kill" is subtly misleading here because 'quit-window' will also bury the
buffer when its major mode is not a member of a list of modes specified
by this option.

martin

[quit-window-kill-buffer.diff (text/x-patch, attachment)]

Message #80 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Drew Adams <drew.adams <at> oracle.com>, Elijah Gabe Pérez
 <eg642616 <at> gmail.com>, "76248 <at> debbugs.gnu.org" <76248 <at> debbugs.gnu.org>
Cc: "stefankangas <at> gmail.com" <stefankangas <at> gmail.com>,
 "juri <at> linkov.net" <juri <at> linkov.net>
Subject: Re: [External] : bug#76248: [Feature Request] user-option for killing
 buffer in `quit-window'.
Date: Mon, 17 Feb 2025 10:20:58 +0100

>> I would prefer this line to be added.
>>
>>    :type '(choice (const :tag "All major modes" t)
>> +                (const :tag "Bury, don't kill" nil)
>> 		         (repeat (symbol :tag "Major mode")))
>>    :version "31.1"
>>    :group 'windows)
>
> +1 for allowing a bury-buffer choice.

That choice was here before and was always supported as default.

martin

Message #83 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: martin rudalics <rudalics <at> gmx.at>, Elijah Gabe Pérez
 <eg642616 <at> gmail.com>, "76248 <at> debbugs.gnu.org" <76248 <at> debbugs.gnu.org>
Cc: "stefankangas <at> gmail.com" <stefankangas <at> gmail.com>,
 "juri <at> linkov.net" <juri <at> linkov.net>
Subject: RE: [External] : bug#76248: [Feature Request] user-option for killing
 buffer in `quit-window'.
Date: Mon, 17 Feb 2025 16:26:08 +0000

>  > +1 for allowing a bury-buffer choice.
> 
> That choice was here before and was always supported as default.

I see; thx.  Sorry for misunderstanding.

Message #86 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of
 text editors" <bug-gnu-emacs <at> gnu.org>
Cc: 76248 <at> debbugs.gnu.org, martin rudalics <rudalics <at> gmx.at>,
 stefankangas <at> gmail.com, juri <at> linkov.net
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Mon, 17 Feb 2025 18:31:01 -0600

martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> Then maybe the attached would fit you better.

Yeah, the patch seems fine to me now, I remain neutral regarding
adding this functionality to quit-windows-on (and quit-restore-window)
since I haven't seen it in most of the commands I use.

I can't wait to try it out.

-- 
                                                   - E.G via GNU Emacs.

Message #92 received at 76248 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>,
 martin rudalics via Bug reports for GNU "Emacs, " the Swiss army knife of text
 editors <bug-gnu-emacs <at> gnu.org>
Cc: 76248 <at> debbugs.gnu.org, stefankangas <at> gmail.com, juri <at> linkov.net
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Sun, 23 Feb 2025 11:05:43 +0100

> Yeah, the patch seems fine to me now, I remain neutral regarding
> adding this functionality to quit-windows-on (and quit-restore-window)
> since I haven't seen it in most of the commands I use.
>
> I can't wait to try it out.

Pushed to master now.  Please try it out.

Thanks, martin

Message #98 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of
 text editors" <bug-gnu-emacs <at> gnu.org>
Cc: 76248 <at> debbugs.gnu.org, martin rudalics <rudalics <at> gmx.at>,
 stefankangas <at> gmail.com, juri <at> linkov.net
Subject: Re: bug#76248: [Feature Request] user-option for killing buffer in
 `quit-window'.
Date: Sun, 23 Feb 2025 21:58:11 -0600

martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> Pushed to master now.  Please try it out.

LGTM, Thank you so much.

-- 
                                                   - E.G via GNU Emacs.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.