GNU bug report logs - #76247
31.0.50; side-effect-free properties not loading with (require 'cl-lib)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76247 in the body.
You can then email your comments to 76247 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50;
 side-effect-free properties not loading with (require 'cl-lib)
Date: Wed, 12 Feb 2025 19:33:05 -0800

[Message part 1 (text/plain, inline)]

Requiring `cl-lib` is not enough to get the side-effect-free property on
functions like cl-fifth.  To see this, run emacs -Q and evaluate:

    (progn
      (require 'cl-lib)
      (describe-function 'cl-fifth)
      (function-get 'cl-fifth 'side-effect-free))

Note that the form returns nil, and that the "This function does not
change global state" text is not there in the *Help* buffer.

This can be fixed by adding this to the above recipe:

    (require 'cl-macs)

I have attached a patch that fixes this, and also gets the proper
(put 'cl-foo 'side-effect-free t) forms into cl-loaddefs.el.

If this looks okay, I think we could do the same for the
(side-effect-free error-free) case as well.

[0001-Inline-side-effect-free-declarations-in-cl-lib.el.patch (text/x-patch, attachment)]

Message #14 received at 76247-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 76247-done <at> debbugs.gnu.org
Subject: Re: bug#76247: 31.0.50; side-effect-free properties not loading with
 (require 'cl-lib)
Date: Thu, 13 Feb 2025 08:52:05 -0800

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> I have attached a patch that fixes this, and also gets the proper
>> (put 'cl-foo 'side-effect-free t) forms into cl-loaddefs.el.
>>
>> If this looks okay, I think we could do the same for the
>> (side-effect-free error-free) case as well.
>
> LGTM!

Thanks, installed, closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.