GNU bug report logs - #76175
[PATCH] gnu: librewolf: Honor --cores build argument.

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 76175 <at> debbugs.gnu.org
Subject: [bug#76175] [PATCH] gnu: librewolf: Honor --cores build argument.
Date: Wed, 12 Feb 2025 21:39:45 +0900

Hi,

Nicolas Graves <ngraves <at> ngraves.fr> writes:

> * gnu/packages/librewolf.scm (librewolf)[arguments]<#:phases>:
> Honor --cores build argument during the 'build phase.
> ---
>  gnu/packages/librewolf.scm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm
> index 28abaefe53..d093fd095f 100644
> --- a/gnu/packages/librewolf.scm
> +++ b/gnu/packages/librewolf.scm
> @@ -470,8 +470,10 @@ (define write-flags
>                         (apply invoke "./mach" "build"
>                                ;; mach will use parallel build if possible by default

I'd drop the above comment too, which is no longer relevant.

>                                `(,@(if parallel-build?
> -                                      '()
> -                                      '("-j1")) ,@make-flags))))
> +                                      `(,(string-append
> +                                          "-j" (number->string (parallel-job-count))))
> +                                      '("-j1"))
> +                                ,@make-flags))))

Otherwise, LGTM.  Feel free to push!  Oh wait, you don't have commit
access?  If that's something you'd like to have, I encourage you to find
3 person to vouch for you and request it to guix-maintainers <at> gnu.org.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.