GNU bug report logs - #76175
[PATCH] gnu: librewolf: Honor --cores build argument.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76175 in the body.
You can then email your comments to 76175 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: librewolf: Honor --cores build argument.
Date: Mon, 10 Feb 2025 10:16:39 +0100

* gnu/packages/librewolf.scm (librewolf)[arguments]<#:phases>:
Honor --cores build argument during the 'build phase.
---
 gnu/packages/librewolf.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm
index 28abaefe53..d093fd095f 100644
--- a/gnu/packages/librewolf.scm
+++ b/gnu/packages/librewolf.scm
@@ -470,8 +470,10 @@ (define write-flags
                        (apply invoke "./mach" "build"
                               ;; mach will use parallel build if possible by default
                               `(,@(if parallel-build?
-                                      '()
-                                      '("-j1")) ,@make-flags))))
+                                      `(,(string-append
+                                          "-j" (number->string (parallel-job-count))))
+                                      '("-j1"))
+                                ,@make-flags))))
                    (add-after 'build 'neutralise-store-references
                      (lambda _
                        ;; Mangle the store references to compilers &
-- 
2.48.1



-- 
Best regards,
Nicolas Graves

Message #8 received at 76175 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 76175 <at> debbugs.gnu.org
Subject: Re: bug#76175: [PATCH] gnu: librewolf: Honor --cores build argument.
Date: Wed, 12 Feb 2025 21:39:45 +0900

Hi,

Nicolas Graves <ngraves <at> ngraves.fr> writes:

> * gnu/packages/librewolf.scm (librewolf)[arguments]<#:phases>:
> Honor --cores build argument during the 'build phase.
> ---
>  gnu/packages/librewolf.scm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm
> index 28abaefe53..d093fd095f 100644
> --- a/gnu/packages/librewolf.scm
> +++ b/gnu/packages/librewolf.scm
> @@ -470,8 +470,10 @@ (define write-flags
>                         (apply invoke "./mach" "build"
>                                ;; mach will use parallel build if possible by default

I'd drop the above comment too, which is no longer relevant.

>                                `(,@(if parallel-build?
> -                                      '()
> -                                      '("-j1")) ,@make-flags))))
> +                                      `(,(string-append
> +                                          "-j" (number->string (parallel-job-count))))
> +                                      '("-j1"))
> +                                ,@make-flags))))

Otherwise, LGTM.  Feel free to push!  Oh wait, you don't have commit
access?  If that's something you'd like to have, I encourage you to find
3 person to vouch for you and request it to guix-maintainers <at> gnu.org.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim

Message #11 received at 76175 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 76175 <at> debbugs.gnu.org
Subject: Re: [bug#76175] [PATCH] gnu: librewolf: Honor --cores build argument.
Date: Fri, 14 Feb 2025 16:04:36 -0800

Hi Nicolas,

Pushed as 9b1fe3bd70.

Thank you!

-- Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.