GNU bug report logs - #76166
[PATCH] gnu: icewm: make available during instalation.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76166 in the body.
You can then email your comments to 76166 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: guix-patches <at> gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH] gnu: icewm: make available during instalation.
Date: Sun,  9 Feb 2025 11:20:11 -0800

* gnu/installer/services.scm (icewm): Make icewm a desktop service.
* gnu/tests/install.scm: Make icewm an installation target for tests.
* etc/manifests/release.scm: Make icewm available at system install.

Change-Id: I881c1dd4289281e51c81d83fac785ef064e6ff6a
---
 etc/manifests/release.scm  | 2 +-
 gnu/installer/services.scm | 3 +++
 gnu/tests/install.scm      | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/etc/manifests/release.scm b/etc/manifests/release.scm
index b003f216ff..93ac7dcec8 100644
--- a/etc/manifests/release.scm
+++ b/etc/manifests/release.scm
@@ -68,7 +68,7 @@ (define %system-packages
   ;; Key packages proposed by the Guix System installer.
   (append (map specification->package
                '("xorg-server" "xfce" "gnome" "mate" "enlightenment"
-                 "openbox" "awesome" "i3-wm" "ratpoison"
+                 "icewm" "openbox" "awesome" "i3-wm" "ratpoison"
                  "emacs" "emacs-exwm" "emacs-desktop-environment"
                  "xlockmore" "slock" "libreoffice"
                  "connman" "network-manager" "network-manager-applet"
diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm
index 8b117d9a20..acb2d9ead9 100644
--- a/gnu/installer/services.scm
+++ b/gnu/installer/services.scm
@@ -83,6 +83,9 @@ (define (%system-services)
      (desktop-environment
       (name "Enlightenment")
       (snippet '((service enlightenment-desktop-service-type))))
+     (desktop-environment
+      (name "Icewm")
+      (snippet '((specification->package "icewm"))))
      (desktop-environment
       (name "Openbox")
       (packages '((specification->package "openbox"))))
diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
index c8dccd38b0..b799a6752e 100644
--- a/gnu/tests/install.scm
+++ b/gnu/tests/install.scm
@@ -2013,7 +2013,7 @@ (define* (installation-target-desktop-os-for-gui-tests
     ;; Make sure that all the packages and services that may be used by the
     ;; graphical installer are available.
     (packages (append
-               (list openbox awesome i3-wm i3status
+               (list icewm openbox awesome i3-wm i3status
                      dmenu st ratpoison xterm
                      emacs emacs-exwm emacs-desktop-environment)
                %base-packages))

base-commit: fd3876ec2a47909eac8e7fa0f24710a94ccb1459
prerequisite-patch-id: 881f4620ea8e644e636c77f82f383aea28f5688f
-- 
2.46.0

Message #10 received at 76166-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Andy Tai <atai <at> atai.org>
Cc: 76166-done <at> debbugs.gnu.org
Subject: Re: [bug#76166] [PATCH] gnu: icewm: make available during instalation.
Date: Sat, 01 Mar 2025 22:58:35 +0000

[Message part 1 (text/plain, inline)]

Andy Tai <atai <at> atai.org> writes:

> * gnu/installer/services.scm (icewm): Make icewm a desktop service.
> * gnu/tests/install.scm: Make icewm an installation target for tests.
> * etc/manifests/release.scm: Make icewm available at system install.
>
> Change-Id: I881c1dd4289281e51c81d83fac785ef064e6ff6a

The changes seem OK, the commit message seemed a bit off though, I've
rewritten it as:

  installer: Include icewm as a desktop environment.

  * gnu/installer/services.scm (%system-services): Include icewm as a desktop
  environment.
  * gnu/tests/install.scm (installation-target-desktop-os-for-gui-tests): Add
  icewm to the list of packages.
  * etc/manifests/release.scm: (%system-packages): Add icewm.

I think that better reflects the actual changes being made.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.