GNU bug report logs - #76165
[PATCH] ansi-osc-directory-tracker respects Tramp remote files

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76165 in the body.
You can then email your comments to 76165 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ansi-osc-directory-tracker respects Tramp remote files
Date: Sun, 9 Feb 2025 14:05:24 -0500

[Message part 1 (text/plain, inline)]

Tramp remote forms are now retained when changes to 'default-directory' are
detected by this filter.  Previously, for example,
/ssh:hostname:/home/username would be stripped to just /home/username.

-Stephane

[Message part 2 (text/html, inline)]

[0001-ansi-osc-directory-tracker-respects-Tramp-remote-fil.patch (application/octet-stream, attachment)]

Message #8 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 09:37:00 +0530

[ஞாயிறு பிப்ரவரி 09, 2025] Ship Mints wrote:

> Tramp remote forms are now retained when changes to 'default-directory' are
> detected by this filter.  Previously, for example,
> /ssh:hostname:/home/username would be stripped to just /home/username.
>
> -Stephane
> [...]
>  This functionality serves as an alternative to `dirtrack-mode'
>  and `shell-dirtrack-mode'."
>    (let ((url (url-generic-parse-url text)))
> @@ -123,8 +128,14 @@ ansi-osc-directory-tracker
>                 (or (null (url-host url))
>                     ;; Use `downcase' to match `url-generic-parse-url' behavior
>                     (string= (url-host url) (downcase (system-name)))))
> -      (ignore-errors
> -        (cd-absolute (url-unhex-string (url-filename url)))))))
> +      (let ((current-default-directory default-directory))
> +        (when (ignore-errors
> +                (cd-absolute (url-unhex-string (url-filename url))))
> +          (when (and (fboundp 'tramp-tramp-file-p)
> +                     (tramp-tramp-file-p current-default-directory))
> +            (setq default-directory (tramp-make-tramp-file-name
> +                                     (tramp-dissect-file-name current-default-directory 'nodefault)
> +                                     default-directory))))))))
>  
>  ;; Hyperlink handling (OSC 8)

Is it necessary to invoke so many Tramp functions?  I have the following
simpler advice in my config and it has worked faithfully for many months
now.

    (define-advice comint-osc-directory-tracker (:override (_ text) vz/handle-remote-paths-as-well)
      (let ((url (url-generic-parse-url text)))
        (when (equal (url-type url) "file")
          (ignore-errors
            (let ((file (url-unhex-string (url-filename url))))
              (cd-absolute (concat (file-remote-p default-directory) file)))))))

Message #11 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 09:16:08 +0100

Visuwesh <visuweshm <at> gmail.com> writes:

Hi,

>> Tramp remote forms are now retained when changes to 'default-directory' are
>> detected by this filter.  Previously, for example,
>> /ssh:hostname:/home/username would be stripped to just /home/username.

> Is it necessary to invoke so many Tramp functions?

I agree. Internal Tramp functions, which are not documented in the
manual, shouldn't be used outside unless absolutely needed. They can
change w/o announcement.

> I have the following simpler advice in my config and it has worked
> faithfully for many months now.
>
>     (define-advice comint-osc-directory-tracker (:override (_ text) vz/handle-remote-paths-as-well)
>       (let ((url (url-generic-parse-url text)))
>         (when (equal (url-type url) "file")
>           (ignore-errors
>             (let ((file (url-unhex-string (url-filename url))))
>               (cd-absolute (concat (file-remote-p default-directory) file)))))))

file-remote-p returns nil for local file names. So I believe, this isn't
only an advertisement. It could go into ansi-osc-directory-tracker as-it-is.

Best regards, Michael.

Message #14 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76165 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 13:57:58 +0530

[திங்கள் பிப்ரவரி 10, 2025] Michael Albinus wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
> Hi,
>
>>> Tramp remote forms are now retained when changes to 'default-directory' are
>>> detected by this filter.  Previously, for example,
>>> /ssh:hostname:/home/username would be stripped to just /home/username.
>
>> Is it necessary to invoke so many Tramp functions?
>
> I agree. Internal Tramp functions, which are not documented in the
> manual, shouldn't be used outside unless absolutely needed. They can
> change w/o announcement.
>
>> I have the following simpler advice in my config and it has worked
>> faithfully for many months now.
>>
>>     (define-advice comint-osc-directory-tracker (:override (_ text) vz/handle-remote-paths-as-well)
>>       (let ((url (url-generic-parse-url text)))
>>         (when (equal (url-type url) "file")
>>           (ignore-errors
>>             (let ((file (url-unhex-string (url-filename url))))
>>               (cd-absolute (concat (file-remote-p default-directory) file)))))))
>
> file-remote-p returns nil for local file names. So I believe, this isn't
> only an advertisement. It could go into ansi-osc-directory-tracker as-it-is.

Indeed, I was following what file-remote-p says itself:

    Tip: You can use this expansion of remote identifier components
         to derive a new remote file name from an existing one.  For
         example, if FILE is "/sudo::/path/to/file" then

           (concat (file-remote-p FILE) "/bin/sh")

         returns a remote file name for file "/bin/sh" that has the
         same remote identifier as FILE but expanded; a name such as
         "/sudo:root <at> myhost:/bin/sh".
   

> Best regards, Michael.

Message #17 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 05:57:15 -0500

[Message part 1 (text/plain, inline)]

That is indeed simpler. I'd missed the "tip" that you wrote. I'll give it a
try and submit a revised patch.

On Mon, Feb 10, 2025 at 3:28 AM Visuwesh <visuweshm <at> gmail.com> wrote:

> [திங்கள் பிப்ரவரி 10, 2025] Michael Albinus wrote:
>
> > Visuwesh <visuweshm <at> gmail.com> writes:
> >
> > Hi,
> >
> >>> Tramp remote forms are now retained when changes to
> 'default-directory' are
> >>> detected by this filter.  Previously, for example,
> >>> /ssh:hostname:/home/username would be stripped to just /home/username.
> >
> >> Is it necessary to invoke so many Tramp functions?
> >
> > I agree. Internal Tramp functions, which are not documented in the
> > manual, shouldn't be used outside unless absolutely needed. They can
> > change w/o announcement.
> >
> >> I have the following simpler advice in my config and it has worked
> >> faithfully for many months now.
> >>
> >>     (define-advice comint-osc-directory-tracker (:override (_ text)
> vz/handle-remote-paths-as-well)
> >>       (let ((url (url-generic-parse-url text)))
> >>         (when (equal (url-type url) "file")
> >>           (ignore-errors
> >>             (let ((file (url-unhex-string (url-filename url))))
> >>               (cd-absolute (concat (file-remote-p default-directory)
> file)))))))
> >
> > file-remote-p returns nil for local file names. So I believe, this isn't
> > only an advertisement. It could go into ansi-osc-directory-tracker
> as-it-is.
>
> Indeed, I was following what file-remote-p says itself:
>
>     Tip: You can use this expansion of remote identifier components
>          to derive a new remote file name from an existing one.  For
>          example, if FILE is "/sudo::/path/to/file" then
>
>            (concat (file-remote-p FILE) "/bin/sh")
>
>          returns a remote file name for file "/bin/sh" that has the
>          same remote identifier as FILE but expanded; a name such as
>          "/sudo:root <at> myhost:/bin/sh".
>
>
> > Best regards, Michael.
>

[Message part 2 (text/html, inline)]

Message #20 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 06:18:50 -0500

[Message part 1 (text/plain, inline)]

Revised patch with simpler approach.

On Mon, Feb 10, 2025 at 5:57 AM Ship Mints <shipmints <at> gmail.com> wrote:

> That is indeed simpler. I'd missed the "tip" that you wrote. I'll give it
> a try and submit a revised patch.
>
> On Mon, Feb 10, 2025 at 3:28 AM Visuwesh <visuweshm <at> gmail.com> wrote:
>
>> [திங்கள் பிப்ரவரி 10, 2025] Michael Albinus wrote:
>>
>> > Visuwesh <visuweshm <at> gmail.com> writes:
>> >
>> > Hi,
>> >
>> >>> Tramp remote forms are now retained when changes to
>> 'default-directory' are
>> >>> detected by this filter.  Previously, for example,
>> >>> /ssh:hostname:/home/username would be stripped to just /home/username.
>> >
>> >> Is it necessary to invoke so many Tramp functions?
>> >
>> > I agree. Internal Tramp functions, which are not documented in the
>> > manual, shouldn't be used outside unless absolutely needed. They can
>> > change w/o announcement.
>> >
>> >> I have the following simpler advice in my config and it has worked
>> >> faithfully for many months now.
>> >>
>> >>     (define-advice comint-osc-directory-tracker (:override (_ text)
>> vz/handle-remote-paths-as-well)
>> >>       (let ((url (url-generic-parse-url text)))
>> >>         (when (equal (url-type url) "file")
>> >>           (ignore-errors
>> >>             (let ((file (url-unhex-string (url-filename url))))
>> >>               (cd-absolute (concat (file-remote-p default-directory)
>> file)))))))
>> >
>> > file-remote-p returns nil for local file names. So I believe, this isn't
>> > only an advertisement. It could go into ansi-osc-directory-tracker
>> as-it-is.
>>
>> Indeed, I was following what file-remote-p says itself:
>>
>>     Tip: You can use this expansion of remote identifier components
>>          to derive a new remote file name from an existing one.  For
>>          example, if FILE is "/sudo::/path/to/file" then
>>
>>            (concat (file-remote-p FILE) "/bin/sh")
>>
>>          returns a remote file name for file "/bin/sh" that has the
>>          same remote identifier as FILE but expanded; a name such as
>>          "/sudo:root <at> myhost:/bin/sh".
>>
>>
>> > Best regards, Michael.
>>
>

[Message part 2 (text/html, inline)]

[0001-ansi-osc-directory-tracker-respects-Tramp-remote-fil.patch (application/octet-stream, attachment)]

Message #23 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 16:51:45 +0530

[திங்கள் பிப்ரவரி 10, 2025] Ship Mints wrote:

> * lisp/ansi-osc.el (ansi-osc-directory-tracker):
> If 'default-directory' is a Tramp remote-file form, retain that form
> when 'default-directory' changes are detected.
> ---
>  etc/NEWS         | 6 ++++++
>  lisp/ansi-osc.el | 9 ++++++++-
>  2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/etc/NEWS b/etc/NEWS
> index acaa88d5574..052d4666b24 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -533,6 +533,12 @@ It removes all the buttons in the specified region.
>  'comint-complete-input-ring' ('C-x <up>') is like 'minibuffer-complete-history'
>  but completes on comint inputs.
>  
> +---
> +*** ansi-osc-directory-tracker now respects Tramp remote files.
> +Tramp remote forms are now retained when changes to 'default-directory'
> +are detected by this filter.  Previously, /ssh:hostname:/home/username
> +would be stripped to just /home/username.
> +
>  ** Eshell
>  
>  ---
> diff --git a/lisp/ansi-osc.el b/lisp/ansi-osc.el
> index bbd75033ba0..30b7d1ad738 100644
> --- a/lisp/ansi-osc.el
> +++ b/lisp/ansi-osc.el
> @@ -106,6 +106,9 @@ ansi-osc-window-title-handler
>  (declare-function url-host "url/url-parse.el")
>  (declare-function url-type "url/url-parse.el")
>  (declare-function url-filename "url/url-parse.el")
> +(declare-function tramp-tramp-file-p "tramp")
> +(declare-function tramp-make-tramp-file-name "tramp")
> +(declare-function tramp-dissect-file-name "tramp")
>  (defun ansi-osc-directory-tracker (_ text)
>    "Update `default-directory' from OSC 7 escape sequences.

This hunk can be removed now right?

Message #26 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 06:24:08 -0500

[Message part 1 (text/plain, inline)]

Thanks for reading carefully. I need some coffee (it's early morning where
I am).



On Mon, Feb 10, 2025 at 6:21 AM Visuwesh <visuweshm <at> gmail.com> wrote:

> [திங்கள் பிப்ரவரி 10, 2025] Ship Mints wrote:
>
> > * lisp/ansi-osc.el (ansi-osc-directory-tracker):
> > If 'default-directory' is a Tramp remote-file form, retain that form
> > when 'default-directory' changes are detected.
> > ---
> >  etc/NEWS         | 6 ++++++
> >  lisp/ansi-osc.el | 9 ++++++++-
> >  2 files changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/etc/NEWS b/etc/NEWS
> > index acaa88d5574..052d4666b24 100644
> > --- a/etc/NEWS
> > +++ b/etc/NEWS
> > @@ -533,6 +533,12 @@ It removes all the buttons in the specified region.
> >  'comint-complete-input-ring' ('C-x <up>') is like
> 'minibuffer-complete-history'
> >  but completes on comint inputs.
> >
> > +---
> > +*** ansi-osc-directory-tracker now respects Tramp remote files.
> > +Tramp remote forms are now retained when changes to 'default-directory'
> > +are detected by this filter.  Previously, /ssh:hostname:/home/username
> > +would be stripped to just /home/username.
> > +
> >  ** Eshell
> >
> >  ---
> > diff --git a/lisp/ansi-osc.el b/lisp/ansi-osc.el
> > index bbd75033ba0..30b7d1ad738 100644
> > --- a/lisp/ansi-osc.el
> > +++ b/lisp/ansi-osc.el
> > @@ -106,6 +106,9 @@ ansi-osc-window-title-handler
> >  (declare-function url-host "url/url-parse.el")
> >  (declare-function url-type "url/url-parse.el")
> >  (declare-function url-filename "url/url-parse.el")
> > +(declare-function tramp-tramp-file-p "tramp")
> > +(declare-function tramp-make-tramp-file-name "tramp")
> > +(declare-function tramp-dissect-file-name "tramp")
> >  (defun ansi-osc-directory-tracker (_ text)
> >    "Update `default-directory' from OSC 7 escape sequences.
>
> This hunk can be removed now right?
>

[Message part 2 (text/html, inline)]

[0001-ansi-osc-directory-tracker-respects-Tramp-remote-fil.patch (application/octet-stream, attachment)]

Message #29 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 12:31:19 +0100

Ship Mints <shipmints <at> gmail.com> writes:

Hi,

> Thanks for reading carefully. I need some coffee (it's early morning
> where I am).

Thanks. Just one (minor) remark: file-remote-p is not restricted to
Tramp. Therefore, I wouldn't mention Tramp, but just say "remote
directories".

Best regards, Michael.

Message #32 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76165 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 06:38:38 -0500

[Message part 1 (text/plain, inline)]

Guter punkt...good point...

On Mon, Feb 10, 2025 at 6:31 AM Michael Albinus <michael.albinus <at> gmx.de>
wrote:

> Ship Mints <shipmints <at> gmail.com> writes:
>
> Hi,
>
> > Thanks for reading carefully. I need some coffee (it's early morning
> > where I am).
>
> Thanks. Just one (minor) remark: file-remote-p is not restricted to
> Tramp. Therefore, I wouldn't mention Tramp, but just say "remote
> directories".
>
> Best regards, Michael.
>

[Message part 2 (text/html, inline)]

[0001-ansi-osc-directory-tracker-respects-Tramp-remote-fil.patch (application/octet-stream, attachment)]

Message #37 received at 76165-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 76165-done <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 13:21:12 +0100

Version: 31.1

Ship Mints <shipmints <at> gmail.com> writes:

Hi,

> Subject: [PATCH] ansi-osc-directory-tracker respects Tramp remote files

I've pushed this to master.  Closing the bug.

Best regards, Michael.

Message #40 received at 76165-done <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76165-done <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 18:29:17 +0530

[திங்கள் பிப்ரவரி 10, 2025] Michael Albinus wrote:

> Version: 31.1
>
> Ship Mints <shipmints <at> gmail.com> writes:
>
> Hi,
>
>> Subject: [PATCH] ansi-osc-directory-tracker respects Tramp remote files
>
> I've pushed this to master.  Closing the bug.

The concat form is ill-formed in the patch you pushed, no?

    (concat (file-remote-p default-directory
                           (url-unhex-string (url-filename url))))

should be

    (concat (file-remote-p default-directory)
            (url-unhex-string (url-filename url)))

Message #43 received at 76165-done <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 76165-done <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 08:10:26 -0500

[Message part 1 (text/plain, inline)]

I tested it. It worked by accident.

On Mon, Feb 10, 2025 at 7:59 AM Visuwesh <visuweshm <at> gmail.com> wrote:

> [திங்கள் பிப்ரவரி 10, 2025] Michael Albinus wrote:
>
> > Version: 31.1
> >
> > Ship Mints <shipmints <at> gmail.com> writes:
> >
> > Hi,
> >
> >> Subject: [PATCH] ansi-osc-directory-tracker respects Tramp remote files
> >
> > I've pushed this to master.  Closing the bug.
>
> The concat form is ill-formed in the patch you pushed, no?
>
>     (concat (file-remote-p default-directory
>                            (url-unhex-string (url-filename url))))
>
> should be
>
>     (concat (file-remote-p default-directory)
>             (url-unhex-string (url-filename url)))
>
>

[Message part 2 (text/html, inline)]

[0001-ansi-osc-directory-tracker-respects-Tramp-remote-fil.patch (application/octet-stream, attachment)]

Message #46 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 14:14:55 +0100

Visuwesh <visuweshm <at> gmail.com> writes:

Hi,

> The concat form is ill-formed in the patch you pushed, no?
>
>     (concat (file-remote-p default-directory
>                            (url-unhex-string (url-filename url))))
>
> should be
>
>     (concat (file-remote-p default-directory)
>             (url-unhex-string (url-filename url)))

Looks like, yes :-(

Since I don't know how to activate ansi-osc-directory-tracker in a shell
(where is it documented?), I couldn't test it. Could you pls advice me?

I'll fix it then.

Best regards, Michael.

Message #49 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76165 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 08:19:05 -0500

[Message part 1 (text/plain, inline)]

I sent the revised patch in my last email.

(defun my/shell-mode-hook ()
  ;; ansi-osc-directory-tracker is on by default in Emacs 28+
  (shell-dirtrack-mode -1)) ; make sure you do this

In your bashrc:

# ansi osc 7 pwd change support
function myprompt () {
  printf "\e]7;file://%s%s\e\\" "$HOSTNAME" "$PWD"
}
export PROMPT_COMMAND=myprompt

On Mon, Feb 10, 2025 at 8:15 AM Michael Albinus <michael.albinus <at> gmx.de>
wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
> Hi,
>
> > The concat form is ill-formed in the patch you pushed, no?
> >
> >     (concat (file-remote-p default-directory
> >                            (url-unhex-string (url-filename url))))
> >
> > should be
> >
> >     (concat (file-remote-p default-directory)
> >             (url-unhex-string (url-filename url)))
>
> Looks like, yes :-(
>
> Since I don't know how to activate ansi-osc-directory-tracker in a shell
> (where is it documented?), I couldn't test it. Could you pls advice me?
>
> I'll fix it then.
>
> Best regards, Michael.
>

[Message part 2 (text/html, inline)]

Message #52 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76165 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 19:02:38 +0530

[திங்கள் பிப்ரவரி 10, 2025] Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
> Hi,
>
>> The concat form is ill-formed in the patch you pushed, no?
>>
>>     (concat (file-remote-p default-directory
>>                            (url-unhex-string (url-filename url))))
>>
>> should be
>>
>>     (concat (file-remote-p default-directory)
>>             (url-unhex-string (url-filename url)))
>
> Looks like, yes :-(
>
> Since I don't know how to activate ansi-osc-directory-tracker in a shell
> (where is it documented?), I couldn't test it. Could you pls advice me?

The documentation is spread over two places:

    1. Docstring of `ansi-osc-directory-tracker' tells how to set up
       things from the shell side.
    2. You need to add `comint-osc-process-output' to
       `comint-output-filter-functions' (as the commentary following
       comint.el:3998 instructs you to).

Message #55 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76165 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 08:51:08 -0500

[Message part 1 (text/plain, inline)]

Revised shell mode hook...I missed one detail excerpting from my own.

(defun my/shell-mode-hook ()
  ;; ansi-osc-directory-tracker is on by default in Emacs 28+
in ansi-osc-handlers
  (add-hook 'comint-output-filter-functions #'comint-osc-process-output nil
'local)
  (shell-dirtrack-mode -1)) ; make sure you do this


On Mon, Feb 10, 2025 at 8:19 AM Ship Mints <shipmints <at> gmail.com> wrote:

> I sent the revised patch in my last email.
>
> (defun my/shell-mode-hook ()
>   ;; ansi-osc-directory-tracker is on by default in Emacs 28+
>   (shell-dirtrack-mode -1)) ; make sure you do this
>
> In your bashrc:
>
> # ansi osc 7 pwd change support
> function myprompt () {
>   printf "\e]7;file://%s%s\e\\" "$HOSTNAME" "$PWD"
> }
> export PROMPT_COMMAND=myprompt
>
> On Mon, Feb 10, 2025 at 8:15 AM Michael Albinus <michael.albinus <at> gmx.de>
> wrote:
>
>> Visuwesh <visuweshm <at> gmail.com> writes:
>>
>> Hi,
>>
>> > The concat form is ill-formed in the patch you pushed, no?
>> >
>> >     (concat (file-remote-p default-directory
>> >                            (url-unhex-string (url-filename url))))
>> >
>> > should be
>> >
>> >     (concat (file-remote-p default-directory)
>> >             (url-unhex-string (url-filename url)))
>>
>> Looks like, yes :-(
>>
>> Since I don't know how to activate ansi-osc-directory-tracker in a shell
>> (where is it documented?), I couldn't test it. Could you pls advice me?
>>
>> I'll fix it then.
>>
>> Best regards, Michael.
>>
>

[Message part 2 (text/html, inline)]

Message #58 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 14:55:22 +0100

Visuwesh <visuweshm <at> gmail.com> writes:

Hi,

>>>     (concat (file-remote-p default-directory)
>>>             (url-unhex-string (url-filename url)))
>>
>> Looks like, yes :-(
>>
>> Since I don't know how to activate ansi-osc-directory-tracker in a shell
>> (where is it documented?), I couldn't test it. Could you pls advice me?
>
> The documentation is spread over two places:
>
>     1. Docstring of `ansi-osc-directory-tracker' tells how to set up
>        things from the shell side.
>     2. You need to add `comint-osc-process-output' to
>        `comint-output-filter-functions' (as the commentary following
>        comint.el:3998 instructs you to).

I've fixed ansi-osc-directory-tracker as described above, and started a
test as given in the recipe. Testing on a remote host, different from my
local one.

There is the following code in ansi-osc-directory-tracker:

--8<---------------cut here---------------start------------->8---
    (when (and (string= (url-type url) "file")
               (or (null (url-host url))
                   ;; Use `downcase' to match `url-generic-parse-url' behavior
                   (string= (url-host url) (downcase (system-name)))))
      ...
--8<---------------cut here---------------end--------------->8---

But on the remote host, neither (null (url-host url)) nor (string=
(url-host url) (downcase (system-name))) return t; simply because the
host name is not nil or equal to (system-name).

Instead, the following shall be sufficient:

--8<---------------cut here---------------start------------->8---
    (when (string= (url-type url) "file")
      ...
--8<---------------cut here---------------end--------------->8---

Comments?

Best regards, Michael.

Message #61 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, michael.albinus <at> gmx.de, visuweshm <at> gmail.com
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 15:56:23 +0200

> Cc: 76165 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
> From: Ship Mints <shipmints <at> gmail.com>
> Date: Mon, 10 Feb 2025 06:18:50 -0500
> 
> +---
> +*** ansi-osc-directory-tracker now respects Tramp remote files.
> +Tramp remote forms are now retained when changes to 'default-directory'
> +are detected by this filter.  Previously, /ssh:hostname:/home/username
> +would be stripped to just /home/username.

What is a "Tramp remote form"?  The Tramp manual doesn't mention that
even once, and just by reading it, I cannot understand what it means
here.  Please clarify.

Message #64 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 76165 <at> debbugs.gnu.org, michael.albinus <at> gmx.de, visuweshm <at> gmail.com
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 08:57:41 -0500

[Message part 1 (text/plain, inline)]

A later patch altered that reference.

On Mon, Feb 10, 2025 at 8:57 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Cc: 76165 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
> > From: Ship Mints <shipmints <at> gmail.com>
> > Date: Mon, 10 Feb 2025 06:18:50 -0500
> >
> > +---
> > +*** ansi-osc-directory-tracker now respects Tramp remote files.
> > +Tramp remote forms are now retained when changes to 'default-directory'
> > +are detected by this filter.  Previously, /ssh:hostname:/home/username
> > +would be stripped to just /home/username.
>
> What is a "Tramp remote form"?  The Tramp manual doesn't mention that
> even once, and just by reading it, I cannot understand what it means
> here.  Please clarify.
>

[Message part 2 (text/html, inline)]

Message #67 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 76165 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>,
 visuweshm <at> gmail.com
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 15:01:07 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> +*** ansi-osc-directory-tracker now respects Tramp remote files.
>> +Tramp remote forms are now retained when changes to 'default-directory'
>> +are detected by this filter.  Previously, /ssh:hostname:/home/username
>> +would be stripped to just /home/username.
>
> What is a "Tramp remote form"?  The Tramp manual doesn't mention that
> even once, and just by reading it, I cannot understand what it means
> here.  Please clarify.

"Remote directories" in this case. I've fixed this already in NEWS.

Best regards, Michael.

Message #70 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76165 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 19:41:05 +0530

[திங்கள் பிப்ரவரி 10, 2025] Michael Albinus wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
> Hi,
>
>>>>     (concat (file-remote-p default-directory)
>>>>             (url-unhex-string (url-filename url)))
>>>
>>> Looks like, yes :-(
>>>
>>> Since I don't know how to activate ansi-osc-directory-tracker in a shell
>>> (where is it documented?), I couldn't test it. Could you pls advice me?
>>
>> The documentation is spread over two places:
>>
>>     1. Docstring of `ansi-osc-directory-tracker' tells how to set up
>>        things from the shell side.
>>     2. You need to add `comint-osc-process-output' to
>>        `comint-output-filter-functions' (as the commentary following
>>        comint.el:3998 instructs you to).
>
> I've fixed ansi-osc-directory-tracker as described above, and started a
> test as given in the recipe. Testing on a remote host, different from my
> local one.
>
> There is the following code in ansi-osc-directory-tracker:
>
>     (when (and (string= (url-type url) "file")
>                (or (null (url-host url))
>                    ;; Use `downcase' to match `url-generic-parse-url' behavior
>                    (string= (url-host url) (downcase (system-name)))))
>       ...
>
>
> But on the remote host, neither (null (url-host url)) nor (string=
> (url-host url) (downcase (system-name))) return t; simply because the
> host name is not nil or equal to (system-name).
>
> Instead, the following shall be sufficient:
>
>     (when (string= (url-type url) "file")
>       ...
>
> Comments?

That reminds me why my :override advice was simpler.  Indeed, I had to
get rid of that test to ensure that the function would work as intended
for remote shell buffers.  It never made much sense IMO and I got the
impression that it is in place as a "let's be absolutely sure" measure.
I can say that I face no issues with the test omitted thus far. It could
be a product of me being in control of $PS1 for local and remote shells
though.

> Best regards, Michael.

Message #73 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 09:12:36 -0500

[Message part 1 (text/plain, inline)]

Maybe we ask Augusto Stoffel what he had in mind with his URL handling
approach to begin with? It's been in the code for something like 5 years.

On Mon, Feb 10, 2025 at 9:11 AM Visuwesh <visuweshm <at> gmail.com> wrote:

> [திங்கள் பிப்ரவரி 10, 2025] Michael Albinus wrote:
>
> > Visuwesh <visuweshm <at> gmail.com> writes:
> >
> > Hi,
> >
> >>>>     (concat (file-remote-p default-directory)
> >>>>             (url-unhex-string (url-filename url)))
> >>>
> >>> Looks like, yes :-(
> >>>
> >>> Since I don't know how to activate ansi-osc-directory-tracker in a
> shell
> >>> (where is it documented?), I couldn't test it. Could you pls advice me?
> >>
> >> The documentation is spread over two places:
> >>
> >>     1. Docstring of `ansi-osc-directory-tracker' tells how to set up
> >>        things from the shell side.
> >>     2. You need to add `comint-osc-process-output' to
> >>        `comint-output-filter-functions' (as the commentary following
> >>        comint.el:3998 instructs you to).
> >
> > I've fixed ansi-osc-directory-tracker as described above, and started a
> > test as given in the recipe. Testing on a remote host, different from my
> > local one.
> >
> > There is the following code in ansi-osc-directory-tracker:
> >
> >     (when (and (string= (url-type url) "file")
> >                (or (null (url-host url))
> >                    ;; Use `downcase' to match `url-generic-parse-url'
> behavior
> >                    (string= (url-host url) (downcase (system-name)))))
> >       ...
> >
> >
> > But on the remote host, neither (null (url-host url)) nor (string=
> > (url-host url) (downcase (system-name))) return t; simply because the
> > host name is not nil or equal to (system-name).
> >
> > Instead, the following shall be sufficient:
> >
> >     (when (string= (url-type url) "file")
> >       ...
> >
> > Comments?
>
> That reminds me why my :override advice was simpler.  Indeed, I had to
> get rid of that test to ensure that the function would work as intended
> for remote shell buffers.  It never made much sense IMO and I got the
> impression that it is in place as a "let's be absolutely sure" measure.
> I can say that I face no issues with the test omitted thus far. It could
> be a product of me being in control of $PS1 for local and remote shells
> though.
>
> > Best regards, Michael.
>

[Message part 2 (text/html, inline)]

Message #76 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 15:19:53 +0100

Visuwesh <visuweshm <at> gmail.com> writes:

Hi,

> That reminds me why my :override advice was simpler.  Indeed, I had to
> get rid of that test to ensure that the function would work as intended
> for remote shell buffers.  It never made much sense IMO and I got the
> impression that it is in place as a "let's be absolutely sure" measure.
> I can say that I face no issues with the test omitted thus far. It could
> be a product of me being in control of $PS1 for local and remote shells
> though.

Well. The host part of the URL could be anything, and must not be the
same like the current host name. So perhaps the check could be like
this, "to be absolutely sure":

--8<---------------cut here---------------start------------->8---
  (when-let* ((url (url-generic-parse-url text))
              ((string= (url-type url) "file"))
              ((or (null (url-host url))
                   ;; Use `downcase' to match `url-generic-parse-url' behavior
                   (string= (url-host url)
                            (downcase
                             (or (file-remote-p default-directory 'host)
                                 (system-name)))))))
    (ignore-errors
      (cd-absolute
       (concat (file-remote-p default-directory)
               (url-unhex-string (url-filename url)))))))
--8<---------------cut here---------------end--------------->8---

WDYT?

Best regards, Michael.

Message #79 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76165 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 09:24:36 -0500

[Message part 1 (text/plain, inline)]

I think that won't work for a use case where I often will initiate a
connection back to my own machine and I do want the effect of retaining
remote file semantics in default-directory?

On Mon, Feb 10, 2025 at 9:19 AM Michael Albinus <michael.albinus <at> gmx.de>
wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
> Hi,
>
> > That reminds me why my :override advice was simpler.  Indeed, I had to
> > get rid of that test to ensure that the function would work as intended
> > for remote shell buffers.  It never made much sense IMO and I got the
> > impression that it is in place as a "let's be absolutely sure" measure.
> > I can say that I face no issues with the test omitted thus far. It could
> > be a product of me being in control of $PS1 for local and remote shells
> > though.
>
> Well. The host part of the URL could be anything, and must not be the
> same like the current host name. So perhaps the check could be like
> this, "to be absolutely sure":
>
> --8<---------------cut here---------------start------------->8---
>   (when-let* ((url (url-generic-parse-url text))
>               ((string= (url-type url) "file"))
>               ((or (null (url-host url))
>                    ;; Use `downcase' to match `url-generic-parse-url'
> behavior
>                    (string= (url-host url)
>                             (downcase
>                              (or (file-remote-p default-directory 'host)
>                                  (system-name)))))))
>     (ignore-errors
>       (cd-absolute
>        (concat (file-remote-p default-directory)
>                (url-unhex-string (url-filename url)))))))
> --8<---------------cut here---------------end--------------->8---
>
> WDYT?
>
> Best regards, Michael.
>

[Message part 2 (text/html, inline)]

Message #82 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 15:30:50 +0100

Ship Mints <shipmints <at> gmail.com> writes:

Hi,

> I think that won't work for a use case where I often will initiate a
> connection back to my own machine and I do want the effect of
> retaining remote file semantics in default-directory?

Don't understand the scenario. Could you give an example?

Best regards, Michael.

Message #85 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76165 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 09:33:55 -0500

[Message part 1 (text/plain, inline)]

My desktop mac's local host name is tlok.local. I open a shell buffer as
"/ssh:tlok.local:/Users/shipmints/" and as I "cd" around, I expect the
remote file prefix "/ssh:tlok.local:" to be maintained. If the host name
component is used as a discriminator, I don't get that benefit despite that
there actually is an active ssh connection. I think it should be respected
all the time as the user asked for it explicitly.

On Mon, Feb 10, 2025 at 9:31 AM Michael Albinus <michael.albinus <at> gmx.de>
wrote:

> Ship Mints <shipmints <at> gmail.com> writes:
>
> Hi,
>
> > I think that won't work for a use case where I often will initiate a
> > connection back to my own machine and I do want the effect of
> > retaining remote file semantics in default-directory?
>
> Don't understand the scenario. Could you give an example?
>
> Best regards, Michael.
>

[Message part 2 (text/html, inline)]

Message #88 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 15:47:41 +0100

Ship Mints <shipmints <at> gmail.com> writes:

Hi,

> My desktop mac's local host name is tlok.local. I open a shell buffer
> as "/ssh:tlok.local:/Users/shipmints/" and as I "cd" around, I expect
> the remote file prefix "/ssh:tlok.local:" to be maintained. If the
> host name component is used as a discriminator, I don't get that
> benefit despite that there actually is an active ssh connection. I
> think it should be respected all the time as the user asked for it
> explicitly.

I don't get it. If your default directory is
"/ssh:tlok.local:/Users/shipmints/", (file-remote-p default-directory)
always returns "/ssh:tlok.local:", and (file-remote-p default-directory 'host)
always returns "tlok.local". In the shell buffer, you cannot go to
another host.

Please give me a step-by-step scenario, if I miss something.

Best regards, Michael.

Message #91 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76165 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 10:01:43 -0500

[Message part 1 (text/plain, inline)]

Perhaps I'm misunderstanding and I'm testing a few more cases. If I spawn a
shell buffer pointing to /ssh:deb12:., a virtual Linux machine on my mac, I
expect the bash shell prompt ansi sequence to also affect the default
directory and now I can see that's not the case but I think it should be.
Testing for matching host names doesn't seem like a good idea. Doesn't
cd-absolute respect remote files? I think so. But if we block by matching
host names, we never get the remote directory reported.

On Mon, Feb 10, 2025 at 9:47 AM Michael Albinus <michael.albinus <at> gmx.de>
wrote:

> Ship Mints <shipmints <at> gmail.com> writes:
>
> Hi,
>
> > My desktop mac's local host name is tlok.local. I open a shell buffer
> > as "/ssh:tlok.local:/Users/shipmints/" and as I "cd" around, I expect
> > the remote file prefix "/ssh:tlok.local:" to be maintained. If the
> > host name component is used as a discriminator, I don't get that
> > benefit despite that there actually is an active ssh connection. I
> > think it should be respected all the time as the user asked for it
> > explicitly.
>
> I don't get it. If your default directory is
> "/ssh:tlok.local:/Users/shipmints/", (file-remote-p default-directory)
> always returns "/ssh:tlok.local:", and (file-remote-p default-directory
> 'host)
> always returns "tlok.local". In the shell buffer, you cannot go to
> another host.
>
> Please give me a step-by-step scenario, if I miss something.
>
> Best regards, Michael.
>

[Message part 2 (text/html, inline)]

Message #94 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76165 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 20:49:28 +0530

[திங்கள் பிப்ரவரி 10, 2025] Michael Albinus wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
> Hi,
>
>> That reminds me why my :override advice was simpler.  Indeed, I had to
>> get rid of that test to ensure that the function would work as intended
>> for remote shell buffers.  It never made much sense IMO and I got the
>> impression that it is in place as a "let's be absolutely sure" measure.
>> I can say that I face no issues with the test omitted thus far. It could
>> be a product of me being in control of $PS1 for local and remote shells
>> though.
>
> Well. The host part of the URL could be anything, and must not be the
> same like the current host name. So perhaps the check could be like
> this, "to be absolutely sure":
>
>   (when-let* ((url (url-generic-parse-url text))
>               ((string= (url-type url) "file"))
>               ((or (null (url-host url))
>                    ;; Use `downcase' to match `url-generic-parse-url' behavior
>                    (string= (url-host url)
>                             (downcase
>                              (or (file-remote-p default-directory 'host)
>                                  (system-name)))))))
>     (ignore-errors
>       (cd-absolute
>        (concat (file-remote-p default-directory)
>                (url-unhex-string (url-filename url)))))))
>
> WDYT?

This unfortunately breaks down in my use case.  In my .ssh/config I have
for a host:

    Host remote-n2
        User user
        Hostname node2
        ProxyJump remote

and when I create a remote shell buffer with

    (shell "*remote*" "/ssh:user <at> remote-n2:~")

and say

    remote-n2% cd ~/.ssh
    remote-n2% pwd
    /home/user/.ssh

evaluating

    default-directory ;; => "/ssh:user <at> remote-n2:/home/user/"

shows instead.  This is all because $HOSTNAME is not actually remote-n2
but "node2":

    remote-n2% echo $HOSTNAME
    node2
    remote-n2% echo $PS1
    \[\e]7;file://\H$PWD\e\\\]remote-n2%

Although I am not sure how common this type of scenario is where the
hostname as Tramp knows it and $HOSTNAME is mismatched.

Message #97 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 10:29:32 -0500

[Message part 1 (text/plain, inline)]

I also alias host names in ssh config, yep. It's very common for the ssh
"spec" and the reported host name to be different. The ansi sequences must
be respected in these cases.

On Mon, Feb 10, 2025 at 10:19 AM Visuwesh <visuweshm <at> gmail.com> wrote:

> [திங்கள் பிப்ரவரி 10, 2025] Michael Albinus wrote:
>
> > Visuwesh <visuweshm <at> gmail.com> writes:
> >
> > Hi,
> >
> >> That reminds me why my :override advice was simpler.  Indeed, I had to
> >> get rid of that test to ensure that the function would work as intended
> >> for remote shell buffers.  It never made much sense IMO and I got the
> >> impression that it is in place as a "let's be absolutely sure" measure.
> >> I can say that I face no issues with the test omitted thus far. It could
> >> be a product of me being in control of $PS1 for local and remote shells
> >> though.
> >
> > Well. The host part of the URL could be anything, and must not be the
> > same like the current host name. So perhaps the check could be like
> > this, "to be absolutely sure":
> >
> >   (when-let* ((url (url-generic-parse-url text))
> >               ((string= (url-type url) "file"))
> >               ((or (null (url-host url))
> >                    ;; Use `downcase' to match `url-generic-parse-url'
> behavior
> >                    (string= (url-host url)
> >                             (downcase
> >                              (or (file-remote-p default-directory 'host)
> >                                  (system-name)))))))
> >     (ignore-errors
> >       (cd-absolute
> >        (concat (file-remote-p default-directory)
> >                (url-unhex-string (url-filename url)))))))
> >
> > WDYT?
>
> This unfortunately breaks down in my use case.  In my .ssh/config I have
> for a host:
>
>     Host remote-n2
>         User user
>         Hostname node2
>         ProxyJump remote
>
> and when I create a remote shell buffer with
>
>     (shell "*remote*" "/ssh:user <at> remote-n2:~")
>
> and say
>
>     remote-n2% cd ~/.ssh
>     remote-n2% pwd
>     /home/user/.ssh
>
> evaluating
>
>     default-directory ;; => "/ssh:user <at> remote-n2:/home/user/"
>
> shows instead.  This is all because $HOSTNAME is not actually remote-n2
> but "node2":
>
>     remote-n2% echo $HOSTNAME
>     node2
>     remote-n2% echo $PS1
>     \[\e]7;file://\H$PWD\e\\\]remote-n2%
>
> Although I am not sure how common this type of scenario is where the
> hostname as Tramp knows it and $HOSTNAME is mismatched.
>

[Message part 2 (text/html, inline)]

Message #100 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 76165 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 16:40:08 +0100

Ship Mints <shipmints <at> gmail.com> writes:

Hi,

> I also alias host names in ssh config, yep. It's very common for the
> ssh "spec" and the reported host name to be different. The ansi
> sequences must be respected in these cases.

Understood. Finally, I've pushed a fix to master w/o checking host
names. Pls see whether this works as expected.

Best regards, Michael.

Message #103 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76165 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 10:55:16 -0500

[Message part 1 (text/plain, inline)]

I confirm that works. Thank you for your help with this.

On Mon, Feb 10, 2025 at 10:40 AM Michael Albinus <michael.albinus <at> gmx.de>
wrote:

> Ship Mints <shipmints <at> gmail.com> writes:
>
> Hi,
>
> > I also alias host names in ssh config, yep. It's very common for the
> > ssh "spec" and the reported host name to be different. The ansi
> > sequences must be respected in these cases.
>
> Understood. Finally, I've pushed a fix to master w/o checking host
> names. Pls see whether this works as expected.
>
> Best regards, Michael.
>

[Message part 2 (text/html, inline)]

Message #106 received at 76165 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76165 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>
Subject: Re: bug#76165: [PATCH] ansi-osc-directory-tracker respects Tramp
 remote files
Date: Mon, 10 Feb 2025 21:34:07 +0530

[திங்கள் பிப்ரவரி 10, 2025] Michael Albinus wrote:

> Ship Mints <shipmints <at> gmail.com> writes:
>
> Hi,
>
>> I also alias host names in ssh config, yep. It's very common for the
>> ssh "spec" and the reported host name to be different. The ansi
>> sequences must be respected in these cases.
>
> Understood. Finally, I've pushed a fix to master w/o checking host
> names. Pls see whether this works as expected.

Thank you, it works as expected.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.