GNU bug report logs - #76120
[PATCH] Expose the native sharing dialog (macOS)

Previous Next

Full log

Message #433 received at 76120 <at> debbugs.gnu.org (full text, mbox):

From: Alvaro Ramirez <alvaro <at> xenodium.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Gerd Möllmann <gerd.moellmann <at> gmail.com>,
 76120 <at> debbugs.gnu.org, alan <at> idiocy.org, rpluim <at> gmail.com,
 stefankangas <at> gmail.com
Subject: Re: bug#76120: This feature is not about "sharing", or a "native"
 anything.
Date: Sat, 19 Jul 2025 15:03:57 +0100

> On 19 Jul 2025, at 14:03, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
>> Cc: Eli Zaretskii <eliz <at> gnu.org>,  Alan Third <alan <at> idiocy.org>,  Robert
>> Pluim <rpluim <at> gmail.com>,  stefankangas <at> gmail.com,  76120 <at> debbugs.gnu.org
>> Date: Sat, 19 Jul 2025 14:22:23 +0200
>> 
>> Alvaro Ramirez <alvaro <at> xenodium.com> writes:
>> 
>>> Thank you Gerd for volunteering to verify the patch and Eli for
>>> reaching out to others!
>>> 
>>> Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:
>>> 
>>>> I can do that if you send me the latest version of the patch,
>>>> Alvaro.
>>>> The bug thread is a bit tl;dr.
>>> 
>>> Rebased and attached
>>> (0007-Add-Send-to.-context-menu-item-to-mouse.el.patch).
>>> 
>>> 1. M-x context-menu-mode (enables minor mode).
>>> 2. Right click buffer to open context menu.
>>> 3. Select "Send to..."
>>> 
>>> "Send to..." can be applied to either:
>>> 
>>> - Dired files (single or multiple files).
>>> - Current buffer (if there's an associated file).
>>> - Selected region (selected text is sent).
>> 
>> Thanks, builds, works, and is now in master.
> 
> Thanks!
> 
> Alvaro, there's a bug in send-to.el.  Here:
> 
>    (dolist (item items)
>      (with-temp-buffer
>        (unless (zerop (call-process
>                        shell-command-guess-open nil (current-buffer) t
>                        (send-to--convert-item-to-filename
>                         item)))
>          (error "%s" (string-trim (buffer-string))))))))
> 
> This passes the result of shell-command-guess-open to call-process,
> but shell-command-guess-open returns a _shell_command_, not a program
> name.  So the code should call call-process-shell-command or maybe
> process-file-shell-command.

Thanks for spotting Eli. I missed this.

It passed on macOS (wrongfully), as shell-command-guess-open returned “open”.

I’ll fix it.

> For example, on MS-Windows shell-command-guess-open returns the
> command "start", but it is not necessarily the name of a program, it
> is usually a built-in command of the Windows shell.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.