GNU bug report logs - #76120
[PATCH] Expose the native sharing dialog (macOS)

Previous Next

Full log

View this message in rfc822 format

From: Visuwesh <visuweshm <at> gmail.com>
To: Alvaro Ramirez <alvaro <at> xenodium.com>
Cc: Rudolf Adamkovič <rudolf <at> adamkovic.org>, rms <at> gnu.org, Juri Linkov <juri <at> linkov.net>, 76120 <at> debbugs.gnu.org, stefankangas <at> gmail.com, Eli Zaretskii <eliz <at> gnu.org>
Subject: bug#76120: This feature is not about "sharing", or a "native" anything.
Date: Sat, 15 Mar 2025 18:06:48 +0530

[சனி மார்ச் 15, 2025] Visuwesh wrote:

One minor nit:

>> +(defun context-menu-send-to (menu _click)
>> +  "Add a \"Send to...\" context MENU entry on supported platforms."
>> +  (run-hooks 'activate-menubar-hook 'menu-bar-update-hook)
>> +  (when (send-to-supported-p)
>> +    (define-key-after menu [separator-send] menu-bar-separator)
>> +    (define-key-after menu [send]
>> +      '(menu-item "Send to..." (lambda ()
>> +                                 (interactive)
>> +                                 (send-to))
>> +                  :help
>> +                  "Send item (region, buffer file, or Dired files) to app or service")))
>> +  menu)

This should ideally be

(save-excursion
  (mouse-set-point click)
  (when (send-to-supported-p)
    ...))

because otherwise dired-get-filename will pick up the filename at point,
instead of at click.  See dired-context-menu as well.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.