GNU bug report logs - #76120
[PATCH] Expose the native sharing dialog (macOS)

Previous Next

Full log

View this message in rfc822 format

From: Rudolf Adamkovič <rudolf <at> adamkovic.org>
To: Alvaro Ramirez <alvaro <at> xenodium.com>, Eli Zaretskii <eliz <at> gnu.org>, stefankangas <at> gmail.com
Cc: 76120 <at> debbugs.gnu.org, rms <at> gnu.org, shipmints <at> gmail.com
Subject: bug#76120: This feature is not about "sharing", or a "native" anything.
Date: Wed, 26 Feb 2025 11:38:19 +0100

Alvaro Ramirez <alvaro <at> xenodium.com> writes:

> Attaching the latest iteration of the patch (renamed
> 0004-Add-Send-to-context-menu-item-to-mouse-el.patch)..

Below are a couple of comments, if you are interested in feedback.

> * lisp/send-to.el: New package implements sending to apps or services.

The verb sending needs an object, i.e. sending what?

> +(non-Emacs) apps or services. See send-to.el for customisations.

Two spaces should separate sentences.

> + "Send item (region, buffer file, or dired files) to app or service")))

Dired is a proper noun and so should be capitalized.

> +(defgroup send-to nil
> +  "Send files or text to external applications or services."
> +  :group 'external
> +  :version "31.1")

Inconsistent terminology: the patch says "apps" everywhere else.

(Personally, I am for saying "applications" everywhere.)

> + (error "Don't know how to sende %s (adjust `send-to-handler-function')"

A typo in the word send.

Thank you for your work on the patch!

Rudy
-- 
"One can begin to reason only when a clear picture has been formed in
the imagination."
--- Walter Warwick Sawyer, Mathematician's Delight, 1943

Rudolf Adamkovič <rudolf <at> adamkovic.org> [he/him]
http://adamkovic.org

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.