GNU bug report logs - #76120
[PATCH] Expose the native sharing dialog (macOS)

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Alvaro Ramirez <alvaro <at> xenodium.com>
Cc: 76120 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, stefankangas <at> gmail.com, shipmints <at> gmail.com, rms <at> gnu.org
Subject: bug#76120: This feature is not about "sharing", or a "native" anything.
Date: Thu, 20 Feb 2025 19:16:52 +0200

> +(defun send-to--default-support-checker-p ()
> +  "Return non-nil for platforms supporting send capability."
> +  (or (and (featurep 'ns) (fboundp 'ns-send-items))
> +      (executable-find "xdg-open")))
> [...]
> +        ((executable-find "xdg-open")
> +         (when (y-or-n-p (format "Open externally: %s ?"
> +                                 (send-to--format-items items)))
> +           (dolist (item items)
> +             (with-temp-buffer
> +               (unless (zerop (call-process
> +                               "xdg-open" nil (current-buffer) t
> +                               (send-to--convert-item-to-filename
> +                                item)))

No need to duplicate (executable-find "xdg-open")
since it already exists in shell-command-guess-open
used by shell-command-do-open.

All the code with the name prefix shell-command-*
should be moved from dired-aux.el to a new file.

Then your code can be added to the same file.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.