GNU bug report logs - #75964
Switching the Emacs build to -Wswitch-enum in src/

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Pip Cet <pipcet <at> protonmail.com>
Cc: eggert <at> cs.ucla.edu, 75964 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: bug#75964: Switching the Emacs build to -Wswitch-enum in src/
Date: Sun, 02 Feb 2025 10:49:43 +0200

> Cc: 75964 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>
> Date: Sun, 02 Feb 2025 08:39:11 +0000
> From:  Pip Cet via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> I think we should enable -Wswitch-enum now, and expect it to generate
> more warnings in the future.

I'm not sure I understand what "in the future" means here, but please
don't add warning options that will generate warnings while compiling
the current sources; if they do, either the source code should be
fixed to avoid the warnings before the warning option is turned on by
default, or the warning option should not be turned on by default.  We
strive to have the current sources compile cleanly with the default
warning options, so that any warning draws attention and is fixed
ASAP; thus, having compilation warnings routinely emitted that cannot
be easily fixed is not a good idea because that causes people to
ignore warnings.

Apologies if the above is not relevant to what you were discussing
regarding adding warning options.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.