GNU bug report logs - #75963
[PATCH] gnu: python-clingo: Build from sources.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75963 in the body.
You can then email your comments to 75963 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: python-clingo: Build from sources.
Date: Fri, 31 Jan 2025 10:15:48 +0100

* gnu/packages/potassco.scm (clingo)[source]: Also delete
“libpyclingo/_clingo.c”.
(python-clingo)[#:phases]: Add ‘generate-sources’.  Remove ‘fix-failing-tests’.
---
 gnu/packages/potassco.scm | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/potassco.scm b/gnu/packages/potassco.scm
index 4da4b03328..43e56ec8bf 100644
--- a/gnu/packages/potassco.scm
+++ b/gnu/packages/potassco.scm
@@ -162,7 +162,8 @@ (define-public clingo
                #~(begin
                    (delete-file-recursively "clasp")
                    (delete-file-recursively "libgringo/gen")
-                   (delete-file-recursively "third_party")))
+                   (delete-file-recursively "third_party")
+                   (delete-file "libpyclingo/_clingo.c")))
               (sha256
                (base32
                 "1mxl3gwx55sf2ifcb92mfy989c50yqpnq0d0r2mxdqr0riy40hjb"))))
@@ -442,13 +443,10 @@ (define-public python-clingo
           (guix build utils)))
        ((#:phases phases #~%standard-phases)
         #~(modify-phases #$phases
-            (add-after 'unpack 'fix-failing-tests
+            (add-after 'unpack 'generate-sources
               (lambda _
-                (substitute* "libpyclingo/clingo/tests/test_conf.py"
-                  (("ctl\\.solve\\(on_statistics=on_statistics\\)" all)
-                   (string-append
-                    all
-                    "; self.skipTest(\"You shall not fail.\")")))))
+                (with-directory-excursion "libpyclingo"
+                  (invoke "python" "compile.py" "c"))))
             (add-after 'install 'install-distinfo
               (lambda* (#:key inputs outputs #:allow-other-keys)
                 (with-directory-excursion (python:site-packages inputs outputs)

base-commit: 5a6c66f7919fbe79251cd425ae6952e67acbe94c
prerequisite-patch-id: 89253557678bf26bc3fbd565a909d5ae9cdd49d3
prerequisite-patch-id: 4b946c39b233b199f3d4ab06228ec3a0e00418af
prerequisite-patch-id: dfd16e70832703c898b46430d2d65f5d4bdc7498
-- 
2.47.1

Message #10 received at 75963-done <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: 75963-done <at> debbugs.gnu.org, "Liliana Marie Prikler"
 <liliana.prikler <at> gmail.com>
Subject: Re: [PATCH] gnu: python-clingo: Build from sources.
Date: Mon, 03 Feb 2025 23:55:08 +0000

Applied, thanks!

all best,

jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.