GNU bug report logs - #75964
Switching the Emacs build to -Wswitch-enum in src/

Previous Next

Full log

Message #230 received at 75964 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: pipcet <at> protonmail.com, eggert <at> cs.ucla.edu, 75964 <at> debbugs.gnu.org
Subject: Re: bug#75964: Switching the Emacs build to -Wswitch-enum in src/
Date: Thu, 06 Feb 2025 10:17:38 +0200

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Wed, 5 Feb 2025 14:20:12 -0800
> Cc: pipcet <at> protonmail.com, 75964 <at> debbugs.gnu.org
> 
> Paul Eggert <eggert <at> cs.ucla.edu> writes:
> 
> >> I very much doubt these techniques will make our situation
> >> significantly better, if at all.
> >
> > Admittedly Emacs has more serious bugs than enum mismatches. However,
> > checking these mismatches can help find mistakes or help clarify code.
> 
> We had Bug#75712, for example, which I believe Pip Cet found by enabling
> -Wswitch-enum.  It would be nice to catch such bugs statically.

It IMO is okay to use special GCC switches for hunting hidden bugs,
but that doesn't mean we need to use those switches by default,
especially if that requires us to make problematic changes to our
code.  Please don't forget that many people who track the development
branches are not themselves Emacs developers.

We could have a special non-default configure option for adding
"noisy" warning options; many projects do that.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.