GNU bug report logs - #7596
23.2.90; fill-flowed with DELETE-SPACE option does not work

Previous Next

Full log

View this message in rfc822 format

From: Chong Yidong <cyd <at> stupidchicken.com>
To: ding <at> gnus.org
Cc: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>, 7596 <at> debbugs.gnu.org
Subject: bug#7596: 23.2.90; fill-flowed with DELETE-SPACE option does not work
Date: Sat, 22 Jan 2011 14:31:52 -0500

Kazuhiro Ito <kzhr <at> d1.dion.ne.jp> writes:

> (with-temp-buffer
>   (insert "ABC \nDEF")
>   (fill-flowed nil t)
>   (buffer-string))
> It returns
> "ABC
> DEF"
> But I expect
> "ABCDEF"
> I expect DELETE-SPACE option corresponds to "DelSp" parameter in
> RFC3676 and works so.  Plesse see attached patch.

Could a Gnus developer please review Kazuhiro Ito's patch?  Thanks.

--- lisp/gnus/flow-fill.el	2010-01-13 08:35:10 +0000
+++ lisp/gnus/flow-fill.el	2010-12-08 10:14:13 +0000
@@ -106,8 +106,6 @@
       (forward-line 1))
     (goto-char (point-min))
     (while (re-search-forward " $" nil t)
-      (when delete-space
-	(delete-char -1))
       (when (save-excursion
 	      (beginning-of-line)
 	      (looking-at "^\\(>*\\)\\( ?\\)"))
@@ -135,6 +133,8 @@
 	      (replace-match (if (string= (match-string 2) " ")
 				 "" "\\2")))
 	    (backward-delete-char -1)
+	    (when delete-space
+	      (delete-char -1))
 	    (end-of-line))
 	  (unless sig
 	    (condition-case nil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.