GNU bug report logs - #7596
23.2.90; fill-flowed with DELETE-SPACE option does not work

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7596 in the body.
You can then email your comments to 7596 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.2.90; fill-flowed with DELETE-SPACE option does not work
Date: Thu, 09 Dec 2010 08:48:00 +0900

[Message part 1 (text/plain, inline)]

When I start emacs (emacs-23 branch) with -Q and evaluate below code,
I receive unexpected result.

(with-temp-buffer
  (insert "ABC \nDEF")
  (fill-flowed nil t)
  (buffer-string))

It returns 

"ABC
DEF"

But I expect 

"ABCDEF"


I expect DELETE-SPACE option corresponds to "DelSp" parameter in
RFC3676 and works so.  Plesse see attached patch.

-- 
Kazuhiro Ito

[flow-fill.el.diff (application/octet-stream, attachment)]

Message #8 received at 7596 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: ding <at> gnus.org
Cc: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>, 7596 <at> debbugs.gnu.org
Subject: Re: bug#7596: 23.2.90;
	fill-flowed with DELETE-SPACE option does not work
Date: Sat, 22 Jan 2011 14:31:52 -0500

Kazuhiro Ito <kzhr <at> d1.dion.ne.jp> writes:

> (with-temp-buffer
>   (insert "ABC \nDEF")
>   (fill-flowed nil t)
>   (buffer-string))
> It returns
> "ABC
> DEF"
> But I expect
> "ABCDEF"
> I expect DELETE-SPACE option corresponds to "DelSp" parameter in
> RFC3676 and works so.  Plesse see attached patch.

Could a Gnus developer please review Kazuhiro Ito's patch?  Thanks.

--- lisp/gnus/flow-fill.el	2010-01-13 08:35:10 +0000
+++ lisp/gnus/flow-fill.el	2010-12-08 10:14:13 +0000
@@ -106,8 +106,6 @@
       (forward-line 1))
     (goto-char (point-min))
     (while (re-search-forward " $" nil t)
-      (when delete-space
-	(delete-char -1))
       (when (save-excursion
 	      (beginning-of-line)
 	      (looking-at "^\\(>*\\)\\( ?\\)"))
@@ -135,6 +133,8 @@
 	      (replace-match (if (string= (match-string 2) " ")
 				 "" "\\2")))
 	    (backward-delete-char -1)
+	    (when delete-space
+	      (delete-char -1))
 	    (end-of-line))
 	  (unless sig
 	    (condition-case nil

Message #13 received at 7596-close <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>, 7596-close <at> debbugs.gnu.org,
	ding <at> gnus.org
Subject: Re: bug#7596: 23.2.90;
	fill-flowed with DELETE-SPACE option does not work
Date: Sat, 22 Jan 2011 20:48:49 +0100

Chong Yidong <cyd <at> stupidchicken.com> writes:

>> I expect DELETE-SPACE option corresponds to "DelSp" parameter in
>> RFC3676 and works so.  Plesse see attached patch.
>
> Could a Gnus developer please review Kazuhiro Ito's patch?  Thanks.

It looks reasonable to me.  I've applied the patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi <at> gnus.org * Lars Magne Ingebrigtsen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.