GNU bug report logs - #75598
[PATCH] Quote identifiers in SQL queries in sqlite-mode

Previous Next

Package: emacs;

Reported by: git <at> cy.md

Date: Thu, 16 Jan 2025 04:16:02 UTC

Severity: wishlist

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#75598: closed ([PATCH] Quote identifiers in SQL queries in
 sqlite-mode)
Date: Sat, 25 Jan 2025 09:17:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 25 Jan 2025 11:16:28 +0200
with message-id <865xm3w8wj.fsf <at> gnu.org>
and subject line Re: bug#75598: [PATCH] Quote identifiers in SQL queries in sqlite-mode
has caused the debbugs.gnu.org bug report #75598,
regarding [PATCH] Quote identifiers in SQL queries in sqlite-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
75598: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75598
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: git <at> cy.md
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Quote identifiers in SQL queries in sqlite-mode
Date: Wed, 15 Jan 2025 18:38:51 +0000
[Message part 3 (text/plain, inline)]
Tags: patch


The sqlite-mode package does not quote identifiers (table and column
names) in the SQL queries it performs. As a result, it e.g. cannot open
databases which have a table called "values".

Here is a patch which fixes it for me.

Reference: https://www.sqlite.org/lang_keywords.html

In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.18.0, Xaw3d scroll bars)
Windowing system distributor 'The X.Org Foundation', version 11.0.12101015
System Description: Arch Linux

Configured using:
 'configure
 --prefix=/nix/store/mzdvpxzkhlryxmbxwbih7bgvkzkw1ly7-emacs-29.1
 --disable-build-details --with-modules --with-x-toolkit=lucid
 --with-xft --with-cairo --with-compress-install
 --with-toolkit-scroll-bars --with-native-compilation
 --without-imagemagick --without-small-ja-dic --with-tree-sitter
 --with-xinput2 --without-xwidgets'

[0001-Quote-identifiers-in-SQL-queries-in-sqlite-mode.patch (text/patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: git <at> cy.md
Cc: 75598-done <at> debbugs.gnu.org
Subject: Re: bug#75598: [PATCH] Quote identifiers in SQL queries in sqlite-mode
Date: Sat, 25 Jan 2025 11:16:28 +0200
> Date: Wed, 15 Jan 2025 18:38:51 +0000
> From: git--- via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> The sqlite-mode package does not quote identifiers (table and column
> names) in the SQL queries it performs. As a result, it e.g. cannot open
> databases which have a table called "values".
> 
> Here is a patch which fixes it for me.
> 
> Reference: https://www.sqlite.org/lang_keywords.html

Thanks, installed on the master branch, and closing the bug.


This bug report was last modified 118 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.