GNU bug report logs - #75597
[PATCH} gnu: emacs-eglot-x: Update to latest commit

Previous Next

To reply to this bug, email your comments to 75597 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Javier Olaechea <pirata <at> gmail.com>
To: guix-patches <at> gnu.org, Andrew Tropin <andrew <at> trop.in>,
 divya <at> subvertising.org, 
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: [PATCH} gnu: emacs-eglot-x: Update to latest commit
Date: Thu, 16 Jan 2025 03:29:28 +0000

[Message part 1 (text/plain, inline)]

Hi, attached is a patch to update eglot-x to its latest commit, unreleased
to fix. It does fix an error that ocurrs when using eglot-x with an eglot
version 1.16 or higher and rust-analyzer. Should I also use the git-version
helper?

Cheers,
Javier Olaechea

-- 
"I object to doing things that computers can do." — Olin Shivers

[Message part 2 (text/html, inline)]

[0001-gnu-emacs-eglot-x-Update-to-latest-commit.patch (text/x-patch, attachment)]

Message #8 received at 75597 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Javier Olaechea <pirata <at> gmail.com>, 75597 <at> debbugs.gnu.org, Andrew Tropin
 <andrew <at> trop.in>, divya <at> subvertising.org, Katherine Cox-Buday
 <cox.katherine.e+guix <at> gmail.com>
Subject: Re: [PATCH} gnu: emacs-eglot-x: Update to latest commit
Date: Thu, 16 Jan 2025 08:46:09 +0100

Am Donnerstag, dem 16.01.2025 um 03:29 +0000 schrieb Javier Olaechea:
> Hi, attached is a patch to update eglot-x to its latest commit,
> unreleased to fix. It does fix an error that ocurrs when using eglot-
> x with an eglot version 1.16 or higher and rust-analyzer. Should I
> also use the git-version helper?
Yes, please use git-version.

And for anyone else using random commits while coding version without
it, let this be a reminder to use git-version.

Btw. you reference commit 354150c in your patch but then build from a
different commit.  Perhaps you could use that single commit as a patch
instead?

Cheers

Message #11 received at 75597 <at> debbugs.gnu.org (full text, mbox):

From: Javier Olaechea <pirata <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 75597 <at> debbugs.gnu.org, Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 divya <at> subvertising.org, Andrew Tropin <andrew <at> trop.in>
Subject: Re: [PATCH} gnu: emacs-eglot-x: Update to latest commit
Date: Fri, 17 Jan 2025 02:09:30 +0000

[Message part 1 (text/plain, inline)]

Thanks for the quick response!

Btw. you reference commit 354150c in your patch but then build from a
> different commit.  Perhaps you could use that single commit as a patch
> instead?
>

I like that better, I've updated the patch to instead apply the patch for
that commit instead along with a note to drop the patch when the next
version of eglot-x is released.


On Thu, Jan 16, 2025 at 7:46 AM Liliana Marie Prikler <
liliana.prikler <at> gmail.com> wrote:

> Yes, please use git-version.
>
> And for anyone else using random commits while coding version without
> it, let this be a reminder to use git-version.
>

Given that now we are using the commit for version 0.6 (which doesn't have
a tag) there is no need to to use git-version. t was only in the case that
we started shipping an unreleased commit as the version, correct?

-- 
"I object to doing things that computers can do." — Olin Shivers

[Message part 2 (text/html, inline)]

[v2-0001-gnu-emacs-eglot-x-Backport-an-unreleased-fix.patch (text/x-patch, attachment)]

Message #14 received at 75597 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Javier Olaechea <pirata <at> gmail.com>
Cc: 75597 <at> debbugs.gnu.org, Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 divya <at> subvertising.org, Andrew Tropin <andrew <at> trop.in>
Subject: Re: [PATCH} gnu: emacs-eglot-x: Update to latest commit
Date: Fri, 17 Jan 2025 10:12:08 +0100

Am Freitag, dem 17.01.2025 um 02:09 +0000 schrieb Javier Olaechea:
> On Thu, Jan 16, 2025 at 7:46 AM Liliana Marie Prikler
> <liliana.prikler <at> gmail.com> wrote:
> > Yes, please use git-version.
> > 
> > And for anyone else using random commits while coding version
> > without it, let this be a reminder to use git-version.
> 
> Given that now we are using the commit for version 0.6 (which doesn't
> have a tag) there is no need to to use git-version. t was only in the
> case that we started shipping an unreleased commit as the version,
> correct?
Yeah, for keeping changes small and self-contained it's fine to do
that.  I'd just like to make it known that this style makes it very
unclear what's happening, so that a future bumper is hopefully aware of
that :)

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.