GNU bug report logs - #75557
gnus-highlight-selected-tree is broken (fix)

Previous Next

Full log

Message #13 received at 75557 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Pranshu Sharma <pranshu <at> bauherren.ovh>,
 75557 <at> debbugs.gnu.org
Subject: Re: bug#75557: gnus-highlight-selected-tree is broken (fix)
Date: Sat, 01 Mar 2025 23:30:55 -0500

> My only question is if we should perhaps make `buffer-live-p` throw an
> error in case it is passed something of the wrong type.  Yes, it is a
> backwards-incompatible change, but OTOH it would catch real bugs like
> the above, instead of silently returning nil.
>
> For example, we can currently do all of this nonsense:
>
>     (buffer-live-p 123)                          => nil
>     (buffer-live-p [foo])                        => nil
>     (buffer-live-p (make-symbol "foo"))          => nil
>     (buffer-live-p (lambda () (message "foo")))  => nil
>
> Eli, Stefan, WDYT?

I'm pretty sure it would introduce bugs because I know I wrote code
which relies on `buffer-live-p` behaving "like a type check"
(i.e. accepting any object).
I'd be surprised if I was the only one.


        Stefan "who doesn't like the tendency of ELisp functions to
                accept buffer names in place of buffer objects."

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.