GNU bug report logs - #75497
[PATCH] ibuffer: Display column titles in header line

Previous Next

Full log

Message #14 received at 75497 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75497 <at> debbugs.gnu.org
Subject: Re: bug#75497: [PATCH] ibuffer: Display column titles in header line
Date: Sat, 18 Jan 2025 11:34:01 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Sun, 12 Jan 2025 13:36:19 +0100
>> From:  Daniel Mendler via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> Daniel Mendler <mail <at> daniel-mendler.de> writes:
>> 
>> > Add new option value `title' to the customization option
>> > `ibuffer-use-header-line'.  For this value show the column titles in the
>> > Ibuffer header line.
>> 
>> I have attached an improved version of the patch to this mail. I have
>> added an "@" interactive spec to the sort commands, such that clicking
>> on the header line works when the Ibuffer window is not selected.
>
> Thanks.
>
>>  (defcustom ibuffer-use-header-line t
>> -  "If non-nil, display a header line containing current filters."
>> -  :type 'boolean)
>> +  "If non-nil, display a header line.
>> +If the variable has the value t, the header line displays the current
>
> "Variable has value" sounds weird.  I suggest "If the variable's value
> is t, ..." instead.
>
>> +filters.  For the value `title', the column titles are displayed."
>                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Passive tense alert!
>> +    (pcase-let ((`(,sym ,min ,_max ,align) element))
>> +      ;; Ignore a negative min when we're inserting the title
>
> Please end this comment with a period, to make it a complete sentence.
>
> Also, this comment explains what the code does, but not why (yes, I
> know the original code did that as well).  If you know the reason,
> please add that to the comment.

Thank you. I have attached an updated patch to this mail.

Daniel

[0002-ibuffer-Display-column-titles-in-header-line.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.