GNU bug report logs - #75497
[PATCH] ibuffer: Display column titles in header line

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75497 in the body.
You can then email your comments to 75497 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ibuffer: Display column titles in header line
Date: Sat, 11 Jan 2025 17:01:04 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

Add new option value `title' to the customization option
`ibuffer-use-header-line'.  For this value show the column titles in the
Ibuffer header line.

[0001-ibuffer-Display-column-titles-in-header-line.patch (text/patch, attachment)]

Message #8 received at 75497 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: 75497 <at> debbugs.gnu.org
Subject: Re: bug#75497: [PATCH] ibuffer: Display column titles in header line
Date: Sun, 12 Jan 2025 13:36:19 +0100

[Message part 1 (text/plain, inline)]

Daniel Mendler <mail <at> daniel-mendler.de> writes:

> Add new option value `title' to the customization option
> `ibuffer-use-header-line'.  For this value show the column titles in the
> Ibuffer header line.

I have attached an improved version of the patch to this mail. I have
added an "@" interactive spec to the sort commands, such that clicking
on the header line works when the Ibuffer window is not selected.

Daniel

[0002-ibuffer-Display-column-titles-in-header-line.patch (text/x-diff, attachment)]

Message #11 received at 75497 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 75497 <at> debbugs.gnu.org
Subject: Re: bug#75497: [PATCH] ibuffer: Display column titles in header line
Date: Sat, 18 Jan 2025 12:16:40 +0200

> Date: Sun, 12 Jan 2025 13:36:19 +0100
> From:  Daniel Mendler via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Daniel Mendler <mail <at> daniel-mendler.de> writes:
> 
> > Add new option value `title' to the customization option
> > `ibuffer-use-header-line'.  For this value show the column titles in the
> > Ibuffer header line.
> 
> I have attached an improved version of the patch to this mail. I have
> added an "@" interactive spec to the sort commands, such that clicking
> on the header line works when the Ibuffer window is not selected.

Thanks.

>  (defcustom ibuffer-use-header-line t
> -  "If non-nil, display a header line containing current filters."
> -  :type 'boolean)
> +  "If non-nil, display a header line.
> +If the variable has the value t, the header line displays the current

"Variable has value" sounds weird.  I suggest "If the variable's value
is t, ..." instead.

> +filters.  For the value `title', the column titles are displayed."
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Passive tense alert!
> +    (pcase-let ((`(,sym ,min ,_max ,align) element))
> +      ;; Ignore a negative min when we're inserting the title

Please end this comment with a period, to make it a complete sentence.

Also, this comment explains what the code does, but not why (yes, I
know the original code did that as well).  If you know the reason,
please add that to the comment.

Message #14 received at 75497 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75497 <at> debbugs.gnu.org
Subject: Re: bug#75497: [PATCH] ibuffer: Display column titles in header line
Date: Sat, 18 Jan 2025 11:34:01 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Sun, 12 Jan 2025 13:36:19 +0100
>> From:  Daniel Mendler via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> Daniel Mendler <mail <at> daniel-mendler.de> writes:
>> 
>> > Add new option value `title' to the customization option
>> > `ibuffer-use-header-line'.  For this value show the column titles in the
>> > Ibuffer header line.
>> 
>> I have attached an improved version of the patch to this mail. I have
>> added an "@" interactive spec to the sort commands, such that clicking
>> on the header line works when the Ibuffer window is not selected.
>
> Thanks.
>
>>  (defcustom ibuffer-use-header-line t
>> -  "If non-nil, display a header line containing current filters."
>> -  :type 'boolean)
>> +  "If non-nil, display a header line.
>> +If the variable has the value t, the header line displays the current
>
> "Variable has value" sounds weird.  I suggest "If the variable's value
> is t, ..." instead.
>
>> +filters.  For the value `title', the column titles are displayed."
>                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Passive tense alert!
>> +    (pcase-let ((`(,sym ,min ,_max ,align) element))
>> +      ;; Ignore a negative min when we're inserting the title
>
> Please end this comment with a period, to make it a complete sentence.
>
> Also, this comment explains what the code does, but not why (yes, I
> know the original code did that as well).  If you know the reason,
> please add that to the comment.

Thank you. I have attached an updated patch to this mail.

Daniel

[0002-ibuffer-Display-column-titles-in-header-line.patch (text/x-diff, attachment)]

Message #19 received at 75497-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 75497-done <at> debbugs.gnu.org
Subject: Re: bug#75497: [PATCH] ibuffer: Display column titles in header line
Date: Sat, 25 Jan 2025 11:45:38 +0200

> From: Daniel Mendler <mail <at> daniel-mendler.de>
> Cc: 75497 <at> debbugs.gnu.org
> Date: Sat, 18 Jan 2025 11:34:01 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Date: Sun, 12 Jan 2025 13:36:19 +0100
> >> From:  Daniel Mendler via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> >> 
> >> Daniel Mendler <mail <at> daniel-mendler.de> writes:
> >> 
> >> > Add new option value `title' to the customization option
> >> > `ibuffer-use-header-line'.  For this value show the column titles in the
> >> > Ibuffer header line.
> >> 
> >> I have attached an improved version of the patch to this mail. I have
> >> added an "@" interactive spec to the sort commands, such that clicking
> >> on the header line works when the Ibuffer window is not selected.
> >
> > Thanks.
> >
> >>  (defcustom ibuffer-use-header-line t
> >> -  "If non-nil, display a header line containing current filters."
> >> -  :type 'boolean)
> >> +  "If non-nil, display a header line.
> >> +If the variable has the value t, the header line displays the current
> >
> > "Variable has value" sounds weird.  I suggest "If the variable's value
> > is t, ..." instead.
> >
> >> +filters.  For the value `title', the column titles are displayed."
> >                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > Passive tense alert!
> >> +    (pcase-let ((`(,sym ,min ,_max ,align) element))
> >> +      ;; Ignore a negative min when we're inserting the title
> >
> > Please end this comment with a period, to make it a complete sentence.
> >
> > Also, this comment explains what the code does, but not why (yes, I
> > know the original code did that as well).  If you know the reason,
> > please add that to the comment.
> 
> Thank you. I have attached an updated patch to this mail.

Thanks, installed on master, and closing the bug.

Message #22 received at 75497-done <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75497-done <at> debbugs.gnu.org
Subject: Re: bug#75497: [PATCH] ibuffer: Display column titles in header line
Date: Sun, 26 Jan 2025 10:08:32 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> Thanks, installed on master, and closing the bug.

Thank you for installing the patches.

Daniel

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.