GNU bug report logs - #75286
[PATCH] gnu: Add tetgen.

Previous Next

Full log

Message #8 received at 75286 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Lars Bilke <lars.bilke <at> ufz.de>
Cc: Andreas Enge <andreas <at> enge.fr>, 75286 <at> debbugs.gnu.org,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>, Eric Bavier <bavier <at> posteo.net>
Subject: Re: [bug#75286] [PATCH] gnu: Add tetgen.
Date: Mon, 27 Jan 2025 14:35:41 +0100

Lars Bilke <lars.bilke <at> ufz.de> skribis:

> * gnu/packages/geo.scm (tetgen): New variable.
>
> Change-Id: Iba2de71cf0a10ca5c7b65f9851d05fe63c944b30

[...]

> +    (define-public tetgen
> +      (package
> +        (name "tetgen")
> +        (synopsis
> +         "Quality Tetrahedral Mesh Generator and 3D Delaunay Triangulator")
> +        (license license:agpl3)
> +        (description
> +         "TetGen is a program to generate tetrahedral meshes of any 3D
> +polyhedral domains.  TetGen generates exact constrained Delaunay
> +tetrahedralizations, boundary conforming Delaunay meshes, and Voronoi
> +partitions.")
> +        (home-page "https://wias-berlin.de/software/tetgen/")
> +        (version "1.5.1-2")
> +        (source
> +         (origin
> +           (method git-fetch)
> +           (uri (git-reference
> +                 (url "https://github.com/ufz/tetgen")
> +                 (commit version)))
> +           (sha256
> +            (base32 "0hd8mvmzybvlgvfx131p8782v8hggmg53vlkgazpsw9d6ympfcrv"))))
> +        (build-system cmake-build-system)
> +        (arguments
> +         `(#:tests? #f
> +           #:configure-flags (list "-DCMAKE_POSITION_INDEPENDENT_CODE=ON")))))

Could you remove the extra indentation, reorder fields in the more
conventional way, check the license (AGPLv3+ maybe?), add a ‘file-name’
field to the origin (as noted by ‘guix lint’), and run ‘guix style -S
arguments tetgen’?

If tests have to be disabled, there needs to be a margin comment
explaining why, such as “no test suite”.  Otherwise it’s worth
investigating.

Thanks in advance!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.