GNU bug report logs - #75286
[PATCH] gnu: Add tetgen.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75286 in the body.
You can then email your comments to 75286 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars Bilke <lars.bilke <at> ufz.de>
To: guix-patches <at> gnu.org
Cc: Lars Bilke <lars.bilke <at> ufz.de>
Subject: [PATCH] gnu: Add tetgen.
Date: Thu, 02 Jan 2025 15:50:23 +0100

* gnu/packages/geo.scm (tetgen): New variable.

Change-Id: Iba2de71cf0a10ca5c7b65f9851d05fe63c944b30
---
 gnu/packages/geo.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm
index 8b9b9a4cf7..ec48474708 100644
--- a/gnu/packages/geo.scm
+++ b/gnu/packages/geo.scm
@@ -3614,3 +3614,29 @@ (define-public laszip
 @code{LAZ} files.  The @code{LAS} format is a file format designed for the
 interchange and archiving of lidar point cloud data.")
     (license license:asl2.0)))
+
+    (define-public tetgen
+      (package
+        (name "tetgen")
+        (synopsis
+         "Quality Tetrahedral Mesh Generator and 3D Delaunay Triangulator")
+        (license license:agpl3)
+        (description
+         "TetGen is a program to generate tetrahedral meshes of any 3D
+polyhedral domains.  TetGen generates exact constrained Delaunay
+tetrahedralizations, boundary conforming Delaunay meshes, and Voronoi
+partitions.")
+        (home-page "https://wias-berlin.de/software/tetgen/")
+        (version "1.5.1-2")
+        (source
+         (origin
+           (method git-fetch)
+           (uri (git-reference
+                 (url "https://github.com/ufz/tetgen")
+                 (commit version)))
+           (sha256
+            (base32 "0hd8mvmzybvlgvfx131p8782v8hggmg53vlkgazpsw9d6ympfcrv"))))
+        (build-system cmake-build-system)
+        (arguments
+         `(#:tests? #f
+           #:configure-flags (list "-DCMAKE_POSITION_INDEPENDENT_CODE=ON")))))

base-commit: ab43d883a0a88adbcfd3c3ab8d4c097cd9054b90
-- 
2.46.1

Message #8 received at 75286 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Lars Bilke <lars.bilke <at> ufz.de>
Cc: Andreas Enge <andreas <at> enge.fr>, 75286 <at> debbugs.gnu.org,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>, Eric Bavier <bavier <at> posteo.net>
Subject: Re: [bug#75286] [PATCH] gnu: Add tetgen.
Date: Mon, 27 Jan 2025 14:35:41 +0100

Lars Bilke <lars.bilke <at> ufz.de> skribis:

> * gnu/packages/geo.scm (tetgen): New variable.
>
> Change-Id: Iba2de71cf0a10ca5c7b65f9851d05fe63c944b30

[...]

> +    (define-public tetgen
> +      (package
> +        (name "tetgen")
> +        (synopsis
> +         "Quality Tetrahedral Mesh Generator and 3D Delaunay Triangulator")
> +        (license license:agpl3)
> +        (description
> +         "TetGen is a program to generate tetrahedral meshes of any 3D
> +polyhedral domains.  TetGen generates exact constrained Delaunay
> +tetrahedralizations, boundary conforming Delaunay meshes, and Voronoi
> +partitions.")
> +        (home-page "https://wias-berlin.de/software/tetgen/")
> +        (version "1.5.1-2")
> +        (source
> +         (origin
> +           (method git-fetch)
> +           (uri (git-reference
> +                 (url "https://github.com/ufz/tetgen")
> +                 (commit version)))
> +           (sha256
> +            (base32 "0hd8mvmzybvlgvfx131p8782v8hggmg53vlkgazpsw9d6ympfcrv"))))
> +        (build-system cmake-build-system)
> +        (arguments
> +         `(#:tests? #f
> +           #:configure-flags (list "-DCMAKE_POSITION_INDEPENDENT_CODE=ON")))))

Could you remove the extra indentation, reorder fields in the more
conventional way, check the license (AGPLv3+ maybe?), add a ‘file-name’
field to the origin (as noted by ‘guix lint’), and run ‘guix style -S
arguments tetgen’?

If tests have to be disabled, there needs to be a margin comment
explaining why, such as “no test suite”.  Otherwise it’s worth
investigating.

Thanks in advance!

Ludo’.

Message #11 received at 75286 <at> debbugs.gnu.org (full text, mbox):

From: Lars Bilke <lars.bilke <at> ufz.de>
To: 75286 <at> debbugs.gnu.org, ludovic.courtes <at> inria.fr
Cc: Lars Bilke <lars.bilke <at> ufz.de>
Subject: [PATCH v2] gnu: Add tetgen.
Date: Tue, 28 Jan 2025 10:20:04 +0100

* gnu/packages/geo.scm (tetgen): New variable.

Change-Id: Iba2de71cf0a10ca5c7b65f9851d05fe63c944b30
---
 gnu/packages/geo.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm
index 3317271802..2a63d892d8 100644
--- a/gnu/packages/geo.scm
+++ b/gnu/packages/geo.scm
@@ -3684,3 +3684,32 @@ (define-public laszip
 @code{LAZ} files.  The @code{LAS} format is a file format designed for the
 interchange and archiving of lidar point cloud data.")
     (license license:asl2.0)))
+
+(define-public tetgen
+  (package
+    (name "tetgen")
+    (version "1.5.1-2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ufz/tetgen")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0hd8mvmzybvlgvfx131p8782v8hggmg53vlkgazpsw9d6ympfcrv"))))
+    (build-system cmake-build-system)
+    (arguments
+     (list
+      #:configure-flags #~(list "-DCMAKE_POSITION_INDEPENDENT_CODE=ON")
+      ;; No test suite.
+      #:tests? #f))
+    (home-page "https://wias-berlin.de/software/tetgen/")
+    (synopsis
+     "Quality Tetrahedral Mesh Generator and 3D Delaunay Triangulator")
+    (description
+     "TetGen is a program to generate tetrahedral meshes of any 3D
+polyhedral domains.  TetGen generates exact constrained Delaunay
+tetrahedralizations, boundary conforming Delaunay meshes, and Voronoi
+partitions.")
+    (license license:agpl3+)))

base-commit: 44d9f05fb3a8f20044873597762e6d8d6a895783
-- 
2.46.1

Message #14 received at 75286 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Lars Bilke <lars.bilke <at> ufz.de>
Cc: ludovic.courtes <at> inria.fr, 75286 <at> debbugs.gnu.org,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>, ludo <at> gnu.org,
 Eric Bavier <bavier <at> posteo.net>
Subject: [PATCH v3] gnu: Add tetgen.
Date: Wed, 5 Feb 2025 15:08:31 +0100

[Message part 1 (text/plain, inline)]

Hello Lars,

when looking at the tetgen homepage, I see that they do not have a
version 1.5.1, but that there is a version 1.6.0. They hide the source
behind a form that asks for a name and an email address, but the real
place of the source code is easily reverse engineered.

I am attaching a corresponding patch; unfortunately there is no install
target, so I copy the binary "by hand" to bin/. And there is an
installed file etc/ld.so.cache, of which I do not know where it comes
from and which phase puts it into the output; it is surely superfluous?

What do you think? I see that your email address is @ufz.de and that the
github origin you provide belongs to ufz, so maybe you maintain a fork?
But if you need one, maybe this should be mentioned somewhere and/or
reflected in the package name?

Andreas

[0001-gnu-Add-tetgen.patch (text/plain, attachment)]

Message #17 received at 75286 <at> debbugs.gnu.org (full text, mbox):

From: Lars Bilke <lars.bilke <at> ufz.de>
To: Andreas Enge <andreas <at> enge.fr>
Cc: ludovic.courtes <at> inria.fr, 75286 <at> debbugs.gnu.org,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>, ludo <at> gnu.org,
 Eric Bavier <bavier <at> posteo.net>
Subject: Re: [PATCH v3] gnu: Add tetgen.
Date: Thu, 06 Feb 2025 15:11:41 +0100

Hi Andreas,

thanks for your patch!

On 5 Feb 2025, at 15:08, Andreas Enge wrote:

> I am attaching a corresponding patch; unfortunately, there is no install
> target, so I copy the binary "by hand" to bin/. And there is an
> installed file etc/ld.so.cache, of which I do not know where it comes
> from and which phase puts it into the output; it is surely superfluous?

Yes, the ld cache is not required for the binary.

> What do you think? I see that your email address is @ufz.de and that the
> github origin you provide belongs to ufz, so maybe you maintain a fork?
> But if you need one, maybe this should be mentioned somewhere and/or
> reflected in the package name?

I am perfectly fine to merge this patch v3.

We relied on tetgen (the library) in the past and made some fixes in the build system on that fork. But this is not required for us anymore and our fork is not maintained anymore.

So building this with the original source as you did is better.

Thanks a lot!
Lars

Message #22 received at 75286-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Lars Bilke <lars.bilke <at> ufz.de>
Cc: ludo <at> gnu.org, ludovic.courtes <at> inria.fr,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>, 75286-done <at> debbugs.gnu.org,
 Eric Bavier <bavier <at> posteo.net>
Subject: Re: [PATCH v3] gnu: Add tetgen.
Date: Thu, 6 Feb 2025 16:29:42 +0100

Hello!

Am Thu, Feb 06, 2025 at 03:11:41PM +0100 schrieb Lars Bilke:
> I am perfectly fine to merge this patch v3.
> So building this with the original source as you did is better.

thanks for your quick reply! I have just pushed the patch.
The etc/ld.so.cache comes from the phase make-dynamic-linker-cache,
of which I do not know why it appears; I have not seen it in other
packages using the cmake build system. So I have just removed the phase
by hand.

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.