GNU bug report logs - #75192
[PATCH] Update fontification for attribute values in heex-ts-mode

Previous Next

Full log

Message #36 received at 75192-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>, 75192-done <at> debbugs.gnu.org
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
Date: Fri, 3 Jan 2025 09:14:50 -0600

Version: 30.1

Yuan Fu <casouri <at> gmail.com> writes:

>> On Jan 2, 2025, at 7:24 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>
>>> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
>>> Date: Thu, 2 Jan 2025 12:13:27 +0200
>>> Cc: Stefan Kangas <stefankangas <at> gmail.com>, 75192 <at> debbugs.gnu.org, casouri <at> gmail.com
>>>
>>>>> attribute be highlighted as a string?
>>>>
>>>> I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
>>>> simply noted that the code directly above the change said
>>>>
>>>>    :feature 'heex-string
>>>>
>>>> which is why I assumed that using a string face should make sense.
>>>
>>> So we think that the current face is just a typo?
>>>
>>> Originally I was not sure what would be more appropriate, but got a comment from a user and saw
>>> html-ts-mode uses string so thought it would be good to change before it gets released.
>>
>> OK, then I think installing this on emacs-30 is TRT.
>
> Agree.

Thanks all, installed on emacs-30 as commit 921f454f508.  Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.