GNU bug report logs - #75192
[PATCH] Update fontification for attribute values in heex-ts-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75192 in the body.
You can then email your comments to 75192 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Update fontification for attribute values in heex-ts-mode
Date: Mon, 30 Dec 2024 12:59:57 +0200

[Message part 1 (text/plain, inline)]

This updates heex-ts-mode to use font-lock-string-face to be consistent
with html-ts-mode on attribute values.

Kind regards,
Wilhelm

[Message part 2 (text/html, inline)]

[0001-Update-fontification-for-attribute-values-in-heex-ts.patch (text/x-patch, attachment)]

Message #10 received at 75192 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>, 75192 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>, Yuan Fu <casouri <at> gmail.com>
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
Date: Thu, 2 Jan 2025 01:45:22 -0600

Wilhelm Kirschbaum <wkirschbaum <at> gmail.com> writes:

> This updates heex-ts-mode to use font-lock-string-face to be consistent
> with html-ts-mode on attribute values.

Should we install this change on master or emacs-30?  Eli, Yuan, WDYT?

> From 51dcd9cea634233439db59c977928f8d7a36edff Mon Sep 17 00:00:00 2001
> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
> Date: Mon, 30 Dec 2024 12:56:40 +0200
> Subject: [PATCH] Update fontification for attribute values in heex-ts-mode
>
> Attribute values are strings as with html-ts-mode.
>
> * lisp/progmodes/heex-ts-mode.el (heex-ts--font-lock-settings):
> Change to attribute value to @font-lock-string-face.
> ---
>  lisp/progmodes/heex-ts-mode.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/heex-ts-mode.el b/lisp/progmodes/heex-ts-mode.el
> index 797bfd6c8ff..4be987f9d81 100644
> --- a/lisp/progmodes/heex-ts-mode.el
> +++ b/lisp/progmodes/heex-ts-mode.el
> @@ -113,7 +113,7 @@ heex-ts--font-lock-settings
>       `((special_attribute_name) @font-lock-keyword-face)
>       :language 'heex
>       :feature 'heex-string
> -     `([(attribute_value) (quoted_attribute_value)] @font-lock-constant-face)
> +     `([(attribute_value) (quoted_attribute_value)] @font-lock-string-face)
>       :language 'heex
>       :feature 'heex-component
>       `([
> --
> 2.45.2

Message #13 received at 75192 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: wkirschbaum <at> gmail.com, casouri <at> gmail.com, 75192 <at> debbugs.gnu.org
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
Date: Thu, 02 Jan 2025 10:36:32 +0200

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Thu, 2 Jan 2025 01:45:22 -0600
> Cc: Eli Zaretskii <eliz <at> gnu.org>, Yuan Fu <casouri <at> gmail.com>
> 
> Wilhelm Kirschbaum <wkirschbaum <at> gmail.com> writes:
> 
> > This updates heex-ts-mode to use font-lock-string-face to be consistent
> > with html-ts-mode on attribute values.
> 
> Should we install this change on master or emacs-30?  Eli, Yuan, WDYT?

Are we all in agreement with the change itself?  Why should an
attribute be highlighted as a string?

Message #16 received at 75192 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: wkirschbaum <at> gmail.com, casouri <at> gmail.com, 75192 <at> debbugs.gnu.org
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
Date: Thu, 2 Jan 2025 02:41:12 -0600

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Stefan Kangas <stefankangas <at> gmail.com>
>> Date: Thu, 2 Jan 2025 01:45:22 -0600
>> Cc: Eli Zaretskii <eliz <at> gnu.org>, Yuan Fu <casouri <at> gmail.com>
>>
>> Wilhelm Kirschbaum <wkirschbaum <at> gmail.com> writes:
>>
>> > This updates heex-ts-mode to use font-lock-string-face to be consistent
>> > with html-ts-mode on attribute values.
>>
>> Should we install this change on master or emacs-30?  Eli, Yuan, WDYT?
>
> Are we all in agreement with the change itself?  Why should an
> attribute be highlighted as a string?

I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
simply noted that the code directly above the change said

    :feature 'heex-string

which is why I assumed that using a string face should make sense.

I'll let others chime in here.

Message #19 received at 75192 <at> debbugs.gnu.org (full text, mbox):

From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 75192 <at> debbugs.gnu.org, casouri <at> gmail.com
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
Date: Thu, 2 Jan 2025 10:56:35 +0200

[Message part 1 (text/plain, inline)]

>
>
> >> > This updates heex-ts-mode to use font-lock-string-face to be
> consistent
> >> > with html-ts-mode on attribute values.
> >>
> >> Should we install this change on master or emacs-30?  Eli, Yuan, WDYT?
> >
> > Are we all in agreement with the change itself?  Why should an
> > attribute be highlighted as a string?
>

It's the value of an attribute as in <div attribute="attribute_value">.  It
matches html-ts-mode which I believe is more correct.

[Message part 2 (text/html, inline)]

Message #22 received at 75192 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: wkirschbaum <at> gmail.com, casouri <at> gmail.com, 75192 <at> debbugs.gnu.org
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
Date: Thu, 02 Jan 2025 11:06:57 +0200

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Thu, 2 Jan 2025 02:41:12 -0600
> Cc: wkirschbaum <at> gmail.com, 75192 <at> debbugs.gnu.org, casouri <at> gmail.com
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: Stefan Kangas <stefankangas <at> gmail.com>
> >> Date: Thu, 2 Jan 2025 01:45:22 -0600
> >> Cc: Eli Zaretskii <eliz <at> gnu.org>, Yuan Fu <casouri <at> gmail.com>
> >>
> >> Wilhelm Kirschbaum <wkirschbaum <at> gmail.com> writes:
> >>
> >> > This updates heex-ts-mode to use font-lock-string-face to be consistent
> >> > with html-ts-mode on attribute values.
> >>
> >> Should we install this change on master or emacs-30?  Eli, Yuan, WDYT?
> >
> > Are we all in agreement with the change itself?  Why should an
> > attribute be highlighted as a string?
> 
> I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
> simply noted that the code directly above the change said
> 
>     :feature 'heex-string
> 
> which is why I assumed that using a string face should make sense.

So we think that the current face is just a typo?

Message #25 received at 75192 <at> debbugs.gnu.org (full text, mbox):

From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: casouri <at> gmail.com, 75192 <at> debbugs.gnu.org,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
Date: Thu, 2 Jan 2025 12:13:27 +0200

[Message part 1 (text/plain, inline)]

> > > attribute be highlighted as a string?
> >
> > I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
> > simply noted that the code directly above the change said
> >
> >     :feature 'heex-string
> >
> > which is why I assumed that using a string face should make sense.
>
> So we think that the current face is just a typo?
>

Originally I was not sure what would be more appropriate, but got a comment
from a user and saw html-ts-mode uses string so thought it would be good to
change before it gets released.

[Message part 2 (text/html, inline)]

Message #28 received at 75192 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
Cc: casouri <at> gmail.com, 75192 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
Date: Thu, 02 Jan 2025 17:24:53 +0200

> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
> Date: Thu, 2 Jan 2025 12:13:27 +0200
> Cc: Stefan Kangas <stefankangas <at> gmail.com>, 75192 <at> debbugs.gnu.org, casouri <at> gmail.com
> 
>  > > attribute be highlighted as a string?
>  > 
>  > I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
>  > simply noted that the code directly above the change said
>  > 
>  >     :feature 'heex-string
>  > 
>  > which is why I assumed that using a string face should make sense.
> 
>  So we think that the current face is just a typo?
> 
> Originally I was not sure what would be more appropriate, but got a comment from a user and saw
> html-ts-mode uses string so thought it would be good to change before it gets released.

OK, then I think installing this on emacs-30 is TRT.

Message #31 received at 75192 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>, 75192 <at> debbugs.gnu.org,
 stefankangas <at> gmail.com
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
Date: Thu, 2 Jan 2025 21:49:32 -0800

> On Jan 2, 2025, at 7:24 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
>> Date: Thu, 2 Jan 2025 12:13:27 +0200
>> Cc: Stefan Kangas <stefankangas <at> gmail.com>, 75192 <at> debbugs.gnu.org, casouri <at> gmail.com
>> 
>>>> attribute be highlighted as a string?
>>> 
>>> I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
>>> simply noted that the code directly above the change said
>>> 
>>>    :feature 'heex-string
>>> 
>>> which is why I assumed that using a string face should make sense.
>> 
>> So we think that the current face is just a typo?
>> 
>> Originally I was not sure what would be more appropriate, but got a comment from a user and saw
>> html-ts-mode uses string so thought it would be good to change before it gets released.
> 
> OK, then I think installing this on emacs-30 is TRT.

Agree.

Message #36 received at 75192-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>, 75192-done <at> debbugs.gnu.org
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
Date: Fri, 3 Jan 2025 09:14:50 -0600

Version: 30.1

Yuan Fu <casouri <at> gmail.com> writes:

>> On Jan 2, 2025, at 7:24 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>
>>> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
>>> Date: Thu, 2 Jan 2025 12:13:27 +0200
>>> Cc: Stefan Kangas <stefankangas <at> gmail.com>, 75192 <at> debbugs.gnu.org, casouri <at> gmail.com
>>>
>>>>> attribute be highlighted as a string?
>>>>
>>>> I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
>>>> simply noted that the code directly above the change said
>>>>
>>>>    :feature 'heex-string
>>>>
>>>> which is why I assumed that using a string face should make sense.
>>>
>>> So we think that the current face is just a typo?
>>>
>>> Originally I was not sure what would be more appropriate, but got a comment from a user and saw
>>> html-ts-mode uses string so thought it would be good to change before it gets released.
>>
>> OK, then I think installing this on emacs-30 is TRT.
>
> Agree.

Thanks all, installed on emacs-30 as commit 921f454f508.  Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.