GNU bug report logs - #75192
[PATCH] Update fontification for attribute values in heex-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
Subject: bug#75192: closed (Re: bug#75192: [PATCH] Update fontification
 for attribute values in heex-ts-mode)
Date: Fri, 03 Jan 2025 15:15:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#75192: [PATCH] Update fontification for attribute values in heex-ts-mode

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 75192 <at> debbugs.gnu.org.

-- 
75192: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75192
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>, 75192-done <at> debbugs.gnu.org
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
Date: Fri, 3 Jan 2025 09:14:50 -0600

Version: 30.1

Yuan Fu <casouri <at> gmail.com> writes:

>> On Jan 2, 2025, at 7:24 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>
>>> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
>>> Date: Thu, 2 Jan 2025 12:13:27 +0200
>>> Cc: Stefan Kangas <stefankangas <at> gmail.com>, 75192 <at> debbugs.gnu.org, casouri <at> gmail.com
>>>
>>>>> attribute be highlighted as a string?
>>>>
>>>> I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
>>>> simply noted that the code directly above the change said
>>>>
>>>>    :feature 'heex-string
>>>>
>>>> which is why I assumed that using a string face should make sense.
>>>
>>> So we think that the current face is just a typo?
>>>
>>> Originally I was not sure what would be more appropriate, but got a comment from a user and saw
>>> html-ts-mode uses string so thought it would be good to change before it gets released.
>>
>> OK, then I think installing this on emacs-30 is TRT.
>
> Agree.

Thanks all, installed on emacs-30 as commit 921f454f508.  Closing.

[Message part 3 (message/rfc822, inline)]

From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Update fontification for attribute values in heex-ts-mode
Date: Mon, 30 Dec 2024 12:59:57 +0200

[Message part 4 (text/plain, inline)]

This updates heex-ts-mode to use font-lock-string-face to be consistent
with html-ts-mode on attribute values.

Kind regards,
Wilhelm

[Message part 5 (text/html, inline)]

[0001-Update-fontification-for-attribute-values-in-heex-ts.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.