GNU bug report logs - #75192
[PATCH] Update fontification for attribute values in heex-ts-mode

Previous Next

Package: emacs;

Reported by: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>

Date: Mon, 30 Dec 2024 11:03:02 UTC

Severity: wishlist

Tags: patch

Fixed in version 30.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>, 75192 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode
Date: Thu, 2 Jan 2025 21:49:32 -0800
> On Jan 2, 2025, at 7:24 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
>> Date: Thu, 2 Jan 2025 12:13:27 +0200
>> Cc: Stefan Kangas <stefankangas <at> gmail.com>, 75192 <at> debbugs.gnu.org, casouri <at> gmail.com
>> 
>>>> attribute be highlighted as a string?
>>> 
>>> I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
>>> simply noted that the code directly above the change said
>>> 
>>>    :feature 'heex-string
>>> 
>>> which is why I assumed that using a string face should make sense.
>> 
>> So we think that the current face is just a typo?
>> 
>> Originally I was not sure what would be more appropriate, but got a comment from a user and saw
>> html-ts-mode uses string so thought it would be good to change before it gets released.
> 
> OK, then I think installing this on emacs-30 is TRT.

Agree.





This bug report was last modified 172 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.