GNU bug report logs - #75192
[PATCH] Update fontification for attribute values in heex-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: wkirschbaum <at> gmail.com, casouri <at> gmail.com, 75192 <at> debbugs.gnu.org
Subject: bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode
Date: Thu, 2 Jan 2025 02:41:12 -0600

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Stefan Kangas <stefankangas <at> gmail.com>
>> Date: Thu, 2 Jan 2025 01:45:22 -0600
>> Cc: Eli Zaretskii <eliz <at> gnu.org>, Yuan Fu <casouri <at> gmail.com>
>>
>> Wilhelm Kirschbaum <wkirschbaum <at> gmail.com> writes:
>>
>> > This updates heex-ts-mode to use font-lock-string-face to be consistent
>> > with html-ts-mode on attribute values.
>>
>> Should we install this change on master or emacs-30?  Eli, Yuan, WDYT?
>
> Are we all in agreement with the change itself?  Why should an
> attribute be highlighted as a string?

I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
simply noted that the code directly above the change said

    :feature 'heex-string

which is why I assumed that using a string face should make sense.

I'll let others chime in here.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.