GNU bug report logs - #75192
[PATCH] Update fontification for attribute values in heex-ts-mode

Previous Next

Package: emacs;

Reported by: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>

Date: Mon, 30 Dec 2024 11:03:02 UTC

Severity: wishlist

Tags: patch

Fixed in version 30.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 75192 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>, 75192 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>, Yuan Fu <casouri <at> gmail.com>
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
Date: Thu, 2 Jan 2025 01:45:22 -0600
Wilhelm Kirschbaum <wkirschbaum <at> gmail.com> writes:

> This updates heex-ts-mode to use font-lock-string-face to be consistent
> with html-ts-mode on attribute values.

Should we install this change on master or emacs-30?  Eli, Yuan, WDYT?

> From 51dcd9cea634233439db59c977928f8d7a36edff Mon Sep 17 00:00:00 2001
> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
> Date: Mon, 30 Dec 2024 12:56:40 +0200
> Subject: [PATCH] Update fontification for attribute values in heex-ts-mode
>
> Attribute values are strings as with html-ts-mode.
>
> * lisp/progmodes/heex-ts-mode.el (heex-ts--font-lock-settings):
> Change to attribute value to @font-lock-string-face.
> ---
>  lisp/progmodes/heex-ts-mode.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/heex-ts-mode.el b/lisp/progmodes/heex-ts-mode.el
> index 797bfd6c8ff..4be987f9d81 100644
> --- a/lisp/progmodes/heex-ts-mode.el
> +++ b/lisp/progmodes/heex-ts-mode.el
> @@ -113,7 +113,7 @@ heex-ts--font-lock-settings
>       `((special_attribute_name) @font-lock-keyword-face)
>       :language 'heex
>       :feature 'heex-string
> -     `([(attribute_value) (quoted_attribute_value)] @font-lock-constant-face)
> +     `([(attribute_value) (quoted_attribute_value)] @font-lock-string-face)
>       :language 'heex
>       :feature 'heex-component
>       `([
> --
> 2.45.2




This bug report was last modified 139 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.