GNU bug report logs - #75184
Merge haskell-ts-mode to master

Previous Next

Full log

Message #18 received at 75184 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 75184 <at> debbugs.gnu.org, Pranshu Sharma <pranshu <at> bauherren.ovh>
Subject: Re: bug#75184: Merge haskell-ts-mode to master
Date: Wed, 5 Mar 2025 07:04:15 -0800

> On Mar 1, 2025, at 8:19 PM, Stefan Kangas <stefankangas <at> gmail.com> wrote:
> 
> Pranshu Sharma <pranshu <at> bauherren.ovh> writes:
> 
>> Hello all,
>> 
>> This is request to merge haskell-ts-mode to master.  The code is here
>> https://codeberg.org/pranshu/haskell-ts-mode , but I also attacched
>> file.  I suggest you look in codeberg repo for latest changes.
>> 
>> Phillip kauldarlic has done a review of the non-treesit specific part of
>> the code in emacs-devel, *I need someone* to review treesit specific
>> parts of it now.
> 
> Yuan, could you please take a look at this and install it if it looks
> okay?
> 
> Thanks in advance.

Thanks for the ping Stefan. The patch mostly looks good! Since we’re merging it to master, it can take advantage of some new features. For example, it can add some definitions to treesit-thing-settings. Also, it should set treesit-primary-parser.

I also noticed that the source file uses tab indentation. Does Emacs have any policy regarding tab/space indentation for lisp files?

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.