GNU bug report logs - #75091
[PATCH] services: syslog: fix configuration file argument

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#75091: closed ([PATCH] services: syslog: fix configuration
 file argument)
Date: Wed, 25 Dec 2024 21:50:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 25 Dec 2024 22:49:23 +0100
with message-id <87v7v7302k.fsf <at> gnu.org>
and subject line Re: [bug#75091] [PATCH] services: syslog: fix configuration file argument
has caused the debbugs.gnu.org bug report #75091,
regarding [PATCH] services: syslog: fix configuration file argument
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
75091: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75091
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: 45mg <45mg.writes <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: ludo <at> gnu.org, 45mg <45mg.writes <at> gmail.com>, jean-baptiste.note <at> m4x.org
Subject: [PATCH] services: syslog: fix configuration file argument
Date: Wed, 25 Dec 2024 12:14:23 -0500

* gnu/services/base.scm (syslog-shepherd-service): Separate incorrectly
combined arguments which resulted in an argument like "-f
/etc/syslog.conf" being passed to syslogd, leading it to ignore the
argument and execute without a configuration file. Effects of this
included no log files being written, though the Shepherd service ran
successfully.

Ref: https://issues.guix.gnu.org/70677#4-lineno7
Change-Id: I3dbe00eabd4a10804e554c12e1466483c0b185b7
---
 gnu/services/base.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index fc604f029a..75ce4e8fe5 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1679,7 +1679,7 @@ (define (syslog-shepherd-service config)
    (start #~(make-forkexec-constructor
              (list #$(syslog-configuration-syslogd config)
                    ;; the -f option here is compatible with rsyslog
-                   #$(string-append "-f " syslog.conf)
+                   "-f" #$syslog.conf
                    #$@(syslog-configuration-extra-options config))
              #:file-creation-mask #o137
              #:pid-file "/var/run/syslog.pid"))

base-commit: 3ada4796e9adcea6fce621e639ddbfb181ab6689
-- 
2.47.1

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: 45mg <45mg.writes <at> gmail.com>
Cc: jean-baptiste.note <at> m4x.org, 75091-done <at> debbugs.gnu.org
Subject: Re: [bug#75091] [PATCH] services: syslog: fix configuration file
 argument
Date: Wed, 25 Dec 2024 22:49:23 +0100

45mg <45mg.writes <at> gmail.com> skribis:

> * gnu/services/base.scm (syslog-shepherd-service): Separate incorrectly
> combined arguments which resulted in an argument like "-f
> /etc/syslog.conf" being passed to syslogd, leading it to ignore the
> argument and execute without a configuration file. Effects of this
> included no log files being written, though the Shepherd service ran
> successfully.
>
> Ref: https://issues.guix.gnu.org/70677#4-lineno7
> Change-Id: I3dbe00eabd4a10804e554c12e1466483c0b185b7

Oops, my bad, I overlooked that.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.