GNU bug report logs - #75091
[PATCH] services: syslog: fix configuration file argument

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75091 in the body.
You can then email your comments to 75091 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 45mg <45mg.writes <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: ludo <at> gnu.org, 45mg <45mg.writes <at> gmail.com>, jean-baptiste.note <at> m4x.org
Subject: [PATCH] services: syslog: fix configuration file argument
Date: Wed, 25 Dec 2024 12:14:23 -0500

* gnu/services/base.scm (syslog-shepherd-service): Separate incorrectly
combined arguments which resulted in an argument like "-f
/etc/syslog.conf" being passed to syslogd, leading it to ignore the
argument and execute without a configuration file. Effects of this
included no log files being written, though the Shepherd service ran
successfully.

Ref: https://issues.guix.gnu.org/70677#4-lineno7
Change-Id: I3dbe00eabd4a10804e554c12e1466483c0b185b7
---
 gnu/services/base.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index fc604f029a..75ce4e8fe5 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1679,7 +1679,7 @@ (define (syslog-shepherd-service config)
    (start #~(make-forkexec-constructor
              (list #$(syslog-configuration-syslogd config)
                    ;; the -f option here is compatible with rsyslog
-                   #$(string-append "-f " syslog.conf)
+                   "-f" #$syslog.conf
                    #$@(syslog-configuration-extra-options config))
              #:file-creation-mask #o137
              #:pid-file "/var/run/syslog.pid"))

base-commit: 3ada4796e9adcea6fce621e639ddbfb181ab6689
-- 
2.47.1

Message #10 received at 75091-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: 45mg <45mg.writes <at> gmail.com>
Cc: jean-baptiste.note <at> m4x.org, 75091-done <at> debbugs.gnu.org
Subject: Re: [bug#75091] [PATCH] services: syslog: fix configuration file
 argument
Date: Wed, 25 Dec 2024 22:49:23 +0100

45mg <45mg.writes <at> gmail.com> skribis:

> * gnu/services/base.scm (syslog-shepherd-service): Separate incorrectly
> combined arguments which resulted in an argument like "-f
> /etc/syslog.conf" being passed to syslogd, leading it to ignore the
> argument and execute without a configuration file. Effects of this
> included no log files being written, though the Shepherd service ran
> successfully.
>
> Ref: https://issues.guix.gnu.org/70677#4-lineno7
> Change-Id: I3dbe00eabd4a10804e554c12e1466483c0b185b7

Oops, my bad, I overlooked that.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.