GNU bug report logs - #75082
[PATCH] gnu: Add python-terminaltexteffects.

Previous Next

Package: guix-patches;

Reported by: Andrew Wong <wongandj <at> icloud.com>

Date: Wed, 25 Dec 2024 08:27:02 UTC

Severity: normal

Tags: patch

Done: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #14 received at 75082 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 75082 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-terminaltexteffects.
Date: Wed, 12 Feb 2025 11:12:31 +0000

[Message part 1 (text/plain, inline)]
Hi,

Thank you for the patch.

I've got visual review points only for now

+    (arguments
+     `(#:tests? #f))
+    (inputs (list poetry))

Please use python-poetry-core and place it in native inputs.
Elaborate why no tests
Keep the variable and package name prefixed with python-

Let's check V3!

Thanks,
Oleg

[Message part 2 (text/html, inline)]
This bug report was last modified 100 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.