GNU bug report logs - #75082
[PATCH] gnu: Add python-terminaltexteffects.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75082 in the body.
You can then email your comments to 75082 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: guix-patches <at> gnu.org
Cc: Andrew Wong <wongandj <at> icloud.com>
Subject: [PATCH] gnu: Add python-terminaltexteffects.
Date: Wed, 25 Dec 2024 03:26:02 -0500

Change-Id: I6ef522fe5c59b4da4e604fe6473e42e5d2b476d0
---
 gnu/packages/toys.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/toys.scm b/gnu/packages/toys.scm
index 359cdbcbe1..6da211046f 100644
--- a/gnu/packages/toys.scm
+++ b/gnu/packages/toys.scm
@@ -42,6 +42,9 @@ (define-module (gnu packages toys)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system copy)
   #:use-module (guix build-system meson)
+  #:use-module (guix build-system python)
+  #:use-module (guix build-system pyproject)
+  #:use-module (gnu packages python-xyz)
   #:use-module (guix download)
   #:use-module (guix gexp)
   #:use-module (guix git-download)
@@ -49,6 +52,36 @@ (define-module (gnu packages toys)
   #:use-module (guix packages)
   #:use-module (guix utils))
 
+(define-public python-terminaltexteffects
+  (package
+    (name "python-terminaltexteffects")
+    (version "0.11.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "terminaltexteffects" version))
+       (sha256
+        (base32 "1cnw2f0pwsbvva9pbiwjxc8aygvsnfjlpbhrdflh8fh0p9rwnc0l"))))
+    (build-system pyproject-build-system)
+    (arguments
+     `(#:phases (modify-phases %standard-phases
+                  (delete 'check))))
+    (inputs (list poetry))
+    (home-page "https://github.com/ChrisBuilds/terminaltexteffects")
+    (synopsis "Terminal visual effects engine and demo toy")
+    (description
+     "TerminalTextEffects (TTE) is a terminal visual effects engine.  TTE can
+be installed as a system application to produce effects in your
+terminal, or as a Python library to enable effects within your Python
+scripts/applications.  TTE includes a growing library of built-in
+effects which showcase the engine's features, including complex
+character movement via Paths, Waypoints, and motion easing, with
+support for quadratic/cubic bezier curves, complex animations via
+Scenes with symbol/color changes, layers, easing, and Path synced
+progression, and variable stop/step color gradient generation.  Runs
+inline, preserving terminal state and workflow.")
+    (license license:expat)))
+
 (define-public daikichi
   (package
     (name "daikichi")
-- 
2.46.0

Message #8 received at 75082 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: 75082 <at> debbugs.gnu.org
Cc: Andrew Wong <wongandj <at> icloud.com>
Subject: [PATCH v2] gnu: Add terminaltexteffects.
Date: Sun,  5 Jan 2025 04:33:49 -0500

* gnu/packages/toys.scm (terminaltexteffects): New variable.

Change-Id: I3b8ec681445c2d787c275788b90ce29c2f5053cf
---
 gnu/packages/toys.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/toys.scm b/gnu/packages/toys.scm
index 359cdbcbe1..b8c77490d5 100644
--- a/gnu/packages/toys.scm
+++ b/gnu/packages/toys.scm
@@ -37,11 +37,14 @@ (define-module (gnu packages toys)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pretty-print)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system copy)
   #:use-module (guix build-system meson)
+  #:use-module (guix build-system pyproject)
+  #:use-module (guix build-system python)
   #:use-module (guix download)
   #:use-module (guix gexp)
   #:use-module (guix git-download)
@@ -49,6 +52,35 @@ (define-module (gnu packages toys)
   #:use-module (guix packages)
   #:use-module (guix utils))
 
+(define-public terminaltexteffects
+  (package
+    (name "terminaltexteffects")
+    (version "0.11.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "terminaltexteffects" version))
+       (sha256
+        (base32 "1cnw2f0pwsbvva9pbiwjxc8aygvsnfjlpbhrdflh8fh0p9rwnc0l"))))
+    (build-system pyproject-build-system)
+    (arguments
+     `(#:tests? #f))
+    (inputs (list poetry))
+    (home-page "https://github.com/ChrisBuilds/terminaltexteffects")
+    (synopsis "Terminal visual effects engine and demo toy")
+    (description
+     "TerminalTextEffects (TTE) is a terminal visual effects engine.  TTE can
+be installed as a system application to produce effects in your
+terminal, or as a Python library to enable effects within your Python
+scripts/applications.  TTE includes a growing library of built-in
+effects which showcase the engine's features, including complex
+character movement via Paths, Waypoints, and motion easing, with
+support for quadratic/cubic bezier curves, complex animations via
+Scenes with symbol/color changes, layers, easing, and Path synced
+progression, and variable stop/step color gradient generation.  Runs
+inline, preserving terminal state and workflow.")
+    (license license:expat)))
+
 (define-public daikichi
   (package
     (name "daikichi")

base-commit: e383e8e34097b064d4baa4207673c6ba30617347
-- 
2.47.1

Message #11 received at 75082 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: 75082 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-terminaltexteffects. (bump)
Date: Sun, 26 Jan 2025 07:41:03 -0500

Hi, has this been seen yet? I know it's not an important package but 
it's still nice to have it upstreamed

Message #14 received at 75082 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 75082 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-terminaltexteffects.
Date: Wed, 12 Feb 2025 11:12:31 +0000

[Message part 1 (text/plain, inline)]

Hi,

Thank you for the patch.

I've got visual review points only for now

+    (arguments
+     `(#:tests? #f))
+    (inputs (list poetry))

Please use python-poetry-core and place it in native inputs.
Elaborate why no tests
Keep the variable and package name prefixed with python-

Let's check V3!

Thanks,
Oleg

[Message part 2 (text/html, inline)]

Message #17 received at 75082 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 75082 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-terminaltexteffects.
Date: Wed, 12 Feb 2025 11:16:25 +0000

[Message part 1 (text/plain, inline)]

The project provides tests
https://github.com/ChrisBuilds/terminaltexteffects/tree/0.9.3/tests
You might need to add python-pytest into native inputs to make
them work.

[Message part 2 (text/html, inline)]

Message #20 received at 75082 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Wong <wongandj <at> icloud.com>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 75082 <at> debbugs.gnu.org
Subject: Re: [bug#75082] [PATCH] gnu: Add python-terminaltexteffects.
Date: Thu, 13 Feb 2025 00:52:49 -0500

> The project provides tests 
https://github.com/ChrisBuilds/terminaltexteffects/tree/0.9.3/tests
> You might need to add python-pytest into native inputs to make
> them work.
I tried adding python-pytest and enabling tests, but I get the following 
error:
--8<---------------cut here---------------start------------->8---
starting phase `check'
Using pytest
============================= test session starts 
==============================
platform linux -- Python 3.10.7, pytest-8.3.3, pluggy-1.5.0 -- 
/gnu/store/jjzbav1s0x8lqg1aal13irspwwblwdf4-python-wrapper-3.10.7/bin/python
cachedir: .pytest_cache
hypothesis profile 'default' -> 
database=DirectoryBasedExampleDatabase('/tmp/guix-build-python-terminaltexteffects-0.11.0.drv-0/terminaltexteffects-0.11.0/.hypothesis/examples')
rootdir: 
/tmp/guix-build-python-terminaltexteffects-0.11.0.drv-0/terminaltexteffects-0.11.0
configfile: pyproject.toml
plugins: hypothesis-6.54.5
collecting ... collected 0 items

============================ no tests ran in 0.26s 
=============================
error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: 
"/gnu/store/92spfniihzr0d822qzvdfxczyacb3c5b-python-pytest-8.3.3/bin/pytest" 
arguments: ("-vv") exit-status: 5 term-signal: #f stop-signal: #f>
phase `check' failed after 0.4 seconds
command 
"/gnu/store/92spfniihzr0d822qzvdfxczyacb3c5b-python-pytest-8.3.3/bin/pytest" 
"-vv" failed with status 5
build process 18 exited with status 256
note: keeping build directory 
`/tmp/guix-build-python-terminaltexteffects-0.11.0.drv-0'
builder for 
`/gnu/store/qxln3k3razxvz0w8qgcl00c0v25xav92-python-terminaltexteffects-0.11.0.drv' 
failed with exit code 1
build of 
/gnu/store/qxln3k3razxvz0w8qgcl00c0v25xav92-python-terminaltexteffects-0.11.0.drv 
failed
View build log at 
'/var/log/guix/drvs/qx/ln3k3razxvz0w8qgcl00c0v25xav92-python-terminaltexteffects-0.11.0.drv.gz'.
guix build: error: build of 
`/gnu/store/qxln3k3razxvz0w8qgcl00c0v25xav92-python-terminaltexteffects-0.11.0.drv' 
failed
--8<---------------cut here---------------end--------------->8---
I tried poking around with guix build --keep-failed and found no trace 
of the
tests/ dir from the upstream repo, or any of the test_*.py files that were
inside and that the pytest docs[1] say are needed for tests to be found 
and run.
Is the upstream just configured wrong? Apologies if it's a trivial 
problem, I am
not a python developer.

Message #25 received at 75082-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 75082-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-terminaltexteffects.
Date: Thu, 13 Feb 2025 10:06:12 +0000

[Message part 1 (text/plain, inline)]

Hi,

I've swapped to git and enabled tests, also renamed to
python-terminaltexteffects as the project claims that it may be used as
Python module as well.

Checked:
+ PASS guix build
+ PASS all 58 tests passed successfully
+ PASS guix lint: no warnings
+ PASS visual check: synopsis, short and neat
+ PASS visual check: description, human readable and clear
+ PASS visual check: license, as specified in package definition
+ PASS visual check: project activity and release cadence

Applied:
+ PASS rename to python-terminaltexteffects
+ PASS swap to git which contains tests
+ PASS place package in alphabetical order: guix import -i
  gnu/packages/toys.scm pypi terminaltexteffects
+ PASS replace poetry with python-poetry-core
+ PASS add python-pytest
+ PASS fill-column on description

Pushed to master as 629edde10e00d3034ebcee4047ce7c872a679075.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.