GNU bug report logs - #74872
bugfix: update symlinks

Previous Next

Package: guix-patches;

Reported by: ngraves <at> ngraves.fr

Date: Sat, 14 Dec 2024 16:51:02 UTC

Severity: normal

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74872: closed (bugfix: update symlinks)
Date: Mon, 23 Dec 2024 18:05:03 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 23 Dec 2024 19:03:50 +0100
with message-id <87zfkm6zuh.fsf <at> gnu.org>
and subject line Re: bug#74872: bugfix: update symlinks
has caused the debbugs.gnu.org bug report #74872,
regarding bugfix: update symlinks
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74872: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74872
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: ngraves <at> ngraves.fr
To: guix-patches <at> gnu.org
Subject: bugfix: update symlinks
Date: Sat, 14 Dec 2024 17:49:51 +0100
[Message part 3 (text/plain, inline)]
For some reason, rename-file fails when the target and destination are 
not in the same filesystem. However, we can't assume for the 
update-symlink script that all users will always have e.g. 
~/.local/share/applications (managed by guix-home) and ~ on the same 
filesystem. My use-case is trying to implement home impermanence. The 
patch is attached.
[0001-gnu-home-Replace-rename-in-update-symlinks-scripts.patch (text/x-diff, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: ngraves <at> ngraves.fr
Cc: 74872-done <at> debbugs.gnu.org
Subject: Re: bug#74872: bugfix: update symlinks
Date: Mon, 23 Dec 2024 19:03:50 +0100
ngraves <at> ngraves.fr skribis:

> For some reason, rename-file fails when the target and destination are
> not in the same filesystem. However, we can't assume for the
> update-symlink script that all users will always have
> e.g. ~/.local/share/applications (managed by guix-home) and ~ on the
> same filesystem. My use-case is trying to implement home
> impermanence. The patch is attached.
>
> From fe07066b88556c3755db3fc29665ce93d23cc071 Mon Sep 17 00:00:00 2001
> From: Nicolas Graves <ngraves <at> ngraves.fr>
> Date: Sat, 14 Dec 2024 12:38:14 +0100
> Subject: [PATCH] gnu: home: Replace rename in update-symlinks scripts.
>
> * gnu/home/services/symlink-manager.scm (update-symlinks): Use
> copy-file and delete-file instead of rename-file to avoid an error
> when the target and backup are not in the same filesystem.

Applied, thanks!


This bug report was last modified 145 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.