GNU bug report logs - #74872
bugfix: update symlinks

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74872 in the body.
You can then email your comments to 74872 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ngraves <at> ngraves.fr
To: guix-patches <at> gnu.org
Subject: bugfix: update symlinks
Date: Sat, 14 Dec 2024 17:49:51 +0100

[Message part 1 (text/plain, inline)]

For some reason, rename-file fails when the target and destination are 
not in the same filesystem. However, we can't assume for the 
update-symlink script that all users will always have e.g. 
~/.local/share/applications (managed by guix-home) and ~ on the same 
filesystem. My use-case is trying to implement home impermanence. The 
patch is attached.

[0001-gnu-home-Replace-rename-in-update-symlinks-scripts.patch (text/x-diff, attachment)]

Message #10 received at 74872-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: ngraves <at> ngraves.fr
Cc: 74872-done <at> debbugs.gnu.org
Subject: Re: bug#74872: bugfix: update symlinks
Date: Mon, 23 Dec 2024 19:03:50 +0100

ngraves <at> ngraves.fr skribis:

> For some reason, rename-file fails when the target and destination are
> not in the same filesystem. However, we can't assume for the
> update-symlink script that all users will always have
> e.g. ~/.local/share/applications (managed by guix-home) and ~ on the
> same filesystem. My use-case is trying to implement home
> impermanence. The patch is attached.
>
> From fe07066b88556c3755db3fc29665ce93d23cc071 Mon Sep 17 00:00:00 2001
> From: Nicolas Graves <ngraves <at> ngraves.fr>
> Date: Sat, 14 Dec 2024 12:38:14 +0100
> Subject: [PATCH] gnu: home: Replace rename in update-symlinks scripts.
>
> * gnu/home/services/symlink-manager.scm (update-symlinks): Use
> copy-file and delete-file instead of rename-file to avoid an error
> when the target and backup are not in the same filesystem.

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.